On Tue, 29 Oct 2024 19:50:46 GMT, rebarbora-mckvak wrote:
>> This fixes the defect described at
>> https://bugs.openjdk.org/browse/JDK-8313367
>>
>> If the process does not have write permissions, the store is opened as
>> read-only (instead of failing).
>>
>> Please note that permissions to
On Tue, 29 Oct 2024 19:50:46 GMT, rebarbora-mckvak wrote:
>> This fixes the defect described at
>> https://bugs.openjdk.org/browse/JDK-8313367
>>
>> If the process does not have write permissions, the store is opened as
>> read-only (instead of failing).
>>
>> Please note that permissions to
On Tue, 29 Oct 2024 19:52:29 GMT, rebarbora-mckvak wrote:
>> rebarbora-mckvak has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8313367: getting PP_KEYSET_TYPE parameter fixed
>
> Wierd, I do not see those comments in github. Anyway it is
On Tue, 29 Oct 2024 19:50:46 GMT, rebarbora-mckvak wrote:
>> This fixes the defect described at
>> https://bugs.openjdk.org/browse/JDK-8313367
>>
>> If the process does not have write permissions, the store is opened as
>> read-only (instead of failing).
>>
>> Please note that permissions to
On Tue, 29 Oct 2024 19:50:46 GMT, rebarbora-mckvak wrote:
>> This fixes the defect described at
>> https://bugs.openjdk.org/browse/JDK-8313367
>>
>> If the process does not have write permissions, the store is opened as
>> read-only (instead of failing).
>>
>> Please note that permissions to
On Fri, 22 Mar 2024 22:25:47 GMT, rebarbora-mckvak wrote:
>> This fixes the defect described at
>> https://bugs.openjdk.org/browse/JDK-8313367
>>
>> If the process does not have write permissions, the store is opened as
>> read-only (instead of failing).
>>
>> Please note that permissions to
On Tue, 29 Oct 2024 19:50:46 GMT, rebarbora-mckvak wrote:
>> This fixes the defect described at
>> https://bugs.openjdk.org/browse/JDK-8313367
>>
>> If the process does not have write permissions, the store is opened as
>> read-only (instead of failing).
>>
>> Please note that permissions to
On Tue, 29 Oct 2024 19:52:29 GMT, rebarbora-mckvak wrote:
> Wierd, I do not see those comments in github. Anyway it is fixed now.
@rebarbora-mckvak - change looks good to me
@wangweij - this commit addresses the two issues I highlighted, I don't have
any other concerns
-
PR Comme
On Tue, 29 Oct 2024 19:50:46 GMT, rebarbora-mckvak wrote:
>> This fixes the defect described at
>> https://bugs.openjdk.org/browse/JDK-8313367
>>
>> If the process does not have write permissions, the store is opened as
>> read-only (instead of failing).
>>
>> Please note that permissions to
> This fixes the defect described at https://bugs.openjdk.org/browse/JDK-8313367
>
> If the process does not have write permissions, the store is opened as
> read-only (instead of failing).
>
> Please note that permissions to use a certificate in a local machine store
> must be granted - in a m
On Tue, 15 Oct 2024 17:59:52 GMT, rebarbora-mckvak wrote:
>> This fixes the defect described at
>> https://bugs.openjdk.org/browse/JDK-8313367
>>
>> If the process does not have write permissions, the store is opened as
>> read-only (instead of failing).
>>
>> Please note that permissions to
On Tue, 29 Oct 2024 15:34:37 GMT, Mat Carter wrote:
>> @wangweij, please see the release note above.
>
>> @rebarbora-mckvak I've added the release note as
>> https://bugs.openjdk.org/browse/JDK-8340661 last month.
>>
>> I didn't approve because of Mat's Aug 14 comment:
>>
>> > I think there's
On Tue, 29 Oct 2024 15:34:37 GMT, Mat Carter wrote:
>> @wangweij, please see the release note above.
>
>> @rebarbora-mckvak I've added the release note as
>> https://bugs.openjdk.org/browse/JDK-8340661 last month.
>>
>> I didn't approve because of Mat's Aug 14 comment:
>>
>> > I think there's
On Tue, 15 Oct 2024 08:29:28 GMT, rebarbora-mckvak wrote:
>> @rebarbora-mckvak Please put the release note here and I can create it.
>> Thanks.
>
> @wangweij, please see the release note above.
> @rebarbora-mckvak I've added the release note as
> https://bugs.openjdk.org/browse/JDK-8340661 las
On Tue, 15 Oct 2024 17:59:52 GMT, rebarbora-mckvak wrote:
>> This fixes the defect described at
>> https://bugs.openjdk.org/browse/JDK-8313367
>>
>> If the process does not have write permissions, the store is opened as
>> read-only (instead of failing).
>>
>> Please note that permissions to
> This fixes the defect described at https://bugs.openjdk.org/browse/JDK-8313367
>
> If the process does not have write permissions, the store is opened as
> read-only (instead of failing).
>
> Please note that permissions to use a certificate in a local machine store
> must be granted - in a m
On Mon, 16 Sep 2024 21:22:45 GMT, rebarbora-mckvak wrote:
>> This fixes the defect described at
>> https://bugs.openjdk.org/browse/JDK-8313367
>>
>> If the process does not have write permissions, the store is opened as
>> read-only (instead of failing).
>>
>> Please note that permissions to
On Tue, 15 Oct 2024 08:29:28 GMT, rebarbora-mckvak wrote:
>> @rebarbora-mckvak Please put the release note here and I can create it.
>> Thanks.
>
> @wangweij, please see the release note above.
@rebarbora-mckvak I've added the release note as
https://bugs.openjdk.org/browse/JDK-8340661 last mo
On Wed, 14 Aug 2024 21:53:52 GMT, Weijun Wang wrote:
>> I tried to follow the instructions to write a release note, but since this
>> is my first contribution, I do not have an account on JBS.
>
> @rebarbora-mckvak Please put the release note here and I can create it.
> Thanks.
@wangweij, plea
> This fixes the defect described at https://bugs.openjdk.org/browse/JDK-8313367
>
> If the process does not have write permissions, the store is opened as
> read-only (instead of failing).
>
> Please note that permissions to use a certificate in a local machine store
> must be granted - in a m
On Wed, 10 Apr 2024 21:10:16 GMT, rebarbora-mckvak wrote:
>> This fixes the defect described at
>> https://bugs.openjdk.org/browse/JDK-8313367
>>
>> If the process does not have write permissions, the store is opened as
>> read-only (instead of failing).
>>
>> Please note that permissions to
On Wed, 14 Aug 2024 21:50:37 GMT, rebarbora-mckvak wrote:
>> rebarbora-mckvak has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8313367: copyright updated
>
> I tried to follow the instructions to write a release note, but since this is
>
On Wed, 10 Apr 2024 21:10:16 GMT, rebarbora-mckvak wrote:
>> This fixes the defect described at
>> https://bugs.openjdk.org/browse/JDK-8313367
>>
>> If the process does not have write permissions, the store is opened as
>> read-only (instead of failing).
>>
>> Please note that permissions to
On Fri, 19 Apr 2024 20:04:57 GMT, Weijun Wang wrote:
>> @wangweij , your [comment on
>> JDK-8313367](https://bugs.openjdk.org/browse/JDK-8313367?focusedId=14664542&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14664542)
>> indicates you are unable to request a
On Thu, 11 Apr 2024 11:35:01 GMT, Sean Mullan wrote:
>>> But because of user privilege missing, the private key is not available and
>>> it shows as a certificate entry.
>>
>> You can have applications that need a certificate (public key) only e.g. to
>> verify signatures. This way you can use
On Fri, 19 Apr 2024 18:51:32 GMT, MustavData wrote:
>> @rebarbora-mckvak Can you please update [this
>> test](https://github.com/openjdk/jdk/blob/master/test/jdk/sun/security/mscapi/AllTypes.java)?
>> There is no need for the `hasAdminPrivileges` flag now.
>
> @wangweij , your [comment on
> JD
On Thu, 11 Apr 2024 13:04:06 GMT, Weijun Wang wrote:
>>> But because of user privilege missing, the private key is not available and
>>> it shows as a certificate entry.
>>
>> You can have applications that need a certificate (public key) only e.g. to
>> verify signatures. This way you can use
On Thu, 11 Apr 2024 13:01:36 GMT, Weijun Wang wrote:
> [One of the
> test](https://github.com/openjdk/jdk/blob/master/test/jdk/sun/security/mscapi/VeryLongAlias.java)
good link, thanks. Didn’t know the type is even visible for an assert.
-
PR Comment: https://git.openjdk.org/jdk/
On Wed, 10 Apr 2024 13:09:37 GMT, rebarbora-mckvak wrote:
>> Yes it's self signed one.
>>
>> No it's not added to any other keystore. When I said
>> "TrustedCertificateEntry" it's only because in a Java KeyStore an entry with
>> only a certificate is called a TrustedCertificateEntry.
>>
>> So
On Thu, 11 Apr 2024 07:57:12 GMT, Bernd wrote:
>> rebarbora-mckvak has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8313367: copyright updated
>
> Did you test with CNG keys as well? Using the new providers is much more
> important since
On Wed, 10 Apr 2024 13:09:37 GMT, rebarbora-mckvak wrote:
>> Yes it's self signed one.
>>
>> No it's not added to any other keystore. When I said
>> "TrustedCertificateEntry" it's only because in a Java KeyStore an entry with
>> only a certificate is called a TrustedCertificateEntry.
>>
>> So
On Wed, 10 Apr 2024 21:10:16 GMT, rebarbora-mckvak wrote:
>> This fixes the defect described at
>> https://bugs.openjdk.org/browse/JDK-8313367
>>
>> If the process does not have write permissions, the store is opened as
>> read-only (instead of failing).
>>
>> Please note that permissions to
On Wed, 10 Apr 2024 14:43:27 GMT, Weijun Wang wrote:
>> rebarbora-mckvak has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8313367: signHash looks for a key in either user or machine store
>
> The code change looks good to me. I think it's
On Wed, 10 Apr 2024 20:46:20 GMT, rebarbora-mckvak wrote:
>> src/jdk.crypto.mscapi/windows/native/libsunmscapi/security.cpp line 807:
>>
>>> 805: // Acquire an alternative CSP handle
>>> 806: if (::CryptAcquireContext(&hCryptProvAlt, LPCSTR(pbData),
>>> NULL, //deprecate
On Wed, 10 Apr 2024 21:10:16 GMT, rebarbora-mckvak wrote:
>> This fixes the defect described at
>> https://bugs.openjdk.org/browse/JDK-8313367
>>
>> If the process does not have write permissions, the store is opened as
>> read-only (instead of failing).
>>
>> Please note that permissions to
On Wed, 10 Apr 2024 14:38:04 GMT, Weijun Wang wrote:
>> rebarbora-mckvak has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8313367: signHash looks for a key in either user or machine store
>
> src/jdk.crypto.mscapi/windows/native/libsunmsc
> This fixes the defect described at https://bugs.openjdk.org/browse/JDK-8313367
>
> If the process does not have write permissions, the store is opened as
> read-only (instead of failing).
>
> Please note that permissions to use a certificate in a local machine store
> must be granted - in a m
On Fri, 22 Mar 2024 22:25:47 GMT, rebarbora-mckvak wrote:
>> This fixes the defect described at
>> https://bugs.openjdk.org/browse/JDK-8313367
>>
>> If the process does not have write permissions, the store is opened as
>> read-only (instead of failing).
>>
>> Please note that permissions to
On Fri, 22 Mar 2024 22:25:47 GMT, rebarbora-mckvak wrote:
>> This fixes the defect described at
>> https://bugs.openjdk.org/browse/JDK-8313367
>>
>> If the process does not have write permissions, the store is opened as
>> read-only (instead of failing).
>>
>> Please note that permissions to
On Tue, 9 Apr 2024 13:47:43 GMT, Weijun Wang wrote:
> But because of user privilege missing, the private key is not available and
> it shows as a certificate entry.
You can have applications that need a certificate (public key) only e.g. to
verify signatures. This way you can use the same entr
On Fri, 22 Mar 2024 22:25:47 GMT, rebarbora-mckvak wrote:
>> This fixes the defect described at
>> https://bugs.openjdk.org/browse/JDK-8313367
>>
>> If the process does not have write permissions, the store is opened as
>> read-only (instead of failing).
>>
>> Please note that permissions to
On Wed, 3 Apr 2024 21:54:02 GMT, Weijun Wang wrote:
> When UAC is enabled and there is no privilege, I can see that some private
> key entries (Ex: the one for iis) become trusted certificate entries, which
> means their private key is not observable. Have you noticed something
> similar? Are
On Fri, 22 Mar 2024 22:25:47 GMT, rebarbora-mckvak wrote:
>> This fixes the defect described at
>> https://bugs.openjdk.org/browse/JDK-8313367
>>
>> If the process does not have write permissions, the store is opened as
>> read-only (instead of failing).
>>
>> Please note that permissions to
On Fri, 22 Mar 2024 18:43:11 GMT, MustavData wrote:
>> I also noticed a different problem. No matter if privileged or unprivileged,
>> `keytool -genkeypair -storetype Windows-My-LOCALMACHINE` works successfully
>> but the entries are actually created in Windows-MY-CURRENTUSER. This is
>> unrel
On Fri, 22 Mar 2024 22:25:47 GMT, rebarbora-mckvak wrote:
>> This fixes the defect described at
>> https://bugs.openjdk.org/browse/JDK-8313367
>>
>> If the process does not have write permissions, the store is opened as
>> read-only (instead of failing).
>>
>> Please note that permissions to
On Fri, 22 Mar 2024 22:25:47 GMT, rebarbora-mckvak wrote:
>> This fixes the defect described at
>> https://bugs.openjdk.org/browse/JDK-8313367
>>
>> If the process does not have write permissions, the store is opened as
>> read-only (instead of failing).
>>
>> Please note that permissions to
> This fixes the defect described at https://bugs.openjdk.org/browse/JDK-8313367
>
> If the process does not have write permissions, the store is opened as
> read-only (instead of failing).
>
> Please note that permissions to use a certificate in a local machine store
> must be granted - in a m
On Wed, 20 Mar 2024 19:45:32 GMT, Weijun Wang wrote:
>> rebarbora-mckvak has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains two commits:
>>
>> - 8313367: signHash finds a key in the local machine store
>> - 8313367: Local Computer
On Fri, 22 Mar 2024 18:43:11 GMT, MustavData wrote:
>> I also noticed a different problem. No matter if privileged or unprivileged,
>> `keytool -genkeypair -storetype Windows-My-LOCALMACHINE` works successfully
>> but the entries are actually created in Windows-MY-CURRENTUSER. This is
>> unrel
On Thu, 14 Mar 2024 15:53:23 GMT, Weijun Wang wrote:
>> This fixes the defect described at
>> https://bugs.openjdk.org/browse/JDK-8313367
>>
>> If the process does not have write permissions, the store is opened as
>> read-only (instead of failing).
>>
>> Please note that permissions to use a
On Tue, 19 Mar 2024 15:23:39 GMT, rebarbora-mckvak wrote:
>> This fixes the defect described at
>> https://bugs.openjdk.org/browse/JDK-8313367
>>
>> If the process does not have write permissions, the store is opened as
>> read-only (instead of failing).
>>
>> Please note that permissions to
On Tue, 19 Mar 2024 15:23:39 GMT, rebarbora-mckvak wrote:
>> This fixes the defect described at
>> https://bugs.openjdk.org/browse/JDK-8313367
>>
>> If the process does not have write permissions, the store is opened as
>> read-only (instead of failing).
>>
>> Please note that permissions to
> This fixes the defect described at https://bugs.openjdk.org/browse/JDK-8313367
>
> If the process does not have write permissions, the store is opened as
> read-only (instead of failing).
>
> Please note that permissions to use a certificate in a local machine store
> must be granted - in a m
> This fixes the defect described at https://bugs.openjdk.org/browse/JDK-8313367
>
> If the process does not have write permissions, the store is opened as
> read-only (instead of failing).
>
> Please note that permissions to use a certificate in a local machine store
> must be granted - in a m
On Thu, 16 Nov 2023 12:06:26 GMT, rebarbora-mckvak wrote:
> This fixes the defect described at https://bugs.openjdk.org/browse/JDK-8313367
>
> If the process does not have write permissions, the store is opened as
> read-only (instead of failing).
>
> Please note that permissions to use a cert
On Thu, 16 Nov 2023 12:06:26 GMT, rebarbora-mckvak wrote:
> This fixes the defect described at https://bugs.openjdk.org/browse/JDK-8313367
>
> If the process does not have write permissions, the store is opened as
> read-only (instead of failing).
>
> Please note that permissions to use a cert
On Thu, 16 Nov 2023 12:06:26 GMT, rebarbora-mckvak wrote:
> This fixes the defect described at https://bugs.openjdk.org/browse/JDK-8313367
>
> If the process does not have write permissions, the store is opened as
> read-only (instead of failing).
>
> Please note that permissions to use a cert
On Thu, 16 Nov 2023 12:06:26 GMT, rebarbora-mckvak wrote:
> This fixes the defect described at https://bugs.openjdk.org/browse/JDK-8313367
>
> If the process does not have write permissions, the store is opened as
> read-only (instead of failing).
>
> Please note that permissions to use a cert
On Thu, 16 Nov 2023 12:06:26 GMT, rebarbora-mckvak wrote:
> This fixes the defect described at https://bugs.openjdk.org/browse/JDK-8313367
>
> If the process does not have write permissions, the store is opened as
> read-only (instead of failing).
>
> Please note that permissions to use a cert
On Thu, 16 Nov 2023 12:06:26 GMT, rebarbora-mckvak wrote:
> This fixes the defect described at https://bugs.openjdk.org/browse/JDK-8313367
>
> If the process does not have write permissions, the store is opened as
> read-only (instead of failing).
>
> Please note that permissions to use a cert
On Wed, 13 Mar 2024 16:57:17 GMT, Mat Carter wrote:
>> This fixes the defect described at
>> https://bugs.openjdk.org/browse/JDK-8313367
>>
>> If the process does not have write permissions, the store is opened as
>> read-only (instead of failing).
>>
>> Please note that permissions to use a
On Thu, 16 Nov 2023 12:06:26 GMT, rebarbora-mckvak wrote:
> This fixes the defect described at https://bugs.openjdk.org/browse/JDK-8313367
>
> If the process does not have write permissions, the store is opened as
> read-only (instead of failing).
>
> Please note that permissions to use a cert
On Thu, 16 Nov 2023 12:06:26 GMT, rebarbora-mckvak wrote:
> This fixes the defect described at https://bugs.openjdk.org/browse/JDK-8313367
>
> If the process does not have write permissions, the store is opened as
> read-only (instead of failing).
>
> Please note that permissions to use a cert
On Thu, 16 Nov 2023 12:06:26 GMT, rebarbora-mckvak wrote:
> This fixes the defect described at https://bugs.openjdk.org/browse/JDK-8313367
>
> If the process does not have write permissions, the store is opened as
> read-only (instead of failing).
>
> Please note that permissions to use a cert
On Mon, 4 Mar 2024 23:55:50 GMT, Mat Carter wrote:
>> This fixes the defect described at
>> https://bugs.openjdk.org/browse/JDK-8313367
>>
>> If the process does not have write permissions, the store is opened as
>> read-only (instead of failing).
>>
>> Please note that permissions to use a c
On Thu, 16 Nov 2023 12:06:26 GMT, rebarbora-mckvak wrote:
> This fixes the defect described at https://bugs.openjdk.org/browse/JDK-8313367
>
> If the process does not have write permissions, the store is opened as
> read-only (instead of failing).
>
> Please note that permissions to use a cert
On Thu, 16 Nov 2023 12:06:26 GMT, rebarbora-mckvak wrote:
> This fixes the defect described at https://bugs.openjdk.org/browse/JDK-8313367
>
> If the process does not have write permissions, the store is opened as
> read-only (instead of failing).
>
> Please note that permissions to use a cert
On Wed, 24 Jan 2024 00:41:15 GMT, Mat Carter wrote:
>> This fixes the defect described at
>> https://bugs.openjdk.org/browse/JDK-8313367
>>
>> If the process does not have write permissions, the store is opened as
>> read-only (instead of failing).
>>
>> Please note that permissions to use a
On Thu, 16 Nov 2023 12:06:26 GMT, rebarbora-mckvak wrote:
> This fixes the defect described at https://bugs.openjdk.org/browse/JDK-8313367
>
> If the process does not have write permissions, the store is opened as
> read-only (instead of failing).
>
> Please note that permissions to use a cert
On Thu, 16 Nov 2023 12:06:26 GMT, rebarbora-mckvak wrote:
> This fixes the defect described at https://bugs.openjdk.org/browse/JDK-8313367
>
> If the process does not have write permissions, the store is opened as
> read-only (instead of failing).
>
> Please note that permissions to use a cert
On Thu, 16 Nov 2023 12:06:26 GMT, rebarbora-mckvak wrote:
> This fixes the defect described at https://bugs.openjdk.org/browse/JDK-8313367
>
> If the process does not have write permissions, the store is opened as
> read-only (instead of failing).
>
> Please note that permissions to use a cert
On Tue, 19 Dec 2023 11:52:01 GMT, rebarbora-mckvak wrote:
>> This fixes the defect described at
>> https://bugs.openjdk.org/browse/JDK-8313367
>>
>> If the process does not have write permissions, the store is opened as
>> read-only (instead of failing).
>>
>> Please note that permissions to
On Thu, 16 Nov 2023 12:06:26 GMT, rebarbora-mckvak wrote:
> This fixes the defect described at https://bugs.openjdk.org/browse/JDK-8313367
>
> If the process does not have write permissions, the store is opened as
> read-only (instead of failing).
>
> Please note that permissions to use a cert
On Thu, 16 Nov 2023 12:06:26 GMT, rebarbora-mckvak wrote:
> This fixes the defect described at https://bugs.openjdk.org/browse/JDK-8313367
>
> If the process does not have write permissions, the store is opened as
> read-only (instead of failing).
>
> Please note that permissions to use a cert
On Thu, 16 Nov 2023 12:06:26 GMT, rebarbora-mckvak wrote:
> This fixes the defect described at https://bugs.openjdk.org/browse/JDK-8313367
>
> If the process does not have write permissions, the store is opened as
> read-only (instead of failing).
>
> Please note that permissions to use a cert
On Thu, 16 Nov 2023 12:06:26 GMT, rebarbora-mckvak wrote:
> This fixes the defect described at https://bugs.openjdk.org/browse/JDK-8313367
>
> If the process does not have write permissions, the store is opened as
> read-only (instead of failing).
>
> Please note that permissions to use a cert
76 matches
Mail list logo
