On Wed, 3 May 2023 17:42:14 GMT, Rajan Halade wrote:
> Looks good to me. Please don't forget to update the release note and backport
> to JDK 20u.
Thanks @rhalade. Will do.
-
PR Comment: https://git.openjdk.org/jdk/pull/13754#issuecomment-1533751038
On Tue, 2 May 2023 21:27:18 GMT, Jiangli Zhou wrote:
>> This PR was requested by awar...@google.com. The updates were provided by
>> awar...@google.com.
>
> Jiangli Zhou has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update test/jdk/sun/s
On Tue, 2 May 2023 18:42:36 GMT, Rajan Halade wrote:
>> This PR was requested by awar...@google.com. The updates were provided by
>> awar...@google.com.
>
>> > >
>> >
>> >
>> > I have infra tests for interop implemented. @jianglizhou, please check
>> > https://github.com/openjdk/jdk/compare/
On Tue, 2 May 2023 21:27:18 GMT, Jiangli Zhou wrote:
>> This PR was requested by awar...@google.com. The updates were provided by
>> awar...@google.com.
>
> Jiangli Zhou has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update test/jdk/sun/s
On Tue, 2 May 2023 21:11:09 GMT, Jiangli Zhou wrote:
>> Thanks for the explanation. Please file a different issue for this change,
>> since it is outside the scope of this issue, which is to specifically add
>> new roots that have been approved by the Java SE CA Root Program processes.
>> Upda
> This PR was requested by awar...@google.com. The updates were provided by
> awar...@google.com.
Jiangli Zhou has updated the pull request incrementally with one additional
commit since the last revision:
Update test/jdk/sun/security/lib/cacerts/VerifyCACerts.java after reverting
src/java.b
On Tue, 2 May 2023 20:36:57 GMT, Sean Mullan wrote:
>> The original R4 did not have the digitalSignature keyUsage set. This root
>> signs OCSP responses, so it needed to be reissued to comply with section
>> 7.1.2.1 of the CA/B Forum baseline requirements. The only change between the
>> two ve
> This PR was requested by awar...@google.com. The updates were provided by
> awar...@google.com.
Jiangli Zhou has updated the pull request incrementally with one additional
commit since the last revision:
Revert the src/java.base/share/data/cacerts/globalsigneccrootcar4 change.
> This PR was requested by awar...@google.com. The updates were provided by
> awar...@google.com.
Jiangli Zhou has updated the pull request incrementally with one additional
commit since the last revision:
Add GoogleCA.java test from @rhalade.
-
Changes:
- all: https://git.ope
On Tue, 2 May 2023 18:42:36 GMT, Rajan Halade wrote:
> You can include this contribution in your PR. Then it will be easier to
> backport to JDK 20u as one changeset. I updated bug id in the changeset.
Done. Please double check.
I ran the GoogleCA.java test with a test JDK binary built with th
On Tue, 2 May 2023 18:51:52 GMT, Andy Warner wrote:
>> src/java.base/share/data/cacerts/globalsigneccrootcar4 line 3:
>>
>>> 1: Owner: CN=GlobalSign, O=GlobalSign, OU=GlobalSign ECC Root CA - R4
>>> 2: Issuer: CN=GlobalSign, O=GlobalSign, OU=GlobalSign ECC Root CA - R4
>>> 3: Serial number: 203e
On Tue, 2 May 2023 18:42:36 GMT, Rajan Halade wrote:
> >
>
> I have infra tests for interop implemented. @jianglizhou, please check
> https://github.com/openjdk/jdk/compare/master...rhalade:jdk:googletrust-certify?expand=1
Aside from the bug number @jianglizhou raised, the interop tests look
On Tue, 2 May 2023 16:35:18 GMT, Jiangli Zhou wrote:
> This PR was requested by awar...@google.com. The updates were provided by
> awar...@google.com.
> > >
> >
> >
> > I have infra tests for interop implemented. @jianglizhou, please check
> > https://github.com/openjdk/jdk/compare/master..
On Tue, 2 May 2023 17:29:07 GMT, Rajan Halade wrote:
> >
>
> I have infra tests for interop implemented. @jianglizhou, please check
> https://github.com/openjdk/jdk/compare/master...rhalade:jdk:googletrust-certify?expand=1
@rhalade, thanks! I have a minor comment below for your
test/jdk/secu
On Tue, 2 May 2023 17:29:07 GMT, Rajan Halade wrote:
>> This PR was requested by awar...@google.com. The updates were provided by
>> awar...@google.com.
>
>>
>
> I have infra tests for interop implemented. @jianglizhou, please check
> https://github.com/openjdk/jdk/compare/master...rhalade:jd
On Tue, 2 May 2023 16:35:18 GMT, Jiangli Zhou wrote:
> This PR was requested by awar...@google.com. The updates were provided by
> awar...@google.com.
>
I have infra tests for interop implemented. @jianglizhou, please check
https://github.com/openjdk/jdk/compare/master...rhalade:jdk:googletr
On Tue, 2 May 2023 16:35:18 GMT, Jiangli Zhou wrote:
> This PR was requested by awar...@google.com. The updates were provided by
> awar...@google.com.
Ideally, an infra test for testing test certs should also be added. @rhalade
may be able to contribute this.
-
PR Comment: https:
This PR was requested by awar...@google.com. The updates are provided by
awar...@google.com.
-
Commit messages:
- Merge branch 'master' into JDK-8307134
- 8307134: Add GTS root CAs
Changes: https://git.openjdk.org/jdk/pull/13754/files
Webrev: https://webrevs.openjdk.org/?repo=jdk
18 matches
Mail list logo
