On Sat, 23 Jul 2022 05:29:07 GMT, jquanC wrote:
>> There are some doc errors in sun.security.util.DerOutputStream, like the
>> followings,
>>
>>
>> /**
>> * Private helper routine for writing DER encoded string values.
>> * @param s the string to write
>> * @param stringTag one of the DER s
On Sat, 23 Jul 2022 05:37:16 GMT, jquanC wrote:
>> Looks good to me. Thanks!
>
>> Looks good to me. Thanks!
>
> Cheers and appreciation! And I have learned more from your guidance.
> @jquanC Please type`/integrate` if you want to get the fix included in
> OpenJDK.
Thanks for your reminder!
I
On Sat, 23 Jul 2022 05:37:16 GMT, jquanC wrote:
>> Looks good to me. Thanks!
>
>> Looks good to me. Thanks!
>
> Cheers and appreciation! And I have learned more from your guidance.
@jquanC Please type`/integrate` if you want to get the fix included in OpenJDK.
-
PR: https://git.o
On Sat, 23 Jul 2022 05:31:29 GMT, Xue-Lei Andrew Fan wrote:
> Looks good to me. Thanks!
Cheers and appreciation! And I have learned more from your guidance.
-
PR: https://git.openjdk.org/jdk/pull/9585
On Sat, 23 Jul 2022 05:29:07 GMT, jquanC wrote:
>> There are some doc errors in sun.security.util.DerOutputStream, like the
>> followings,
>>
>>
>> /**
>> * Private helper routine for writing DER encoded string values.
>> * @param s the string to write
>> * @param stringTag one of the DER s
> There are some doc errors in sun.security.util.DerOutputStream, like the
> followings,
>
>
> /**
> * Private helper routine for writing DER encoded string values.
> * @param s the string to write
> * @param stringTag one of the DER string tags that indicate which
> * encoding should be use
On Fri, 22 Jul 2022 17:39:20 GMT, Weijun Wang wrote:
> Two comments:
>
> 1. You reverted the `s/i/buf/` change in `putInteger`.
> 2. The other constructor also uses `an DER output steam`. Since you already
> fixed one, please take care of this one as well.
Got it, I will take care of that.
--
On Fri, 22 Jul 2022 17:37:40 GMT, Weijun Wang wrote:
> A spec for an argument should be a noun. You can add attributes to describe
> it in more detail, which can be an adjective, or even a clause. This is
> what's shown in the 2nd line (I cannot call it a sentence because it's just a
> noun wi
On Fri, 22 Jul 2022 15:56:58 GMT, jquanC wrote:
>> src/java.base/share/classes/sun/security/util/DerOutputStream.java line 464:
>>
>>> 462: * @param stringTag one of the DER string tags that indicate which
>>> 463: * encoding should be used to write the string out.
>>> 464: * @par
On Fri, 22 Jul 2022 16:29:55 GMT, jquanC wrote:
>> There are some doc errors in sun.security.util.DerOutputStream, like the
>> followings,
>>
>>
>> /**
>> * Private helper routine for writing DER encoded string values.
>> * @param s the string to write
>> * @param stringTag one of the DER s
> There are some doc errors in sun.security.util.DerOutputStream, like the
> followings,
>
>
> /**
> * Private helper routine for writing DER encoded string values.
> * @param s the string to write
> * @param stringTag one of the DER string tags that indicate which
> * encoding should be use
On Fri, 22 Jul 2022 15:11:43 GMT, Xue-Lei Andrew Fan wrote:
>> jquanC has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> 8290775: Some doc errors in DerOutputStream.java Update:correct the tense
>> problem of expression
>
> src/java.base/
On Fri, 22 Jul 2022 14:56:34 GMT, jquanC wrote:
>> There are some doc errors in sun.security.util.DerOutputStream, like the
>> followings,
>>
>>
>> /**
>> * Private helper routine for writing DER encoded string values.
>> * @param s the string to write
>> * @param stringTag one of the DER s
> There are some doc errors in sun.security.util.DerOutputStream, like the
> followings,
>
>
> /**
> * Private helper routine for writing DER encoded string values.
> * @param s the string to write
> * @param stringTag one of the DER string tags that indicate which
> * encoding should be use
On Fri, 22 Jul 2022 12:44:54 GMT, Weijun Wang wrote:
> `s/is should used/should be used/`.
Thanks for your advice!
Yes, the passive voice should be used.
I may offer an update like:
@param charset the charset should be used corresponding to the above tag.
-
PR: https://git.openjdk
On Fri, 22 Jul 2022 08:27:38 GMT, jquanC wrote:
>> There are some doc errors in sun.security.util.DerOutputStream, like the
>> followings,
>>
>>
>> /**
>> * Private helper routine for writing DER encoded string values.
>> * @param s the string to write
>> * @param stringTag one of the DER s
> There are some doc errors in sun.security.util.DerOutputStream, like the
> followings,
>
>
> /**
> * Private helper routine for writing DER encoded string values.
> * @param s the string to write
> * @param stringTag one of the DER string tags that indicate which
> * encoding should be use
On Fri, 22 Jul 2022 01:43:06 GMT, jquanC wrote:
> On the second point, I have some doubts. 1) Here don't need to add
> ***@***.*** charset" because it's clear to everyone? ***@***.*** enc" does
> not seem to be used in the method. Shouldn't it be deleted?
Sorry for the confusing.
I think it i
On Thu, 21 Jul 2022 08:53:31 GMT, jquanC wrote:
> There are some doc errors in sun.security.util.DerOutputStream, like the
> followings,
>
>
> /**
> * Private helper routine for writing DER encoded string values.
> * @param s the string to write
> * @param stringTag one of the DER string ta
On Thu, 21 Jul 2022 08:53:31 GMT, jquanC wrote:
> There are some doc errors in sun.security.util.DerOutputStream, like the
> followings,
>
>
> /**
> * Private helper routine for writing DER encoded string values.
> * @param s the string to write
> * @param stringTag one of the DER string ta
There are some doc errors in sun.security.util.DerOutputStream, like the
followings,
/**
* Private helper routine for writing DER encoded string values.
* @param s the string to write
* @param stringTag one of the DER string tags that indicate which
* encoding should be used to write the str
21 matches
Mail list logo
