Re: RFR: 8275338: Add JFR events for notable serialization situations [v15]

2024-01-17 Thread Raffaello Giulietti
On Mon, 15 Jan 2024 14:17:40 GMT, Raffaello Giulietti wrote: >> Adds serialization misdeclaration events to JFR. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Removed useless event settings in test. I plan to int

Re: RFR: 8275338: Add JFR events for notable serialization situations [v15]

2024-01-15 Thread Erik Gahlin
On Mon, 15 Jan 2024 14:17:40 GMT, Raffaello Giulietti wrote: >> Adds serialization misdeclaration events to JFR. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Removed useless event settings in test. Marked as rev

Re: RFR: 8275338: Add JFR events for notable serialization situations [v15]

2024-01-15 Thread Raffaello Giulietti
> Adds serialization misdeclaration events to JFR. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: Removed useless event settings in test. - Changes: - all: https://git.openjdk.org/jdk/pull/17129/files - new:

Re: RFR: 8275338: Add JFR events for notable serialization situations [v5]

2024-01-15 Thread Erik Gahlin
On Tue, 19 Dec 2023 17:53:49 GMT, Erik Gahlin wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Changes according to reviewer's comments. > >> You mean, in the @description annotation? > > Yes. > @egahlin Ar

Re: RFR: 8275338: Add JFR events for notable serialization situations [v14]

2024-01-15 Thread Raffaello Giulietti
On Wed, 10 Jan 2024 18:56:45 GMT, Raffaello Giulietti wrote: >> Adds serialization misdeclaration events to JFR. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Small space optimization. Anybody from security wants

Re: RFR: 8275338: Add JFR events for notable serialization situations [v5]

2024-01-15 Thread Raffaello Giulietti
On Tue, 19 Dec 2023 17:53:49 GMT, Erik Gahlin wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Changes according to reviewer's comments. > >> You mean, in the @description annotation? > > Yes. @egahlin Are

Re: RFR: 8275338: Add JFR events for notable serialization situations [v14]

2024-01-12 Thread Roger Riggs
On Wed, 10 Jan 2024 18:56:45 GMT, Raffaello Giulietti wrote: >> Adds serialization misdeclaration events to JFR. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Small space optimization. Thanks for the updates. LG

Re: RFR: 8275338: Add JFR events for notable serialization situations [v14]

2024-01-10 Thread Raffaello Giulietti
> Adds serialization misdeclaration events to JFR. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: Small space optimization. - Changes: - all: https://git.openjdk.org/jdk/pull/17129/files - new: https://git.op

Re: RFR: 8275338: Add JFR events for notable serialization situations [v4]

2024-01-10 Thread Roger Riggs
On Wed, 10 Jan 2024 17:41:41 GMT, Raffaello Giulietti wrote: >> The spec is silent about methods being 'native'; it would generally be >> impractical to implement native methods for these purposes, but a native >> method can implement the behavior. > > @RogerRiggs The checks are agnostic about

Re: RFR: 8275338: Add JFR events for notable serialization situations [v4]

2024-01-10 Thread Raffaello Giulietti
On Wed, 10 Jan 2024 16:58:43 GMT, Roger Riggs wrote: >> I'm not sure that a `native` method is not considered effective by >> serialization. I have to check. > > The spec is silent about methods being 'native'; it would generally be > impractical to implement native methods for these purposes,

Re: RFR: 8275338: Add JFR events for notable serialization situations [v13]

2024-01-10 Thread Raffaello Giulietti
On Wed, 10 Jan 2024 16:55:58 GMT, Roger Riggs wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Changes according to reviewers feedback. > > src/java.base/share/classes/java/io/SerializationMisdeclarationCheck

Re: RFR: 8275338: Add JFR events for notable serialization situations [v12]

2024-01-10 Thread Raffaello Giulietti
On Wed, 10 Jan 2024 16:49:50 GMT, Roger Riggs wrote: >> Conceptually, these are independent types. There's no logical relationship >> between them. Sharing a zero length array would convey a false sense of >> logical sharing. > > true, but its wasted space and IMHO ok as a local and private imp

Re: RFR: 8275338: Add JFR events for notable serialization situations [v4]

2024-01-10 Thread Roger Riggs
On Tue, 19 Dec 2023 15:58:10 GMT, Raffaello Giulietti wrote: >> src/java.base/share/classes/java/io/SerializationMisdeclarationChecker.java >> line 185: >> >>> 183: commitEvent(PRIV_METH_NON_STATIC, >>> 184: m + " must be non-static to be effective"); >>> 185:

Re: RFR: 8275338: Add JFR events for notable serialization situations [v13]

2024-01-10 Thread Roger Riggs
On Wed, 10 Jan 2024 15:43:46 GMT, Raffaello Giulietti wrote: >> Adds serialization misdeclaration events to JFR. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Changes according to reviewers feedback. src/java.bas

Re: RFR: 8275338: Add JFR events for notable serialization situations [v12]

2024-01-10 Thread Roger Riggs
On Tue, 9 Jan 2024 10:41:31 GMT, Raffaello Giulietti wrote: >> src/java.base/share/classes/java/io/SerializationMisdeclarationChecker.java >> line 53: >> >>> 51: private static final Class[] READ_OBJECT_NO_DATA_PARAM_TYPES = >>> {}; >>> 52: private static final Class[] WRITE_REPLACE_P

Re: RFR: 8275338: Add JFR events for notable serialization situations [v12]

2024-01-10 Thread Daniel Fuchs
On Tue, 9 Jan 2024 10:46:27 GMT, Raffaello Giulietti wrote: >> src/java.base/share/classes/java/io/SerializationMisdeclarationChecker.java >> line 70: >> >>> 68: privilegedCheckAccessibleMethod(cl, WRITE_REPLACE_NAME, >>> 69: WRITE_REPLACE_PARAM_TYPES, Object.cl

Re: RFR: 8275338: Add JFR events for notable serialization situations [v13]

2024-01-10 Thread Raffaello Giulietti
> Adds serialization misdeclaration events to JFR. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: Changes according to reviewers feedback. - Changes: - all: https://git.openjdk.org/jdk/pull/17129/files - new:

Re: RFR: 8275338: Add JFR events for notable serialization situations [v12]

2024-01-10 Thread Raffaello Giulietti
On Tue, 9 Jan 2024 18:31:49 GMT, Daniel Fuchs wrote: >> Yes, that's perhaps clearer, will do. > > Typically in other places in the JDK we use `priviledgedXxx` for naming > methods that are simple wrappers that call `xxx` from within a > `doPrivileged`. The method is called privileged because it

Re: RFR: 8275338: Add JFR events for notable serialization situations [v12]

2024-01-09 Thread Daniel Fuchs
On Tue, 9 Jan 2024 10:42:58 GMT, Raffaello Giulietti wrote: >> src/java.base/share/classes/java/io/SerializationMisdeclarationChecker.java >> line 87: >> >>> 85: } >>> 86: if (cl.isEnum()) { >>> 87: commitEvent(cl, SUID_NAME + " in an enum class is not >>> effectiv

Re: RFR: 8275338: Add JFR events for notable serialization situations [v12]

2024-01-09 Thread Raffaello Giulietti
On Mon, 8 Jan 2024 18:38:52 GMT, Roger Riggs wrote: >> Raffaello Giulietti has updated the pull request with a new target base due >> to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains 15 >> additional comm

Re: RFR: 8275338: Add JFR events for notable serialization situations [v12]

2024-01-09 Thread Raffaello Giulietti
On Mon, 8 Jan 2024 18:15:36 GMT, Roger Riggs wrote: >> Raffaello Giulietti has updated the pull request with a new target base due >> to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains 15 >> additional comm

Re: RFR: 8275338: Add JFR events for notable serialization situations [v12]

2024-01-08 Thread Roger Riggs
On Mon, 8 Jan 2024 13:48:06 GMT, Raffaello Giulietti wrote: >> Adds serialization misdeclaration events to JFR. > > Raffaello Giulietti has updated the pull request with a new target base due > to a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the me

Re: RFR: 8275338: Add JFR events for notable serialization situations [v12]

2024-01-08 Thread Raffaello Giulietti
> Adds serialization misdeclaration events to JFR. Raffaello Giulietti has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 15 additional commits since the

Re: RFR: 8275338: Add JFR events for notable serialization situations [v11]

2023-12-21 Thread Raffaello Giulietti
> Adds serialization misdeclaration events to JFR. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: Simplified event messages. Remove ckecker allocation. - Changes: - all: https://git.openjdk.org/jdk/pull/17129

Re: RFR: 8275338: Add JFR events for notable serialization situations [v10]

2023-12-21 Thread Raffaello Giulietti
On Thu, 21 Dec 2023 21:24:43 GMT, Roger Riggs wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Corrected @Label of event and of field. > > src/java.base/share/classes/java/io/ObjectStreamClass.java line 466:

Re: RFR: 8275338: Add JFR events for notable serialization situations [v10]

2023-12-21 Thread Roger Riggs
On Thu, 21 Dec 2023 09:53:10 GMT, Raffaello Giulietti wrote: >> Adds serialization misdeclaration events to JFR. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Corrected @Label of event and of field. src/java.base

Re: RFR: 8275338: Add JFR events for notable serialization situations [v10]

2023-12-21 Thread Raffaello Giulietti
> Adds serialization misdeclaration events to JFR. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: Corrected @Label of event and of field. - Changes: - all: https://git.openjdk.org/jdk/pull/17129/files - new:

Re: RFR: 8275338: Add JFR events for notable serialization situations [v9]

2023-12-21 Thread Erik Gahlin
On Thu, 21 Dec 2023 09:36:06 GMT, Raffaello Giulietti wrote: >> Adds serialization misdeclaration events to JFR. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Removed @module from test. src/jdk.jfr/share/classes/

Re: RFR: 8275338: Add JFR events for notable serialization situations [v9]

2023-12-21 Thread Raffaello Giulietti
> Adds serialization misdeclaration events to JFR. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: Removed @module from test. - Changes: - all: https://git.openjdk.org/jdk/pull/17129/files - new: https://git.o

Re: RFR: 8275338: Add JFR events for notable serialization situations [v8]

2023-12-20 Thread Raffaello Giulietti
> Adds serialization misdeclaration events to JFR. Raffaello Giulietti has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the

Re: RFR: 8275338: Add JFR events for notable serialization situations [v7]

2023-12-20 Thread Raffaello Giulietti
> Adds serialization misdeclaration events to JFR. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: Minor changes. - Changes: - all: https://git.openjdk.org/jdk/pull/17129/files - new: https://git.openjdk.org/j

Re: RFR: 8275338: Add JFR events for notable serialization situations [v6]

2023-12-20 Thread Raffaello Giulietti
> Adds serialization misdeclaration events to JFR. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: Removed event kind. serialVersionUID must have type long. Test now base on keyword search in event message. Commented test

Re: RFR: 8275338: Add JFR events for notable serialization situations [v5]

2023-12-20 Thread Roger Riggs
On Wed, 20 Dec 2023 14:28:39 GMT, Roger Riggs wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Changes according to reviewer's comments. > > It would also be useful/interesting to include a test that checks e

Re: RFR: 8275338: Add JFR events for notable serialization situations [v3]

2023-12-20 Thread Raffaello Giulietti
On Wed, 20 Dec 2023 14:17:19 GMT, Roger Riggs wrote: >> Same remark here about finality as >> https://github.com/openjdk/jdk/pull/17129#discussion_r1432400888. public >> statics should be final. > > I'd also remove the error codes, the string messages will be pretty stable > and the extra surf

Re: RFR: 8275338: Add JFR events for notable serialization situations [v5]

2023-12-20 Thread Roger Riggs
On Wed, 20 Dec 2023 15:01:02 GMT, Raffaello Giulietti wrote: >> src/java.base/share/classes/java/io/SerializationMisdeclarationChecker.java >> line 113: >> >>> 111: if (longFromStatic(f) == null) { >>> 112: commitEvent(SUID_CONVERTIBLE_TO_LONG, >>> 113:

Re: RFR: 8275338: Add JFR events for notable serialization situations [v5]

2023-12-20 Thread Raffaello Giulietti
On Wed, 20 Dec 2023 14:28:39 GMT, Roger Riggs wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Changes according to reviewer's comments. > > It would also be useful/interesting to include a test that checks e

Re: RFR: 8275338: Add JFR events for notable serialization situations [v5]

2023-12-20 Thread Roger Riggs
On Tue, 19 Dec 2023 16:45:04 GMT, Raffaello Giulietti wrote: >> Adds serialization misdeclaration events to JFR. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Changes according to reviewer's comments. It would al

Re: RFR: 8275338: Add JFR events for notable serialization situations [v5]

2023-12-20 Thread Roger Riggs
On Tue, 19 Dec 2023 16:45:04 GMT, Raffaello Giulietti wrote: >> Adds serialization misdeclaration events to JFR. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Changes according to reviewer's comments. src/java.ba

Re: RFR: 8275338: Add JFR events for notable serialization situations [v3]

2023-12-20 Thread Roger Riggs
On Wed, 20 Dec 2023 08:29:19 GMT, Daniel Fuchs wrote: >> You could define them with an Enum but use the ordinal as the value for JFR. > > Same remark here about finality as > https://github.com/openjdk/jdk/pull/17129#discussion_r1432400888. public > statics should be final. I'd also remove the

Re: RFR: 8275338: Add JFR events for notable serialization situations [v4]

2023-12-20 Thread Raffaello Giulietti
On Tue, 19 Dec 2023 19:19:35 GMT, Roger Riggs wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Better name for a label, corrected name of removed field. > > src/java.base/share/classes/java/io/SerializationMi

Re: RFR: 8275338: Add JFR events for notable serialization situations [v3]

2023-12-20 Thread Daniel Fuchs
On Tue, 19 Dec 2023 19:39:22 GMT, Roger Riggs wrote: >> What about fixed `String`s rather than `int`s for the kind of error? >> Something like `"SUID_INEFFECTIVE_ON_ENUM"`, and so on? >> It would be nice to be able to use enums, but AFAIK that's not supported in >> JFR. > > You could define them

Re: RFR: 8275338: Add JFR events for notable serialization situations [v4]

2023-12-20 Thread Daniel Fuchs
On Tue, 19 Dec 2023 16:00:09 GMT, Raffaello Giulietti wrote: >> src/java.base/share/classes/jdk/internal/event/SerializationMisdeclarationEvent.java >> line 94: >> >>> 92: >>> 93: /* >>> 94: * These constants are not final on purpose. >> >> Just curious - what's the purpose? I don't

Re: RFR: 8275338: Add JFR events for notable serialization situations [v4]

2023-12-19 Thread Roger Riggs
On Tue, 19 Dec 2023 12:21:05 GMT, Raffaello Giulietti wrote: >> Adds serialization misdeclaration events to JFR. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Better name for a label, corrected name of removed fie

Re: RFR: 8275338: Add JFR events for notable serialization situations [v3]

2023-12-19 Thread Roger Riggs
On Tue, 19 Dec 2023 17:41:57 GMT, Raffaello Giulietti wrote: >> Users (not OpenJDK developers) don't know what the error code means. I think >> it's better to not have them. This is how other events work. If you want to >> guard against changes, I would export the package to the test. > > What

Re: RFR: 8275338: Add JFR events for notable serialization situations [v5]

2023-12-19 Thread Erik Gahlin
On Tue, 19 Dec 2023 17:37:50 GMT, Raffaello Giulietti wrote: >> src/java.base/share/classes/java/io/SerializationMisdeclarationChecker.java >> line 39: >> >>> 37: import static java.lang.reflect.Modifier.*; >>> 38: >>> 39: final class SerializationMisdeclarationChecker { >> >> Is there a rea

Re: RFR: 8275338: Add JFR events for notable serialization situations [v5]

2023-12-19 Thread Erik Gahlin
On Tue, 19 Dec 2023 16:45:04 GMT, Raffaello Giulietti wrote: >> Adds serialization misdeclaration events to JFR. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Changes according to reviewer's comments. > You mean,

Re: RFR: 8275338: Add JFR events for notable serialization situations [v5]

2023-12-19 Thread Raffaello Giulietti
On Tue, 19 Dec 2023 16:45:04 GMT, Raffaello Giulietti wrote: >> Adds serialization misdeclaration events to JFR. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Changes according to reviewer's comments. You mean, i

Re: RFR: 8275338: Add JFR events for notable serialization situations [v3]

2023-12-19 Thread Raffaello Giulietti
On Tue, 19 Dec 2023 17:13:58 GMT, Erik Gahlin wrote: >> The intent is that they are stable and for programmatic usage, whereas the >> message is more for human consumption. The codes are used in the test, for >> example, and are declared as public static in the event classes. >> >> Alternative

Re: RFR: 8275338: Add JFR events for notable serialization situations [v5]

2023-12-19 Thread Raffaello Giulietti
On Tue, 19 Dec 2023 17:15:40 GMT, Erik Gahlin wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Changes according to reviewer's comments. > > src/java.base/share/classes/java/io/SerializationMisdeclarationChec

Re: RFR: 8275338: Add JFR events for notable serialization situations [v4]

2023-12-19 Thread Erik Gahlin
On Tue, 19 Dec 2023 16:28:03 GMT, Raffaello Giulietti wrote: > However, the cache can be emptied under high memory pressure, so the > `ObjectStreamClass` instance might be recreated later, thus re-invoking the > serialization checker once again. I think it would be good to state in the descri

Re: RFR: 8275338: Add JFR events for notable serialization situations [v4]

2023-12-19 Thread Erik Gahlin
On Tue, 19 Dec 2023 16:00:59 GMT, Raffaello Giulietti wrote: >> test/jdk/jdk/jfr/event/io/TestSerializationMisdeclarationEvent.java line 50: >> >>> 48: * @requires vm.hasJFR >>> 49: * @library /test/lib >>> 50: * @run junit/othervm >>> jdk.jfr.event.io.TestSerializationMisdeclarationEvent >

Re: RFR: 8275338: Add JFR events for notable serialization situations [v5]

2023-12-19 Thread Erik Gahlin
On Tue, 19 Dec 2023 16:45:04 GMT, Raffaello Giulietti wrote: >> Adds serialization misdeclaration events to JFR. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Changes according to reviewer's comments. src/java.ba

Re: RFR: 8275338: Add JFR events for notable serialization situations [v3]

2023-12-19 Thread Erik Gahlin
On Tue, 19 Dec 2023 12:17:38 GMT, Raffaello Giulietti wrote: >> src/jdk.jfr/share/classes/jdk/jfr/events/SerializationMisdeclarationEvent.java >> line 48: >> >>> 46: >>> 47: @Label("Kind") >>> 48: public int kind; >> >> What is the use case for error codes? Are they public or an impl

Re: RFR: 8275338: Add JFR events for notable serialization situations [v5]

2023-12-19 Thread Raffaello Giulietti
> Adds serialization misdeclaration events to JFR. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: Changes according to reviewer's comments. - Changes: - all: https://git.openjdk.org/jdk/pull/17129/files - new

Re: RFR: 8275338: Add JFR events for notable serialization situations [v4]

2023-12-19 Thread Raffaello Giulietti
On Tue, 19 Dec 2023 15:56:39 GMT, Raffaello Giulietti wrote: > > Is it per class for each classloader that loads it? Or is it per class per > > JVM? It's more out of curiosity than anything else because I don't think it > > makes a big difference (I don't expect too many classloaders that woul

Re: RFR: 8275338: Add JFR events for notable serialization situations [v4]

2023-12-19 Thread Raffaello Giulietti
On Tue, 19 Dec 2023 14:39:47 GMT, Jaikiran Pai wrote: > Is it per class for each classloader that loads it? Or is it per class per > JVM? It's more out of curiosity than anything else because I don't think it > makes a big difference (I don't expect too many classloaders that would lead > to t

Re: RFR: 8275338: Add JFR events for notable serialization situations [v4]

2023-12-19 Thread Jaikiran Pai
On Tue, 19 Dec 2023 12:21:05 GMT, Raffaello Giulietti wrote: >> Adds serialization misdeclaration events to JFR. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Better name for a label, corrected name of removed fie

Re: RFR: 8275338: Add JFR events for notable serialization situations [v4]

2023-12-19 Thread Jaikiran Pai
On Tue, 19 Dec 2023 12:21:05 GMT, Raffaello Giulietti wrote: >> Adds serialization misdeclaration events to JFR. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Better name for a label, corrected name of removed fie

Re: RFR: 8275338: Add JFR events for notable serialization situations [v4]

2023-12-19 Thread Jaikiran Pai
On Tue, 19 Dec 2023 12:21:05 GMT, Raffaello Giulietti wrote: >> Adds serialization misdeclaration events to JFR. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Better name for a label, corrected name of removed fie

Re: RFR: 8275338: Add JFR events for notable serialization situations [v4]

2023-12-19 Thread Jaikiran Pai
On Tue, 19 Dec 2023 12:21:05 GMT, Raffaello Giulietti wrote: >> Adds serialization misdeclaration events to JFR. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Better name for a label, corrected name of removed fie

Re: RFR: 8275338: Add JFR events for notable serialization situations [v4]

2023-12-19 Thread Jaikiran Pai
On Tue, 19 Dec 2023 12:21:05 GMT, Raffaello Giulietti wrote: >> Adds serialization misdeclaration events to JFR. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Better name for a label, corrected name of removed fie

Re: RFR: 8275338: Add JFR events for notable serialization situations [v4]

2023-12-19 Thread Jaikiran Pai
On Tue, 19 Dec 2023 12:21:05 GMT, Raffaello Giulietti wrote: >> Adds serialization misdeclaration events to JFR. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Better name for a label, corrected name of removed fie

Re: RFR: 8275338: Add JFR events for notable serialization situations [v4]

2023-12-19 Thread Jaikiran Pai
On Tue, 19 Dec 2023 12:21:05 GMT, Raffaello Giulietti wrote: >> Adds serialization misdeclaration events to JFR. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Better name for a label, corrected name of removed fie

Re: RFR: 8275338: Add JFR events for notable serialization situations [v4]

2023-12-19 Thread Jaikiran Pai
On Tue, 19 Dec 2023 12:21:05 GMT, Raffaello Giulietti wrote: >> Adds serialization misdeclaration events to JFR. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Better name for a label, corrected name of removed fie

Re: RFR: 8275338: Add JFR events for notable serialization situations [v3]

2023-12-19 Thread Raffaello Giulietti
On Tue, 19 Dec 2023 10:43:57 GMT, Erik Gahlin wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Event enabled on profile.jfc but disabled on default.jfc. > > src/jdk.jfr/share/classes/jdk/jfr/events/Serializat

Re: RFR: 8275338: Add JFR events for notable serialization situations [v4]

2023-12-19 Thread Raffaello Giulietti
> Adds serialization misdeclaration events to JFR. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: Better name for a label, corrected name of removed field. - Changes: - all: https://git.openjdk.org/jdk/pull/171

Re: RFR: 8275338: Add JFR events for notable serialization situations [v3]

2023-12-19 Thread Erik Gahlin
On Mon, 18 Dec 2023 17:49:04 GMT, Raffaello Giulietti wrote: >> Adds serialization misdeclaration events to JFR. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Event enabled on profile.jfc but disabled on default.j

Re: RFR: 8275338: Add JFR events for notable serialization situations [v2]

2023-12-18 Thread Raffaello Giulietti
On Sat, 16 Dec 2023 01:27:17 GMT, Erik Gahlin wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Restrict accessibility of nested classes. > > It seems correct to have the event disabled in both configurations.

Re: RFR: 8275338: Add JFR events for notable serialization situations [v3]

2023-12-18 Thread Raffaello Giulietti
> Adds serialization misdeclaration events to JFR. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: Event enabled on profile.jfc but disabled on default.jfc. - Changes: - all: https://git.openjdk.org/jdk/pull/171

Re: RFR: 8275338: Add JFR events for notable serialization situations [v2]

2023-12-18 Thread Erik Gahlin
On Sat, 16 Dec 2023 01:27:17 GMT, Erik Gahlin wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Restrict accessibility of nested classes. > > It seems correct to have the event disabled in both configurations.

Re: RFR: 8275338: Add JFR events for notable serialization situations [v2]

2023-12-15 Thread Erik Gahlin
On Fri, 15 Dec 2023 22:26:04 GMT, Raffaello Giulietti wrote: >> Adds serialization misdeclaration events to JFR. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Restrict accessibility of nested classes. It seems co

Re: RFR: 8275338: Add JFR events for notable serialization situations [v2]

2023-12-15 Thread Raffaello Giulietti
> Adds serialization misdeclaration events to JFR. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: Restrict accessibility of nested classes. - Changes: - all: https://git.openjdk.org/jdk/pull/17129/files - new

RFR: 8275338: Add JFR events for notable serialization situations

2023-12-15 Thread Raffaello Giulietti
Adds serialization misdeclaration events to JFR. - Commit messages: - Make use of EventNames. - Merge branch 'master' into 8275338 - 8275338: Add JFR events for notable serialization situations Changes: https://git.openjdk.org/jdk/pull/17129/files Webrev: https://webrevs.openjdk.

Re: RFR: 8275338: Add JFR events for notable serialization situations

2023-12-15 Thread Raffaello Giulietti
On Fri, 15 Dec 2023 17:34:53 GMT, Raffaello Giulietti wrote: > Adds serialization misdeclaration events to JFR. A serialization misdeclaration on one of the following fields or methods means that they are not declared according to the Java Object Serialization Specification (JOSS) or in the J