On Wed, 31 Jan 2024 20:47:20 GMT, Ben Perez wrote:
>> Refactored PKCS9Attribute to use a hash map instead of multiple arrays. The
>> key for the hash map is an `ObjectIdentifier` and the values are a record
>> `AttributeInfo` that stores the information previously contained in the
>> arrays `P
> Refactored PKCS9Attribute to use a hash map instead of multiple arrays. The
> key for the hash map is an `ObjectIdentifier` and the values are a record
> `AttributeInfo` that stores the information previously contained in the
> arrays `PKCS9_VALUE_TAGS`, `VALUE_CLASSES`, and `SINGLE_VALUED`.
On Wed, 31 Jan 2024 18:18:30 GMT, Ben Perez wrote:
>> Refactored PKCS9Attribute to use a hash map instead of multiple arrays. The
>> key for the hash map is an `ObjectIdentifier` and the values are a record
>> `AttributeInfo` that stores the information previously contained in the
>> arrays `P
> Refactored PKCS9Attribute to use a hash map instead of multiple arrays. The
> key for the hash map is an `ObjectIdentifier` and the values are a record
> `AttributeInfo` that stores the information previously contained in the
> arrays `PKCS9_VALUE_TAGS`, `VALUE_CLASSES`, and `SINGLE_VALUED`.
> Refactored PKCS9Attribute to use a hash map instead of multiple arrays. The
> key for the hash map is an `ObjectIdentifier` and the values are a record
> `AttributeInfo` that stores the information previously contained in the
> arrays `PKCS9_VALUE_TAGS`, `VALUE_CLASSES`, and `SINGLE_VALUED`.
On Fri, 12 Jan 2024 00:17:32 GMT, Ben Perez wrote:
>> Refactored PKCS9Attribute to use a hash map instead of multiple arrays. The
>> key for the hash map is an `ObjectIdentifier` and the values are a record
>> `AttributeInfo` that stores the information previously contained in the
>> arrays `P
> Refactored PKCS9Attribute to use a hash map instead of multiple arrays. The
> key for the hash map is an `ObjectIdentifier` and the values are a record
> `AttributeInfo` that stores the information previously contained in the
> arrays `PKCS9_VALUE_TAGS`, `VALUE_CLASSES`, and `SINGLE_VALUED`.
On Thu, 11 Jan 2024 23:42:31 GMT, Ben Perez wrote:
>> Refactored PKCS9Attribute to use a hash map instead of multiple arrays. The
>> key for the hash map is an `ObjectIdentifier` and the values are a record
>> `AttributeInfo` that stores the information previously contained in the
>> arrays `P
> Refactored PKCS9Attribute to use a hash map instead of multiple arrays. The
> key for the hash map is an `ObjectIdentifier` and the values are a record
> `AttributeInfo` that stores the information previously contained in the
> arrays `PKCS9_VALUE_TAGS`, `VALUE_CLASSES`, and `SINGLE_VALUED`.
> Refactored PKCS9Attribute to use a hash map instead of multiple arrays. The
> key for the hash map is an `ObjectIdentifier` and the values are a record
> `AttributeInfo` that stores the information previously contained in the
> arrays `PKCS9_VALUE_TAGS`, `VALUE_CLASSES`, and `SINGLE_VALUED`.
On Wed, 10 Jan 2024 02:53:15 GMT, Valerie Peng wrote:
>> src/java.base/share/classes/sun/security/pkcs/PKCS9Attribute.java line 321:
>>
>>> 319:
>>> 320: this.oid = oid;
>>> 321: info = oidMap.get(oid);
>>
>> What if `info` is `null` (there is no entry for the specified OID)? T
On Tue, 2 Jan 2024 21:54:19 GMT, Weijun Wang wrote:
>> Do you think we can remove `PKCS9Attributes.getAttributes()` entirely or
>> should we just modify it to not use `PKCS9_OIDS` anymore?
>
> I think we can remove both. There is no need to keep a useless method as long
> as it's not an exporte
On Wed, 3 Jan 2024 20:39:57 GMT, Ben Perez wrote:
>> Refactored PKCS9Attribute to use a hash map instead of multiple arrays. The
>> key for the hash map is an `ObjectIdentifier` and the values are a record
>> `AttributeInfo` that stores the information previously contained in the
>> arrays `PK
On Thu, 4 Jan 2024 21:04:12 GMT, Sean Mullan wrote:
>> Ben Perez has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Minor fixes to make the code more readable, inlined init(), removed
>> PKCS9Attributes.getAttributes()
>
> src/java.base/sh
On Wed, 3 Jan 2024 20:39:57 GMT, Ben Perez wrote:
>> Refactored PKCS9Attribute to use a hash map instead of multiple arrays. The
>> key for the hash map is an `ObjectIdentifier` and the values are a record
>> `AttributeInfo` that stores the information previously contained in the
>> arrays `PK
On Wed, 3 Jan 2024 20:39:57 GMT, Ben Perez wrote:
>> Refactored PKCS9Attribute to use a hash map instead of multiple arrays. The
>> key for the hash map is an `ObjectIdentifier` and the values are a record
>> `AttributeInfo` that stores the information previously contained in the
>> arrays `PK
On Thu, 21 Dec 2023 16:46:54 GMT, Weijun Wang wrote:
>> Ben Perez has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Minor fixes to make the code more readable, inlined init(), removed
>> PKCS9Attributes.getAttributes()
>
> src/java.base/s
On Thu, 4 Jan 2024 20:44:01 GMT, Sean Mullan wrote:
>> Ben Perez has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Minor fixes to make the code more readable, inlined init(), removed
>> PKCS9Attributes.getAttributes()
>
> src/java.base/sh
On Wed, 3 Jan 2024 20:39:57 GMT, Ben Perez wrote:
>> Refactored PKCS9Attribute to use a hash map instead of multiple arrays. The
>> key for the hash map is an `ObjectIdentifier` and the values are a record
>> `AttributeInfo` that stores the information previously contained in the
>> arrays `PK
On Wed, 3 Jan 2024 20:39:57 GMT, Ben Perez wrote:
>> Refactored PKCS9Attribute to use a hash map instead of multiple arrays. The
>> key for the hash map is an `ObjectIdentifier` and the values are a record
>> `AttributeInfo` that stores the information previously contained in the
>> arrays `PK
On Wed, 3 Jan 2024 20:39:57 GMT, Ben Perez wrote:
>> Refactored PKCS9Attribute to use a hash map instead of multiple arrays. The
>> key for the hash map is an `ObjectIdentifier` and the values are a record
>> `AttributeInfo` that stores the information previously contained in the
>> arrays `PK
> Refactored PKCS9Attribute to use a hash map instead of multiple arrays. The
> key for the hash map is an `ObjectIdentifier` and the values are a record
> `AttributeInfo` that stores the information previously contained in the
> arrays `PKCS9_VALUE_TAGS`, `VALUE_CLASSES`, and `SINGLE_VALUED`.
On Wed, 3 Jan 2024 18:43:41 GMT, Ben Perez wrote:
>> src/java.base/share/classes/sun/security/pkcs/PKCS9Attribute.java line 344:
>>
>>> 342: info = oidMap.get(oid);
>>> 343: Class clazz = (info == null) ? BYTE_ARRAY_CLASS :
>>> info.valueClass();
>>> 344: if (clazz == nu
On Thu, 21 Dec 2023 17:01:08 GMT, Weijun Wang wrote:
>> Refactored PKCS9Attribute to use a hash map instead of multiple arrays. The
>> key for the hash map is an `ObjectIdentifier` and the values are a record
>> `AttributeInfo` that stores the information previously contained in the
>> arrays
On Tue, 2 Jan 2024 18:22:51 GMT, Ben Perez wrote:
>> src/java.base/share/classes/sun/security/pkcs/PKCS9Attribute.java line 186:
>>
>>> 184: /**
>>> 185: * Array of attribute OIDs defined in PKCS9, by number.
>>> 186: */
>>
>> I don't think `PKCS9_OIDS` is useful now. It's used in
On Thu, 21 Dec 2023 16:27:43 GMT, Weijun Wang wrote:
>> Refactored PKCS9Attribute to use a hash map instead of multiple arrays. The
>> key for the hash map is an `ObjectIdentifier` and the values are a record
>> `AttributeInfo` that stores the information previously contained in the
>> arrays
On Fri, 15 Dec 2023 20:34:21 GMT, Ben Perez wrote:
> Refactored PKCS9Attribute to use a hash map instead of multiple arrays. The
> key for the hash map is an `ObjectIdentifier` and the values are a record
> `AttributeInfo` that stores the information previously contained in the
> arrays `PKCS9
On Fri, 15 Dec 2023 20:34:21 GMT, Ben Perez wrote:
> Refactored PKCS9Attribute to use a hash map instead of multiple arrays. The
> key for the hash map is an `ObjectIdentifier` and the values are a record
> `AttributeInfo` that stores the information previously contained in the
> arrays `PKCS9
On Fri, 15 Dec 2023 20:34:21 GMT, Ben Perez wrote:
> Refactored PKCS9Attribute to use a hash map instead of multiple arrays. The
> key for the hash map is an `ObjectIdentifier` and the values are a record
> `AttributeInfo` that stores the information previously contained in the
> arrays `PKCS9
Refactored PKCS9Attribute to use a hash map instead of multiple arrays. The key
for the hash map is an `ObjectIdentifier` and the values are a record
`AttributeInfo` that stores the information previously contained in the arrays
`PKCS9_VALUE_TAGS`, `VALUE_CLASSES`, and `SINGLE_VALUED`.
It seem
30 matches
Mail list logo
