Re: RFR: 8230016: re-visit test sun/security/pkcs11/Serialize/SerializeProvider.java [v3]

2025-05-31 Thread Jaikiran Pai
On Wed, 30 Apr 2025 14:36:02 GMT, Mikhail Yankelevich wrote: >> Provider is now added to the Security before the test > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last revision: > > removed unneeded check I see that Rajan has appr

Re: RFR: 8230016: re-visit test sun/security/pkcs11/Serialize/SerializeProvider.java [v3]

2025-05-31 Thread Mikhail Yankelevich
On Sat, 31 May 2025 02:32:38 GMT, SendaoYan wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> removed unneeded check > > test/jdk/sun/security/pkcs11/Serialize/SerializeProvider.java line 60: > >> 58:

Re: RFR: 8230016: re-visit test sun/security/pkcs11/Serialize/SerializeProvider.java [v3]

2025-05-30 Thread SendaoYan
On Wed, 30 Apr 2025 14:36:02 GMT, Mikhail Yankelevich wrote: >> Provider is now added to the Security before the test > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last revision: > > removed unneeded check test/jdk/sun/security/pkc

Re: RFR: 8230016: re-visit test sun/security/pkcs11/Serialize/SerializeProvider.java [v3]

2025-05-30 Thread Rajan Halade
On Wed, 30 Apr 2025 14:36:02 GMT, Mikhail Yankelevich wrote: >> Provider is now added to the Security before the test > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last revision: > > removed unneeded check Marked as reviewed by rha

Re: RFR: 8230016: re-visit test sun/security/pkcs11/Serialize/SerializeProvider.java [v3]

2025-05-30 Thread duke
On Wed, 30 Apr 2025 14:36:02 GMT, Mikhail Yankelevich wrote: >> Provider is now added to the Security before the test > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last revision: > > removed unneeded check @myankelev Your change (

Re: RFR: 8230016: re-visit test sun/security/pkcs11/Serialize/SerializeProvider.java [v3]

2025-05-28 Thread Mikhail Yankelevich
On Wed, 30 Apr 2025 14:36:02 GMT, Mikhail Yankelevich wrote: >> Provider is now added to the Security before the test > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last revision: > > removed unneeded check Still needs a review ---

Re: RFR: 8230016: re-visit test sun/security/pkcs11/Serialize/SerializeProvider.java [v3]

2025-04-30 Thread Mikhail Yankelevich
> Provider is now added to the Security before the test Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: removed unneeded check - Changes: - all: https://git.openjdk.org/jdk/pull/24750/files - new: https://git.

Re: RFR: 8230016: re-visit test sun/security/pkcs11/Serialize/SerializeProvider.java [v3]

2025-04-30 Thread Mikhail Yankelevich
On Tue, 29 Apr 2025 19:02:38 GMT, Sean Mullan wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> removed unneeded check > > test/jdk/sun/security/pkcs11/Serialize/SerializeProvider.java line 51: > >> 49: >> 5

Re: RFR: 8230016: re-visit test sun/security/pkcs11/Serialize/SerializeProvider.java [v2]

2025-04-30 Thread Mikhail Yankelevich
> Provider is now added to the Security before the test Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: changed to check for null provider - Changes: - all: https://git.openjdk.org/jdk/pull/24750/files - new:

Re: RFR: 8230016: re-visit test sun/security/pkcs11/Serialize/SerializeProvider.java

2025-04-29 Thread Sean Mullan
On Fri, 18 Apr 2025 10:15:06 GMT, Mikhail Yankelevich wrote: > Provider is now added to the Security before the test test/jdk/sun/security/pkcs11/Serialize/SerializeProvider.java line 51: > 49: > 50: if (Security.getProvider(p.getName()) != p) { > 51: throw new SkippedExce

RFR: 8230016: re-visit test sun/security/pkcs11/Serialize/SerializeProvider.java

2025-04-18 Thread Mikhail Yankelevich
Provider is now added to the Security before the test - Commit messages: - JDK-8230016: re-visit test sun/security/pkcs11/Serialize/SerializeProvider.java Changes: https://git.openjdk.org/jdk/pull/24750/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24750&range=00 Issue