On Sat, 31 May 2025 02:32:38 GMT, SendaoYan <s...@openjdk.org> wrote:
>> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> removed unneeded check > > test/jdk/sun/security/pkcs11/Serialize/SerializeProvider.java line 60: > >> 58: ObjectInputStream oin = new ObjectInputStream(in); >> 59: >> 60: Provider p2 = (Provider) oin.readObject(); > > Hi, does the added whitespace really neeed. Functionally it doesn't make any difference afaik. However, it is generally advisable to have a white space after a cast. Here are 2 popular Java styles (Google and Sun) and one cr form openjdk itself: [https://www.oracle.com/docs/tech/java/codeconventions.pdf](https://www.oracle.com/docs/tech/java/codeconventions.pdf) paragraph 8.2 [https://cr.openjdk.org/~alundblad/styleguide/index-v6.html](https://cr.openjdk.org/~alundblad/styleguide/index-v6.html) paragraph Horizontal Whitespace [https://google.github.io/styleguide/javaguide.html](https://google.github.io/styleguide/javaguide.html) paragraph 4.6.2 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24750#discussion_r2117614490
