Re: RFR: 8356893: Use "stdin.encoding" for reading System.in with InputStreamReader/Scanner

2025-05-22 Thread Volkan Yazici
On Wed, 21 May 2025 21:37:07 GMT, Roger Riggs wrote: >> There are several locations in the JDK source where `System.in` and >> `FileDescriptor.in` is read with `InputStreamReader` and `Scanner` using the >> default charset. As recommended by the recently merged >> [JDK-8356420](https://bugs.op

Withdrawn: 8356893: Use "stdin.encoding" for reading System.in with InputStreamReader/Scanner

2025-05-22 Thread Volkan Yazici
On Wed, 21 May 2025 20:56:31 GMT, Volkan Yazici wrote: > There are several locations in the JDK source where `System.in` and > `FileDescriptor.in` is read with `InputStreamReader` and `Scanner` using the > default charset. As recommended by the recently merged > [JDK-83

RFR: 8356893: Use "stdin.encoding" for reading System.in with InputStreamReader/Scanner

2025-05-21 Thread Volkan Yazici
There are several locations in the JDK source where `System.in` and `FileDescriptor.in` is read with `InputStreamReader` and `Scanner` using the default charset. As recommended by the recently merged [JDK-8356420](https://bugs.openjdk.org/browse/JDK-8356420), this PR replaces the default charse

Integrated: 8353197: Document preconditions for JavaLangAccess methods

2025-05-15 Thread Volkan Yazici
On Thu, 1 May 2025 05:33:29 GMT, Volkan Yazici wrote: > Document preconditions on certain `JavaLangAccess` methods that use > operations either unsafe and/or without range checks. This pull request has now been integrated. Changeset: 8fcfddb2 Author:Volkan Yazici Committer: Chen

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v7]

2025-05-15 Thread Volkan Yazici
On Mon, 12 May 2025 19:42:15 GMT, Volkan Yazici wrote: >> Document preconditions on certain `JavaLangAccess` methods that use >> operations either unsafe and/or without range checks. > > Volkan Yazici has updated the pull request with a new target base due to a > m

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v7]

2025-05-13 Thread Volkan Yazici
On Tue, 13 May 2025 15:51:12 GMT, Alan Bateman wrote: >> Volkan Yazici has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contai

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v7]

2025-05-12 Thread Volkan Yazici
> Document preconditions on certain `JavaLangAccess` methods that use > operations either unsafe and/or without range checks. Volkan Yazici has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v5]

2025-05-12 Thread Volkan Yazici
On Mon, 12 May 2025 17:07:57 GMT, Roger Riggs wrote: >> Volkan Yazici has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Prefixed `JavaLangAccess::stringConcat1` with `unchecked` >> - Fix `HexDigits` co

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v6]

2025-05-12 Thread Volkan Yazici
> Document preconditions on certain `JavaLangAccess` methods that use > operations either unsafe and/or without range checks. Volkan Yazici has updated the pull request incrementally with one additional commit since the last revision: Apply suggestions from code review Co-autho

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v4]

2025-05-12 Thread Volkan Yazici
On Mon, 12 May 2025 08:52:00 GMT, Jaikiran Pai wrote: >> Volkan Yazici has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix copyright years > > src/java.base/share/classes/jdk/internal/access/JavaLangA

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v5]

2025-05-12 Thread Volkan Yazici
> Document preconditions on certain `JavaLangAccess` methods that use > operations either unsafe and/or without range checks. Volkan Yazici has updated the pull request incrementally with two additional commits since the last revision: - Prefixed `JavaLangAccess::stringConcat1

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v4]

2025-05-09 Thread Volkan Yazici
> Document preconditions on certain `JavaLangAccess` methods that use > operations either unsafe and/or without range checks. Volkan Yazici has updated the pull request incrementally with one additional commit since the last revision: Fix copyright years - Changes:

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v3]

2025-05-09 Thread Volkan Yazici
On Thu, 8 May 2025 14:51:48 GMT, Chen Liang wrote: >> Volkan Yazici has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Prefix touched methods with `unchecked` > > Let's re-approve after copyright fix

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v3]

2025-05-09 Thread Volkan Yazici
On Thu, 8 May 2025 14:46:29 GMT, Chen Liang wrote: >> Volkan Yazici has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Prefix touched methods with `unchecked` > > src/java.base/share/classes/java/io/DataIn

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v2]

2025-05-07 Thread Volkan Yazici
On Wed, 7 May 2025 07:52:37 GMT, Alan Bateman wrote: >> Volkan Yazici has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix typo in pre-existing JavaDoc > > src/java.base/share/classes/jdk/internal/acces

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v2]

2025-05-07 Thread Volkan Yazici
On Wed, 7 May 2025 13:22:11 GMT, Raffaello Giulietti wrote: >> src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java line 355: >> >>> 353: * UTF-16 representation. >>> 354: * >>> 355: * WARNING: This method does not perform any bound checks. >> >> Maybe not this P

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v3]

2025-05-07 Thread Volkan Yazici
> Document preconditions on certain `JavaLangAccess` methods that use > operations either unsafe and/or without range checks. Volkan Yazici has updated the pull request incrementally with one additional commit since the last revision: Prefix touched methods with `unc

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v2]

2025-05-07 Thread Volkan Yazici
On Wed, 7 May 2025 07:37:48 GMT, Alan Bateman wrote: >> Volkan Yazici has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix typo in pre-existing JavaDoc > > src/java.base/share/classes/jdk/internal/acces

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v2]

2025-05-07 Thread Volkan Yazici
On Fri, 2 May 2025 14:39:55 GMT, Roger Riggs wrote: >> Volkan Yazici has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix typo in pre-existing JavaDoc > > src/java.base/share/classes/jdk/internal/acces

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v2]

2025-05-07 Thread Volkan Yazici
On Thu, 1 May 2025 13:00:37 GMT, Chen Liang wrote: >> Volkan Yazici has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix typo in pre-existing JavaDoc > > src/java.base/share/classes/jdk/internal/acces

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v2]

2025-05-07 Thread Volkan Yazici
On Wed, 7 May 2025 07:26:56 GMT, Volkan Yazici wrote: >> Document preconditions on certain `JavaLangAccess` methods that use >> operations either unsafe and/or without range checks. > > Volkan Yazici has updated the pull request incrementally with one additional >

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v2]

2025-05-07 Thread Volkan Yazici
> Document preconditions on certain `JavaLangAccess` methods that use > operations either unsafe and/or without range checks. Volkan Yazici has updated the pull request incrementally with one additional commit since the last revision: Fix typo in pre-existing JavaDoc - C

RFR: 8353197: Document preconditions for JavaLangAccess methods

2025-04-30 Thread Volkan Yazici
Document preconditions on certain `JavaLangAccess` methods that use operations either unsafe and/or without range checks. - Commit messages: - Improve `JavaLangAccess` documentation Changes: https://git.openjdk.org/jdk/pull/24982/files Webrev: https://webrevs.openjdk.org/?repo=jd