On Wed, 20 Nov 2024 01:23:10 GMT, Artur Barashev wrote:
> SAP complains about SSLSocketNoServerHelloClientShutdown timing out in their
> test environment (concurrent test execution with high CPU load). This change
> addresses this issue in 2 ways:
> - Increase default timeout value
> - Allow ad
70)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit being backported was authored by Matthias Baesken on 7 Jun 2024
> and was reviewed by Lutz Schmidt and Sergey Bylokhov.
>
> Since this is a test update, it can be pushed under RDP1 ruling.
>
>
On Fri, 16 Feb 2024 08:52:19 GMT, Christoph Langer wrote:
>> The experimental SunJSSE FIPS compliant mode was removed in JDK13 with
>> [JDK-8217835](https://bugs.openjdk.org/browse/JDK-8217835).
>> It seems the removal of some comments had been missed at that time. This
>> could be irritating t
On Thu, 4 Jan 2024 15:21:39 GMT, Matthew Donovan wrote:
>> In this PR, I included logic to skip tests on Oracle Linux prior to version
>> 8. The NSS binaries we are using for testing use a newer version of GLIBC
>> than is included with OL 7.9.
>
> Matthew Donovan has updated the pull request
On Thu, 11 Jan 2024 15:08:28 GMT, Matthew Donovan wrote:
>> test/lib/jdk/test/lib/Platform.java line 354:
>>
>>> 352: public static boolean isOracleLinux7() {
>>> 353: if
>>> (System.getProperty("os.name").toLowerCase().contains("linux") &&
>>> 354:
>>> System.getPr
On Thu, 4 Jan 2024 15:21:39 GMT, Matthew Donovan wrote:
>> In this PR, I included logic to skip tests on Oracle Linux prior to version
>> 8. The NSS binaries we are using for testing use a newer version of GLIBC
>> than is included with OL 7.9.
>
> Matthew Donovan has updated the pull request
On Wed, 3 Jan 2024 11:41:20 GMT, Matthias Baesken wrote:
> In [JDK-8322772](https://bugs.openjdk.org/browse/JDK-8322772) one similar
> cleanup has been proposed before (and was done in the change). But there are
> a number of other places in the codebase where the import is done
On Wed, 3 Jan 2024 13:55:22 GMT, Matthias Baesken wrote:
>> In [JDK-8322772](https://bugs.openjdk.org/browse/JDK-8322772) one similar
>> cleanup has been proposed before (and was done in the change). But there are
>> a number of other places in the codebase where the import
On Wed, 3 Jan 2024 13:55:22 GMT, Matthias Baesken wrote:
>> In [JDK-8322772](https://bugs.openjdk.org/browse/JDK-8322772) one similar
>> cleanup has been proposed before (and was done in the change). But there are
>> a number of other places in the codebase where the import
;java.util.Arrays" is used so more
> cleanups can be done.
Matthias Baesken has updated the pull request incrementally with one additional
commit since the last revision:
Adjust Invokers.java too
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17241/files
- new: ht
;java.util.Arrays" is used so more
> cleanups can be done.
Matthias Baesken has updated the pull request incrementally with one additional
commit since the last revision:
adjust copyright date
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17241/files
- new: https:/
In [JDK-8322772](https://bugs.openjdk.org/browse/JDK-8322772) one similar
cleanup has been proposed before (and was done in the change). But there are a
number of other places in the codebase where the import is done and still the
unneeded fully qualified class name "java.util.Arrays" is used so
On Mon, 27 Nov 2023 14:47:29 GMT, Matthew Donovan wrote:
>> In this PR, I included logic to skip tests on Oracle Linux prior to version
>> 8. The NSS binaries we are using for testing use a newer version of GLIBC
>> than is included with OL 7.9.
>
> Matthew Donovan has updated the pull request
On Thu, 14 Dec 2023 19:08:20 GMT, Matthew Donovan wrote:
>> In this PR, I included logic to skip tests on Oracle Linux prior to version
>> 8. The NSS binaries we are using for testing use a newer version of GLIBC
>> than is included with OL 7.9.
>
> Matthew Donovan has updated the pull request
On Wed, 23 Aug 2023 15:18:03 GMT, Matthias Baesken wrote:
>> Currently there is a number of functionality that would be interesting to
>> have for shared lib load operations in the JDK C code.
>> Some examples :
>> Events::log_dll_message for hs-err file
On Tue, 17 Oct 2023 07:31:07 GMT, Varada M wrote:
> When the test sets the sun.security.jgss.native and
> sun.security.nativegss.debug as true, the test fails on AIX due to missing
> Kerberos GSS API dynamic library` libgssapi_krb5.so`
>
> JBS Issue : [JDK-8318240](https://bugs.openjdk.org/br
On Wed, 23 Aug 2023 15:18:03 GMT, Matthias Baesken wrote:
>> Currently there is a number of functionality that would be interesting to
>> have for shared lib load operations in the JDK C code.
>> Some examples :
>> Events::log_dll_message for hs-err file
On Tue, 26 Sep 2023 07:23:20 GMT, Matthias Baesken wrote:
> We sometimes run into the following error. This especially occurs when
> running with fastdebug binaries and on Linux ppc64le machines.
> Current timeout set in the test is 1 second.
>
> Server accepting: 315357614
On Tue, 26 Sep 2023 07:23:20 GMT, Matthias Baesken wrote:
> We sometimes run into the following error. This especially occurs when
> running with fastdebug binaries and on Linux ppc64le machines.
> Current timeout set in the test is 1 second.
>
> Server accepting: 315357614
We sometimes run into the following error. This especially occurs when running
with fastdebug binaries and on Linux ppc64le machines.
Current timeout set in the test is 1 second.
Server accepting: 315357614990101
Server accepted: 315359219006041
Client starting handshake: 315359228098300
java.net
On Fri, 15 Sep 2023 08:21:00 GMT, Matthias Baesken wrote:
> Currently sun/security/pkcs11/PKCS11Test.java needs adjustment on Linux
> ppc64le Ubuntu 22, it does not find the NSS libs because the new file system
> locations are not handled, unlike on Linux x86_64 .
This pull reques
On Fri, 15 Sep 2023 08:21:00 GMT, Matthias Baesken wrote:
> Currently sun/security/pkcs11/PKCS11Test.java needs adjustment on Linux
> ppc64le Ubuntu 22, it does not find the NSS libs because the new file system
> locations are not handled, unlike on Linux x86_64 .
Hi Christoph
Currently sun/security/pkcs11/PKCS11Test.java needs adjustment on Linux ppc64le
Ubuntu 22, it does not find the NSS libs because the new file system locations
are not handled, unlike on Linux x86_64 .
-
Commit messages:
- JDK-8316341
Changes: https://git.openjdk.org/jdk/pull/15759
On Mon, 4 Sep 2023 13:09:08 GMT, Matthias Baesken wrote:
> on some slow machines, sun/security/tools/jarsigner/Warning.java runs
> sometimes into timeouts (with fastdebug binaries).
> So the current timeout of the test should be increased.
This pull request has now been integrated.
On Mon, 4 Sep 2023 13:09:08 GMT, Matthias Baesken wrote:
> on some slow machines, sun/security/tools/jarsigner/Warning.java runs
> sometimes into timeouts (with fastdebug binaries).
> So the current timeout of the test should be increased.
Thanks for the reviews !
-
P
On Mon, 4 Sep 2023 13:09:08 GMT, Matthias Baesken wrote:
> on some slow machines, sun/security/tools/jarsigner/Warning.java runs
> sometimes into timeouts (with fastdebug binaries).
> So the current timeout of the test should be increased.
Hi Christoph, thanks for t
on some slow machines, sun/security/tools/jarsigner/Warning.java runs sometimes
into timeouts (with fastdebug binaries).
So the current timeout of the test should be increased.
-
Commit messages:
- JDK-8315644
Changes: https://git.openjdk.org/jdk/pull/15560/files
Webrev: https://w
On Mon, 28 Aug 2023 02:26:30 GMT, David Holmes wrote:
> Sorry but looking at the hotspot part of this I do not like the code in
> jvm.cpp at all - it is far too messy. I expected to see a simple interface to
> os::dlopen which then handles all the platform specific issues.
>
> I'm also somewha
On Wed, 23 Aug 2023 12:26:36 GMT, Martin Doerr wrote:
> Please check windows-aarch64 build error: unresolved external symbol
> dlopen_ext
Hi Martin, thanks ! I did a small adjustment, now the windows aarch64 build
works.
-
PR Comment: https://git.openjdk.org/jdk/pull/15264#issue
Cache on AIX ( see
> LoadedLibraries::reload() , see also
> https://bugs.openjdk.org/browse/JDK-8314152 ),
> this is currently not fully in sync with libs loaded form jdk c-libs and
> sometimes reports outdated information
>
> Offer an interface (e.g. jvm.cpp) to support thi
On Mon, 14 Aug 2023 07:48:00 GMT, Matthias Baesken wrote:
> Currently there is a number of functionality that would be interesting to
> have for shared lib load operations in the JDK C code.
> Some examples :
> Events::log_dll_message for hs-err files reporting
> JFR event Na
On Mon, 14 Aug 2023 07:48:00 GMT, Matthias Baesken wrote:
> Currently there is a number of functionality that would be interesting to
> have for shared lib load operations in the JDK C code.
> Some examples :
> Events::log_dll_message for hs-err files reporting
> JFR event Na
Currently there is a number of functionality that would be interesting to have
for shared lib load operations in the JDK C code.
Some examples :
Events::log_dll_message for hs-err files reporting
JFR event NativeLibraryLoad
There is the need to update the shared lib Cache on AIX ( see
LoadedLibra
On Thu, 3 Aug 2023 20:51:33 GMT, Valerie Peng wrote:
> This change addresses the scenario where a certificate is first stored as
> part of a certificate chain and then stored again as a certificate
> corresponding to a PrivateKey entry. Newer version of NSS errors out with
> CKR_GENERAL_ERROR
On Tue, 8 Aug 2023 23:03:02 GMT, Valerie Peng wrote:
> > Hi Valerie, we put the PR into our build/test queue to check if it solves
> > some errors we currently notice in CertChainRemoval.java .
>
> Sure, thanks! What is the errors that you observed? Are you running against
> NSS and which vers
On Thu, 3 Aug 2023 20:51:33 GMT, Valerie Peng wrote:
> This change addresses the scenario where a certificate is first stored as
> part of a certificate chain and then stored again as a certificate
> corresponding to a PrivateKey entry. Newer version of NSS errors out with
> CKR_GENERAL_ERROR
On Wed, 2 Aug 2023 06:42:29 GMT, Christoph Langer wrote:
> Hi all,
>
> This pull request contains a backport of
> [JDK-8309088](https://bugs.openjdk.org/browse/JDK-8309088), commit
> [4c2e54fb](https://github.com/openjdk/jdk/commit/4c2e54fb055bee0af5cd838fdd32a0f7902d51e3)
> from the [openjdk
On Fri, 28 Jul 2023 22:49:04 GMT, Hai-May Chao wrote:
>> JDK-8312489: Increase jdk.jar.maxSignatureFileSize default which is too low
>> for JARs such as WhiteSource/Mend unified agent jar
>
> Hai-May Chao has updated the pull request incrementally with one additional
> commit since the last rev
On Mon, 24 Jul 2023 07:50:44 GMT, Matthias Baesken wrote:
> sspi.cpp contains the gss_export_name function, where at the end some cleanup
> is done by calling delete. However this should be done more careful, because
> the function get_full_name which is called in gss_export_name mig
On Mon, 24 Jul 2023 11:30:29 GMT, Matthias Baesken wrote:
>> sspi.cpp contains the gss_export_name function, where at the end some
>> cleanup is done by calling delete. However this should be done more careful,
>> because the function get_full_name which is called in gss
On Mon, 24 Jul 2023 11:01:07 GMT, Daniel Jeliński wrote:
> `free`, `delete` and `delete[]` are all safe to call on a NULL pointer.
>
> I noticed that we are checking for NULL in other places in this file; could
> you remove these checks?
Hi, I found and adjusted a number of places where the po
in this case.
Matthias Baesken has updated the pull request incrementally with one additional
commit since the last revision:
remove unneeded NULL checks forfree and delete calls
-
Changes:
- all: https://git.openjdk.org/jdk/pull/14989/files
- new: https://git.openjdk.org/jdk/pull
sspi.cpp contains the gss_export_name function, where at the end some cleanup
is done by calling delete. However this should be done more careful, because
the function get_full_name which is called in gss_export_name might return
NULL, so we better avoid calling delete in this case.
---
On Fri, 30 Jun 2023 12:28:43 GMT, Matthias Baesken wrote:
> 8310549: avoid potential leaks in KeystoreImpl.m related to
> JNU_CHECK_EXCEPTION early returns
This pull request has now been integrated.
Changeset: 8d6ef6fd
Author:Matthias Baesken
URL:
https://git.openjdk.org
8310549: avoid potential leaks in KeystoreImpl.m related to JNU_CHECK_EXCEPTION
early returns
-
Commit messages:
- Backport 7da3f1999fc5d1b9162443d97dfae7fe7b04dfc5
Changes: https://git.openjdk.org/jdk21/pull/86/files
Webrev: https://webrevs.openjdk.org/?repo=jdk21&pr=86&range=00
On Fri, 16 Jun 2023 18:19:45 GMT, Jamil Nimeh wrote:
> This PR is for tests that were modified/added in JDK-8179502. The timeout
> windows for those tests were a little too short on some test systems,
> especially when the system is under heavy load. After a few iterations
> trying out vario
On Wed, 21 Jun 2023 14:10:20 GMT, Matthias Baesken wrote:
> In src/java.base/macosx/native/libosxsecurity/KeystoreImpl.m there are a few
> JNU_CHECK_EXCEPTION macro usages that could potentially cause leaks.
This pull request has now been integrated.
Changeset: 7da3f199
Author:Ma
On Wed, 21 Jun 2023 14:10:20 GMT, Matthias Baesken wrote:
> In src/java.base/macosx/native/libosxsecurity/KeystoreImpl.m there are a few
> JNU_CHECK_EXCEPTION macro usages that could potentially cause leaks.
Hi Weijun, thanks for the review !
-
PR Comment: https://git.openj
In src/java.base/macosx/native/libosxsecurity/KeystoreImpl.m there are a few
JNU_CHECK_EXCEPTION macro usages that could potentially cause leaks.
-
Commit messages:
- JDK-8310549
Changes: https://git.openjdk.org/jdk/pull/14590/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr
On Tue, 6 Jun 2023 07:15:08 GMT, Alan Bateman wrote:
>> There are cases in the sctp coding where a function
>> sctpHandleSocketErrorWithMessage would be beneficial (similar to existing
>> handleSocketErrorWithMessage) to provide more detail what failed.
>>
>> Additionally sctpHandleSocketError
On Tue, 6 Jun 2023 08:51:33 GMT, Daniel Fuchs wrote:
> FWIW the changes look good to me.
Thanks for looking into it.
-
PR Comment: https://git.openjdk.org/jdk/pull/14280#issuecomment-1578414732
On Tue, 6 Jun 2023 07:16:13 GMT, Alan Bateman wrote:
> I see this was integrated without a reviewer in the area but I think the
> changes are okay.
Hi Alan, I think Christoph is very competent in the area.
But should I look into the census next time for some special reviewer category
(and whic
On Fri, 2 Jun 2023 08:03:01 GMT, Matthias Baesken wrote:
> There are cases in the sctp coding where a function
> sctpHandleSocketErrorWithMessage would be beneficial (similar to existing
> handleSocketErrorWithMessage) to provide more detail what failed.
>
&g
On Fri, 2 Jun 2023 08:03:01 GMT, Matthias Baesken wrote:
> There are cases in the sctp coding where a function
> sctpHandleSocketErrorWithMessage would be beneficial (similar to existing
> handleSocketErrorWithMessage) to provide more detail what failed.
>
&g
There are cases in the sctp coding where a function
sctpHandleSocketErrorWithMessage would be beneficial (similar to existing
handleSocketErrorWithMessage) to provide more detail what failed.
Additionally sctpHandleSocketErrorWithMessage was a bit modified (added errno
handling for ENOTCONN fro
On Thu, 25 May 2023 14:31:04 GMT, Matthias Baesken wrote:
> There exists already some logging in krb5/Config.java (enabled by
> -Dsun.security.krb5.debug=true), this could be enhanced for easier analysis
> of problems. Additionally some exception(s) might be slightly adjusted.
On Fri, 26 May 2023 08:04:58 GMT, Matthias Baesken wrote:
>> There exists already some logging in krb5/Config.java (enabled by
>> -Dsun.security.krb5.debug=true), this could be enhanced for easier analysis
>> of problems. Additionally some exception(s) might be slightly adju
> There exists already some logging in krb5/Config.java (enabled by
> -Dsun.security.krb5.debug=true), this could be enhanced for easier analysis
> of problems. Additionally some exception(s) might be slightly adjusted.
Matthias Baesken has updated the pull request incrementally
There exists already some logging in krb5/Config.java (enabled by
-Dsun.security.krb5.debug=true), this could be enhanced for easier analysis of
problems. Additionally some exception(s) might be slightly adjusted.
-
Commit messages:
- JDK-8308872
Changes: https://git.openjdk.org/j
On Wed, 17 May 2023 08:06:56 GMT, Christoph Langer wrote:
>> With this PR we try to be better in loading certificates from the MacOS
>> Keychain into a JDK Trust store.
>>
>> The current implementation after JDK-8278449 would only load/trust
>> certificates from an identity (with private key a
On Wed, 17 May 2023 08:06:56 GMT, Christoph Langer wrote:
>> With this PR we try to be better in loading certificates from the MacOS
>> Keychain into a JDK Trust store.
>>
>> The current implementation after JDK-8278449 would only load/trust
>> certificates from an identity (with private key a
On Wed, 17 May 2023 07:14:06 GMT, Christoph Langer wrote:
> > Hi Christoph, I do not see any reference to kSecTrustSettingsDomainSystem
> > in your coding. Handling at least kSecTrustSettingsDomainUser and
> > kSecTrustSettingsDomainAdmin is good but I am not sure about
> > kSecTrustSettingsDo
On Tue, 16 May 2023 08:48:03 GMT, Matthias Baesken wrote:
> In the checksum-related check, we miss blanks in the error output of the
> calculated and expected checksum.
Hi Rajan and Sean, thanks for the reviews !
-
PR Comment: https://git.openjdk.org/jdk/pull/14003#issuec
On Tue, 16 May 2023 08:48:03 GMT, Matthias Baesken wrote:
> In the checksum-related check, we miss blanks in the error output of the
> calculated and expected checksum.
This pull request has now been integrated.
Changeset: 5a92aae1
Author:Matthias Baesken
URL:
On Thu, 11 May 2023 21:38:35 GMT, Christoph Langer wrote:
> With this PR we try to be better in loading certificates from the MacOS
> Keychain into a JDK Trust store.
>
> The current implementation after JDK-8278449 would only load/trust
> certificates from an identity (with private key availa
In the checksum-related check, we miss blanks in the error output of the
calculated and expected checksum.
-
Commit messages:
- JDK-8308156
Changes: https://git.openjdk.org/jdk/pull/14003/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14003&range=00
Issue: https://bugs.o
On Thu, 11 May 2023 21:38:35 GMT, Christoph Langer wrote:
> With this PR we try to be better in loading certificates from the MacOS
> Keychain into a JDK Trust store.
>
> The current implementation after JDK-8278449 would only load/trust
> certificates from an identity (with private key availa
On Thu, 2 Mar 2023 13:33:53 GMT, Matthias Baesken wrote:
> After 8278449, we seem to ignore in the call
>
> ` if (SecTrustSettingsCopyTrustSettings(certRef,
> kSecTrustSettingsDomainUser, &trustSettings) == errSecItemNotFound) `
>
> all trusted certs from admin and sy
On Thu, 2 Mar 2023 13:33:53 GMT, Matthias Baesken wrote:
> After 8278449, we seem to ignore in the call
>
> ` if (SecTrustSettingsCopyTrustSettings(certRef,
> kSecTrustSettingsDomainUser, &trustSettings) == errSecItemNotFound) `
>
> all trusted certs from admin and sy
On Tue, 7 Mar 2023 17:32:15 GMT, Weijun Wang wrote:
> I'll think about it more and discuss with my colleagues.
Hi Weijun, is there some news from your colleagues ?
-
PR: https://git.openjdk.org/jdk/pull/12829
The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.
--
On Tue, 7 Mar 2023 15:56:55 GMT, Matthias Ba
> Similar to what had been done in
> [JDK-8303354](https://bugs.openjdk.org/browse/JDK-8303354) , we miss
> CFRelease on the variable identitySearch in early CHECK_NULL returns
> potentially done in the function addIdentitiesToKeystore.
Matthias Baesken has updated the
> Similar to what had been done in
> [JDK-8303354](https://bugs.openjdk.org/browse/JDK-8303354) , we miss
> CFRelease on the variable identitySearch in early CHECK_NULL returns
> potentially done in the function addIdentitiesToKeystore.
Matthias Baesken has updated the
Similar to what had been done in
[JDK-8303354](https://bugs.openjdk.org/browse/JDK-8303354) , we miss CFRelease
on the variable identitySearch in early CHECK_NULL returns potentially done in
the function addIdentitiesToKeystore.
-
Commit messages:
- JDK-8303576
Changes: https://g
On Thu, 2 Mar 2023 13:33:53 GMT, Matthias Baesken wrote:
> After 8278449, we seem to ignore in the call
>
> ` if (SecTrustSettingsCopyTrustSettings(certRef,
> kSecTrustSettingsDomainUser, &trustSettings) == errSecItemNotFound) `
>
> all trusted certs from admin and sy
On Thu, 2 Mar 2023 15:23:02 GMT, Weijun Wang wrote:
> dump-trust-setting
I have found some errors with dump-trust-settings like this one
https://github.com/wbond/package_control/issues/1017 but not sure if this is
related to what you saw on your test infrastructure.
-
PR: https:
On Thu, 2 Mar 2023 15:23:02 GMT, Weijun Wang wrote:
> I'd like to contribute a test.
Thanks for contributing the test. Any suggestion where to place the test ?
-
PR: https://git.openjdk.org/jdk/pull/12829
On Tue, 28 Feb 2023 15:17:19 GMT, Matthias Baesken wrote:
> We have a (potential) early return in addCertificatesToKeystore in
> KeystoreImpl.m . This is implemented by the CHECK_NULL macro. However this
> missed a CFRelease call.
This pull request has now been integrated.
On Thu, 2 Mar 2023 09:47:56 GMT, Matthias Baesken wrote:
>> We have a (potential) early return in addCertificatesToKeystore in
>> KeystoreImpl.m . This is implemented by the CHECK_NULL macro. However this
>> missed a CFRelease call.
>
> Matthias Baesken has
On Thu, 2 Mar 2023 13:54:05 GMT, Weijun Wang wrote:
> Thanks for the fix. I almost think we should invent a CHECK_NULL_GOTO_ERROUT
> macro, but your fix is also OK.
I think I discussed a while back some extended CHECK_NULL_ - macros (I think
it was for freeing before return) but it was not s
After 8278449, we seem to ignore in the call
` if (SecTrustSettingsCopyTrustSettings(certRef, kSecTrustSettingsDomainUser,
&trustSettings) == errSecItemNotFound) `
all trusted certs from admin and system domains, so a lot more certs are
ignored than necessary.
Probably we should take at least
> We have a (potential) early return in addCertificatesToKeystore in
> KeystoreImpl.m . This is implemented by the CHECK_NULL macro. However this
> missed a CFRelease call.
Matthias Baesken has updated the pull request incrementally with one additional
commit since the last revision:
On Wed, 1 Mar 2023 19:51:46 GMT, Weijun Wang wrote:
>> We have a (potential) early return in addCertificatesToKeystore in
>> KeystoreImpl.m . This is implemented by the CHECK_NULL macro. However this
>> missed a CFRelease call.
>
> src/java.base/macosx/native/libosxsecurity/KeystoreImpl.m line
On Tue, 28 Feb 2023 17:55:39 GMT, Christoph Langer wrote:
> Makes sense.
Hi Christoph, thanks for the review !
May I have a second review ?
Thanks, Matthias
-
PR: https://git.openjdk.org/jdk/pull/12788
We have a (potential) early return in addCertificatesToKeystore in
KeystoreImpl.m . This is implemented by the CHECK_NULL macro. However this
missed a CFRelease call.
-
Commit messages:
- JDK-8303354
Changes: https://git.openjdk.org/jdk/pull/12788/files
Webrev: https://webrevs.op
On Thu, 16 Feb 2023 11:51:59 GMT, Lutz Schmidt wrote:
>> This PR addresses an issue in the AES-CTR mode intrinsic on s390. When a
>> message is ciphered in multiple, small (< 16 bytes) segments, the result is
>> incorrect.
>>
>> This is not just a band-aid fix. The issue was taken as a chance
On Mon, 30 Jan 2023 12:26:57 GMT, Lutz Schmidt wrote:
>> This PR addresses an issue in the AES-CTR mode intrinsic on s390. When a
>> message is ciphered in multiple, small (< 16 bytes) segments, the result is
>> incorrect.
>>
>> This is not just a band-aid fix. The issue was taken as a chance
On Mon, 30 Jan 2023 12:26:57 GMT, Lutz Schmidt wrote:
>> This PR addresses an issue in the AES-CTR mode intrinsic on s390. When a
>> message is ciphered in multiple, small (< 16 bytes) segments, the result is
>> incorrect.
>>
>> This is not just a band-aid fix. The issue was taken as a chance
On Tue, 6 Dec 2022 15:20:26 GMT, Matthias Baesken wrote:
> We have a number of places in the codebase where a macro could help when we
> check an exception and afterwrads free something and return.
okay, if keeping the block in the code that contains free and return, we
probably jus
On Tue, 6 Dec 2022 15:20:26 GMT, Matthias Baesken wrote:
> We have a number of places in the codebase where a macro could help when we
> check an exception and afterwrads free something and return.
This pull request has been closed without being integrated.
-
PR:
On Thu, 22 Dec 2022 11:44:52 GMT, Matthias Baesken wrote:
> The test sun/security/ssl/SSLSessionImpl/ResumptionUpdateBoundValues.java
> fails intermittent with timeouts , this info should be added to the test.
This pull request has now been integrated.
Changeset: d490f15e
The test sun/security/ssl/SSLSessionImpl/ResumptionUpdateBoundValues.java
fails intermittent with timeouts , this info should be added to the test.
-
Commit messages:
- JDK-8235297
Changes: https://git.openjdk.org/jdk/pull/11766/files
Webrev: https://webrevs.openjdk.org/?repo=jd
On Tue, 6 Dec 2022 15:20:26 GMT, Matthias Baesken wrote:
> We have a number of places in the codebase where a macro could help when we
> check an exception and afterwrads free something and return.
Hi Roger , the new proposed version JNU_CHECK_EXCEPTION_DO is now almost as
lengthy
On Tue, 6 Dec 2022 20:40:34 GMT, Roger Riggs wrote:
> The existing code more obviously handles memory deallocation.
Thomas Stuefe suggested something like this
JNU_CHECK_EXCEPTION_DO(env, action)
JNU_CHECK_EXCEPTION_DO_AND_RETURN(env, action, retval)
usage example:
`JNU_CHECK_EXCEPTION_DO(e
We have a number of places in the codebase where a macro could help when we
check an exception and afterwrads free something and return.
-
Commit messages:
- JDK-8298170
Changes: https://git.openjdk.org/jdk/pull/11539/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11539&r
On Mon, 7 Nov 2022 12:49:21 GMT, Matthias Baesken wrote:
> The java/security/Exceptions/ChainingConstructors jdk jtreg test shows quite
> a lot of code duplication. The test code can be simplified e.g. by using
> generics. Additionally the test failure output was improved and a test f
On Tue, 8 Nov 2022 16:16:53 GMT, Matthias Baesken wrote:
>> The java/security/Exceptions/ChainingConstructors jdk jtreg test shows quite
>> a lot of code duplication. The test code can be simplified e.g. by using
>> generics. Additionally the test failure output was impro
On Mon, 7 Nov 2022 12:49:21 GMT, Matthias Baesken wrote:
> The java/security/Exceptions/ChainingConstructors jdk jtreg test shows quite
> a lot of code duplication. The test code can be simplified e.g. by using
> generics. Additionally the test failure output was improved and a test f
on was added.
Matthias Baesken has updated the pull request incrementally with one additional
commit since the last revision:
Add SSLException test, adjust summary, add bug-id
-
Changes:
- all: https://git.openjdk.org/jdk/pull/11016/files
- new: https://git.openjdk.org/jdk/pull
On Tue, 8 Nov 2022 14:01:29 GMT, Sean Mullan wrote:
>> The java/security/Exceptions/ChainingConstructors jdk jtreg test shows quite
>> a lot of code duplication. The test code can be simplified e.g. by using
>> generics. Additionally the test failure output was improved and a test for
>> the c
1 - 100 of 136 matches
Mail list logo
