Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v2]

2025-05-13 Thread John R Rose
On Wed, 7 May 2025 11:17:19 GMT, Volkan Yazici wrote: >> src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java line 302: >> >>> 300: * WARNING: This method does not perform any bound checks. >>> 301: */ >>> 302: int countPositives(byte[] ba, int off, int len); >> >>

Re: RFR: 8347606: Optimize Java implementation of ML-DSA

2025-02-21 Thread John R Rose
On Sun, 16 Feb 2025 15:41:52 GMT, Chen Liang wrote: >> src/java.base/share/classes/sun/security/provider/ML_DSA.java line 1237: >> >>> 1235: return res; >>> 1236: } >>> 1237: >> >> Centralizing the allocation into a helper on its own Looks unseful (for >> resource Management, debu

Re: RFR: 8341916: Remove ProtectionDomain related hotspot code and tests [v6]

2024-11-15 Thread John R Rose
On Fri, 15 Nov 2024 23:43:33 GMT, Coleen Phillimore wrote: >> Remove Hotspot code that passes protection_domain around class loading so >> that checkPackageAccess can be called and the result stored. With the >> removal of the Security Manager in JEP 486, this code no longer does >> anything.

Re: RFR: 8341916: Remove ProtectionDomain related hotspot code and tests [v6]

2024-11-15 Thread John R Rose
On Sat, 16 Nov 2024 02:48:09 GMT, John R Rose wrote: >> Coleen Phillimore has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains nine commits: >> >> - Handle merge conflicts in new resolve_instance_class c

Re: RFR: 8341916: Remove ProtectionDomain related hotspot code and tests [v6]

2024-11-15 Thread John R Rose
On Fri, 15 Nov 2024 23:43:33 GMT, Coleen Phillimore wrote: >> Remove Hotspot code that passes protection_domain around class loading so >> that checkPackageAccess can be called and the result stored. With the >> removal of the Security Manager in JEP 486, this code no longer does >> anything.