On Tue, 20 May 2025 19:10:45 GMT, Sean Mullan wrote:
> Please also write a release note as the performance improvement is
> significant. Thanks!
Done. https://bugs.openjdk.org/browse/JDK-8357741 Release Note: ML-KEM
Performance Improved
-
PR Comment: https://git.openjdk.org/jdk/p
On Tue, 20 May 2025 23:51:15 GMT, Leonid Mesnik wrote:
> I haven't find answer an my question about testing. How this fix is tested?
The change in the file test/jdk/sun/security/provider/acvp/Launcher.java in PR
https://github.com/openjdk/jdk/pull/23860/files covers this as well.
-
On Tue, 29 Apr 2025 18:49:52 GMT, Ferenc Rakoczi wrote:
> By using the AVX-512 vector registers the speed of the computation of the
> ML-KEM algorithms (key generation, encapsulation, decapsulation) can be
> approximately doubled.
This pull request has now been integrated.
> By using the AVX-512 vector registers the speed of the computation of the
> ML-KEM algorithms (key generation, encapsulation, decapsulation) can be
> approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last revision:
On Fri, 16 May 2025 00:28:18 GMT, Sandhya Viswanathan
wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Response to review comment + loading constants with broadcast op.
On Thu, 15 May 2025 00:36:26 GMT, Sandhya Viswanathan
wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Responding to comments by Sandhya.
>
> Another minor comment. Rest of the
On Wed, 14 May 2025 16:04:31 GMT, Sandhya Viswanathan
wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Responding to comments by Sandhya.
>
> src/hotspot/cpu/x86/stubGener
> By using the AVX-512 vector registers the speed of the computation of the
> ML-KEM algorithms (key generation, encapsulation, decapsulation) can be
> approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last
On Wed, 14 May 2025 16:00:55 GMT, Sandhya Viswanathan
wrote:
>> Actually, the Java version is the one that is too cautious. There is Barrett
>> reduction after at most 4 consecutive uses of mlKemAddPoly(), so doing the
>> reduction in implKyberAddPoly() is not necessary. Thanks for discovering
> By using the AVX-512 vector registers the speed of the computation of the
> ML-KEM algorithms (key generation, encapsulation, decapsulation) can be
> approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last
On Tue, 13 May 2025 17:53:50 GMT, Sandhya Viswanathan
wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Restoring copyright notice on ML_KEM.java
>
> src/hotspot/cpu/x86/stubGener
> By using the AVX-512 vector registers the speed of the computation of the
> ML-KEM algorithms (key generation, encapsulation, decapsulation) can be
> approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last
> By using the AVX-512 vector registers the speed of the computation of the
> ML-KEM algorithms (key generation, encapsulation, decapsulation) can be
> approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last
> By using the AVX-512 vector registers the speed of the computation of the
> ML-KEM algorithms (key generation, encapsulation, decapsulation) can be
> approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last
By using the AVX-512 vector registers the speed of the computation of the
ML-KEM algorithms (key generation, encapsulation, decapsulation) can be
approximately doubled.
-
Commit messages:
- 8351412: Add AVX-512 intrinsics for ML-KEM
Changes: https://git.openjdk.org/jdk/pull/24953/
On Thu, 10 Apr 2025 15:30:28 GMT, Weijun Wang wrote:
> Add 2 `MessageDigest` algorithms.
I strongly support the names "SHAKE128-256" and "SHAKE256-512".
-
PR Comment: https://git.openjdk.org/jdk/pull/24576#issuecomment-2834807368
On Wed, 16 Apr 2025 19:22:51 GMT, Vladimir Ivanov wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fixed asserts.
>
> src/hotspot/cpu/aarch64/vm_version_aarch64.cpp line 717:
>
On Mon, 17 Feb 2025 13:53:30 GMT, Ferenc Rakoczi wrote:
> By using the aarch64 vector registers the speed of the computation of the
> ML-KEM algorithms (key generation, encapsulation, decapsulation) can be
> approximately doubled.
This pull request has now been integrated.
On Tue, 15 Apr 2025 18:21:00 GMT, Ferenc Rakoczi wrote:
>>> @ferakocz
>>>
>>> Hi Ferenc,
>>>
>>> Sorry, but I still had a few comments to add to the KyberNTTMult routine to
>>> clarify exactly how the load, compute and store operations re
On Tue, 15 Apr 2025 15:09:16 GMT, Ferenc Rakoczi wrote:
>> @adinn Hi, Andrew,
>> I think I addressed all of your comment improvement comments, in most cases
>> I just changed them as you suggested. Thanks a lot for the thorough review!
>
>> @ferakocz
>>
>&g
> By using the aarch64 vector registers the speed of the computation of the
> ML-KEM algorithms (key generation, encapsulation, decapsulation) can be
> approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last revision:
> By using the aarch64 vector registers the speed of the computation of the
> ML-KEM algorithms (key generation, encapsulation, decapsulation) can be
> approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last
> By using the aarch64 vector registers the speed of the computation of the
> ML-KEM algorithms (key generation, encapsulation, decapsulation) can be
> approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last
> By using the aarch64 vector registers the speed of the computation of the
> ML-KEM algorithms (key generation, encapsulation, decapsulation) can be
> approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last
On Mon, 14 Apr 2025 12:26:09 GMT, Ferenc Rakoczi wrote:
>> @ferakocz Hi Ferenc. Thank you for adjusting the code as requested and even
>> more so for the extra clean-ups you added which I very much appreciate.
>>
>> I have added suggestions for some extra/modifi
On Thu, 10 Apr 2025 16:50:29 GMT, Andrew Dinn wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Code rearrange, some renaming, fixing comments
>> - Changes suggested by Andrew
> By using the aarch64 vector registers the speed of the computation of the
> ML-KEM algorithms (key generation, encapsulation, decapsulation) can be
> approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with two additional
commits since the last revision:
On Mon, 3 Mar 2025 11:12:58 GMT, Ferenc Rakoczi wrote:
> By using the AVX-512 vector registers the speed of the computation of the
> ML-DSA algorithms (key generation, document signing, signature verification)
> can be approximately doubled.
This pull request has now been i
On Wed, 9 Apr 2025 17:09:09 GMT, Ferenc Rakoczi wrote:
>> Overall very clean and nicely done PR. Thanks a lot for considering my
>> inputs.
>
>> Overall very clean and nicely done PR. Thanks a lot for considering my
>> inputs.
>
> That is in no small part th
On Tue, 8 Apr 2025 21:58:57 GMT, Sandhya Viswanathan
wrote:
> Overall very clean and nicely done PR. Thanks a lot for considering my inputs.
That is in no small part thanks to the reviewers, especially to Volodymyr!
@lmesnik, @jatin-bhateja, @sviswa7 would one of you /sponsor me with the
integ
On Sat, 5 Apr 2025 00:27:05 GMT, Sandhya Viswanathan
wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Reacting to comment by Sandhya.
>
> src/hotspot/cpu/x86/stubGenerator
> By using the AVX-512 vector registers the speed of the computation of the
> ML-DSA algorithms (key generation, document signing, signature verification)
> can be approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since
> By using the AVX-512 vector registers the speed of the computation of the
> ML-DSA algorithms (key generation, document signing, signature verification)
> can be approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since
> By using the AVX-512 vector registers the speed of the computation of the
> ML-DSA algorithms (key generation, document signing, signature verification)
> can be approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since
On Tue, 1 Apr 2025 22:43:36 GMT, Sandhya Viswanathan
wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Reacting to comments by Volodymyr.
>
> src/hotspot/cpu/x86/stubGenerator_x86_6
On Sat, 22 Mar 2025 16:36:08 GMT, Volodymyr Paprotski
wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix windows build
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_dilithium.c
On Thu, 6 Mar 2025 19:26:14 GMT, Volodymyr Paprotski
wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Accepted review comments.
>
> src/hotspot/cpu/x86/stubGenerator_x86_6
On Thu, 27 Mar 2025 21:42:08 GMT, Volodymyr Paprotski
wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Further readability improvements.
>> - Added asserts for array
> By using the AVX-512 vector registers the speed of the computation of the
> ML-DSA algorithms (key generation, document signing, signature verification)
> can be approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since
On Sat, 22 Mar 2025 16:11:02 GMT, Volodymyr Paprotski
wrote:
>> These functions will not be used anywhere else and in ML_DSA.java all of the
>> arrays passed to inrinsics are of the correct size.
>
> Works for me; just thought I would point it out, so its a 'premeditated'
> decision.
Well, I
On Sun, 23 Mar 2025 00:26:20 GMT, Volodymyr Paprotski
wrote:
>> src/hotspot/cpu/x86/stubGenerator_x86_64_dilithium.cpp line 216:
>>
>>> 214: // Zmm8-Zmm23 used as scratch registers
>>> 215: // result goes to Zmm0-Zmm7
>>> 216: static void montMulByConst128(MacroAssembler *_masm) {
>>
>> wish t
On Mon, 17 Mar 2025 19:22:41 GMT, Volodymyr Paprotski
wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Made the intrinsics test separate from the pure java test.
On Mon, 24 Mar 2025 15:16:20 GMT, Volodymyr Paprotski
wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Further readability improvements.
>> - Added asserts for array sizes
>
On Sun, 23 Mar 2025 00:21:18 GMT, Volodymyr Paprotski
wrote:
>> src/hotspot/cpu/x86/stubGenerator_x86_64_dilithium.cpp line 119:
>>
>>> 117: static address dilithiumAvx512PermsAddr() {
>>> 118: return (address) dilithiumAvx512Perms;
>>> 119: }
>>
>> Hear me out.. ...
>> enums!!
>>
>> enum
On Mon, 24 Mar 2025 02:38:37 GMT, Jatin Bhateja wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Further readability improvements.
>> - Added asserts for array sizes
>
> sr
> By using the aarch64 vector registers the speed of the computation of the
> ML-KEM algorithms (key generation, encapsulation, decapsulation) can be
> approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last revision:
> By using the AVX-512 vector registers the speed of the computation of the
> ML-DSA algorithms (key generation, document signing, signature verification)
> can be approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with two additional
commits since
On Thu, 6 Mar 2025 19:27:12 GMT, Volodymyr Paprotski
wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Accepted review comments.
>
> src/hotspot/cpu/x86/stubGenerator_x86_6
On Mon, 17 Mar 2025 19:24:52 GMT, Volodymyr Paprotski
wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Made the intrinsics test separate from the pure java test.
> By using the AVX-512 vector registers the speed of the computation of the
> ML-DSA algorithms (key generation, document signing, signature verification)
> can be approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since
> By using the AVX-512 vector registers the speed of the computation of the
> ML-DSA algorithms (key generation, document signing, signature verification)
> can be approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since
On Wed, 12 Mar 2025 15:34:18 GMT, Leonid Mesnik wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Added validity test for the intrinsics.
>
> test/jdk/sun/security/provider/acvp/L
> By using the AVX-512 vector registers the speed of the computation of the
> ML-DSA algorithms (key generation, document signing, signature verification)
> can be approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since
On Thu, 6 Mar 2025 14:30:35 GMT, Jatin Bhateja wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Added alignment to loop entries.
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_dilithiu
On Thu, 6 Mar 2025 09:32:19 GMT, Jatin Bhateja wrote:
>> I think the easiest is to put a for (int i = 0; i < 1000; i++) loop around
>> the switch statement in the run() method of the ML_DSA_Test class
>> (test/jdk/sun/security/provider/acvp/ML_DSA_Test.java). (This is because the
>> intrinsi
On Mon, 10 Mar 2025 03:00:09 GMT, Leonid Mesnik wrote:
> There are no any new tests in the PR. How fix has been tested by openjdk
> tests?
I have just added one.
-
PR Comment: https://git.openjdk.org/jdk/pull/23860#issuecomment-2717950685
> By using the AVX-512 vector registers the speed of the computation of the
> ML-DSA algorithms (key generation, document signing, signature verification)
> can be approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since
> By using the AVX-512 vector registers the speed of the computation of the
> ML-DSA algorithms (key generation, document signing, signature verification)
> can be approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since
On Thu, 6 Mar 2025 08:37:57 GMT, Jatin Bhateja wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Added alignment to loop entries.
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_sh
On Wed, 5 Mar 2025 14:03:00 GMT, Jatin Bhateja wrote:
>> Hi, @jatin-bhateja, thanks for the suggestion. I have added __
>> align(OptoLoopAlignment); before all loop entries.
>
> Hi @ferakocz ,
>
> Thanks!, for efficient utilization of Decode ICache (please refer to Intel
> SDM section 3.4.2.5
On Wed, 5 Mar 2025 11:39:05 GMT, Jatin Bhateja wrote:
>> Ferenc Rakoczi has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains three commits:
>>
>> - Merged master.
>> - Added comments, removed debugging
> By using the AVX-512 vector registers the speed of the computation of the
> ML-DSA algorithms (key generation, document signing, signature verification)
> can be approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since
> By using the AVX-512 vector registers the speed of the computation of the
> ML-DSA algorithms (key generation, document signing, signature verification)
> can be approximately doubled.
Ferenc Rakoczi has updated the pull request with a new target base due to a
merge or a rebase.
> By using the aarch64 vector registers the speed of the computation of the
> ML-KEM algorithms (key generation, encapsulation, decapsulation) can be
> approximately doubled.
Ferenc Rakoczi has updated the pull request with a new target base due to a
merge or a rebase. The pull re
On Fri, 24 Jan 2025 14:24:23 GMT, Ferenc Rakoczi wrote:
> By using the aarch64 vector registers the speed of the computation of the
> ML-DSA algorithms (key generation, document signing, signature verification)
> can be approximately doubled.
This pull request has now been i
On Tue, 4 Mar 2025 11:11:44 GMT, Ferenc Rakoczi wrote:
>> Oops. sorry - cut and paste error -- the new setting should be
>>
>> do_arch_blob(compiler, 55000 ZGC_ONLY(+5000))
>
>> Oops. sorry - cut and paste error -- the new setting should be
>>
>> ```
&
On Thu, 27 Feb 2025 09:53:21 GMT, Andrew Dinn wrote:
> Oops. sorry - cut and paste error -- the new setting should be
>
> ```
> do_arch_blob(compiler, 55000 ZGC_ONLY(+5000))
> ```
@adinn, I have done this change, but that erased your approval. Could you
reapprove?
-
PR Comment: h
> By using the AVX-512 vector registers the speed of the computation of the
> ML-DSA algorithms (key generation, document signing, signature verification)
> can be approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since
By using the AVX-512 vector registers the speed of the computation of the
ML-DSA algorithms (key generation, document signing, signature verification)
can be approximately doubled.
-
Commit messages:
- JDK-8351034 Add AVX-512 intrinsics for ML-DSA
Changes: https://git.openjdk.org/
> By using the aarch64 vector registers the speed of the computation of the
> ML-KEM algorithms (key generation, encapsulation, decapsulation) can be
> approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last revis
> By using the aarch64 vector registers the speed of the computation of the
> ML-KEM algorithms (key generation, encapsulation, decapsulation) can be
> approximately doubled.
Ferenc Rakoczi has updated the pull request with a new target base due to a
merge or a rebase. The pull re
> By using the aarch64 vector registers the speed of the computation of the
> ML-DSA algorithms (key generation, document signing, signature verification)
> can be approximately doubled.
Ferenc Rakoczi has updated the pull request with a new target base due to a
merge or a rebase.
On Thu, 27 Feb 2025 10:15:48 GMT, Andrew Haley wrote:
>> OK, so GNU as is more forgiving than Apple as...
>
> Did my patch to aarch64-asmtest.py solve the problem?
I haven't tried, I just used GNU as.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/23300#discussion_r197397035
> By using the aarch64 vector registers the speed of the computation of the
> ML-DSA algorithms (key generation, document signing, signature verification)
> can be approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with two additional
commits since
On Tue, 25 Feb 2025 13:50:35 GMT, Andrew Haley wrote:
>> I just tried it with top-of trunk latest binutils:
>>
>> fedora:aarch64 $ ~/binutils-gdb-install/bin/as
>> -march=armv9-a+sha3+sve2-bitperm aarch64ops.s
>> fedora:aarch64 $ ~/binutils-gdb-install/bin/as --version
>> GNU assembler (GNU Bin
On Tue, 25 Feb 2025 09:36:49 GMT, Andrew Haley wrote:
>> @ferakocz This also really needs addressing before committing the patch.
>> Perhaps @theRealAph can advise on how to circumvent the problems you found
>> when trying to update the python script?
>
>> You might have to use an assembler fro
On Tue, 18 Feb 2025 13:43:18 GMT, Andrew Dinn wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Adding comments + some code reorganization
>
> src/hotspot/cpu/aarch64/stubG
On Wed, 19 Feb 2025 02:55:18 GMT, Hao Sun wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Adding comments + some code reorganization
>
> Hi. Here is the test result of our CI.
&g
On Tue, 18 Feb 2025 13:33:52 GMT, Andrew Dinn wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Adding comments + some code reorganization
>
> src/hotspot/cpu/aarch64/assembler_aar
> By using the aarch64 vector registers the speed of the computation of the
> ML-DSA algorithms (key generation, document signing, signature verification)
> can be approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with four additional
commits since
On Tue, 11 Feb 2025 10:40:31 GMT, Bhavana Kilambi wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Adding comments + some code reorganization
>
> src/hotspot/cpu/aarch64/a
By using the aarch64 vector registers the speed of the computation of the
ML-KEM algorithms (key generation, encapsulation, decapsulation) can be
approximately doubled.
-
Commit messages:
- removing trailing spaces
- kyber aarch64 intrinsics
Changes: https://git.openjdk.org/jdk/p
> By using the aarch64 vector registers the speed of the computation of the
> ML-DSA algorithms (key generation, document signing, signature verification)
> can be approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since
On Mon, 3 Feb 2025 18:11:51 GMT, Ferenc Rakoczi wrote:
>> @ferakocz I'm afraid you lucked out on getting your change committed before
>> my reorganization of the stub generation code. If you are unsure of how to
>> do the merge so your new stub is declared and gene
On Thu, 30 Jan 2025 16:23:56 GMT, Andrew Dinn wrote:
> @ferakocz I'm afraid you lucked out on getting your change committed before
> my reorganization of the stub generation code. If you are unsure of how to do
> the merge so your new stub is declared and generated following the new model
> (s
> By using the aarch64 vector registers the speed of the computation of the
> ML-DSA algorithms (key generation, document signing, signature verification)
> can be approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since
> By using the aarch64 vector registers the speed of the computation of the
> ML-DSA algorithms (key generation, document signing, signature verification)
> can be approximately doubled.
Ferenc Rakoczi has updated the pull request with a new target base due to a
merge or a rebase.
> By using the aarch64 vector registers the speed of the computation of the
> ML-DSA algorithms (key generation, document signing, signature verification)
> can be approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since
By using the aarch64 vector registers the speed of the computation of the
ML-DSA algorithms (key generation, document signing, signature verification)
can be approximately doubled.
-
Commit messages:
- fixing whitespace errors
- 8348561: Add aarch64 intrinsics for ML-DSA
Changes:
On Thu, 14 Nov 2024 20:59:36 GMT, Artur Barashev wrote:
>> Given this is a performance change, I'm fine with leaving it as is. Jumping
>> to a helper method with an encrypt/decrypt conditional check for every
>> crypto op will costs performance. This is a case where more efficient code
>> is
On Wed, 13 Nov 2024 21:14:41 GMT, Ben Perez wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/SHA3Parallel.java line
>> 37:
>>
>>> 35: import static sun.security.provider.SHA3.keccak;
>>> 36:
>>> 37: public class SHA3Parallel {
>>
>> Why not merge this with `sun.security.provider.
On Thu, 14 Nov 2024 00:44:35 GMT, Volodymyr Paprotski
wrote:
>> Measuring throughput with JMH parameters `-f 1 -i 2 -wi 3 -r 20 -w 30 -p
>> algorithm=AES/CBC/NoPadding -p dataSize=3000 -p provider=SunJCE -p
>> keyLength=128 org.openjdk.bench.javax.crypto.full.AESBench`
>>
>> Before:
>>
On Thu, 10 Oct 2024 15:43:18 GMT, Weijun Wang wrote:
>> Ben Perez has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> renamed internal keyGen/sign/verify functions to be same as spec
>
> src/java.base/share/classes/sun/security/provider/ML_D
On Thu, 10 Oct 2024 15:42:21 GMT, Weijun Wang wrote:
>> Ben Perez has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> renamed internal keyGen/sign/verify functions to be same as spec
>
> src/java.base/share/classes/sun/security/provider/ML_D
On Thu, 10 Oct 2024 15:40:48 GMT, Weijun Wang wrote:
>> Ben Perez has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> renamed internal keyGen/sign/verify functions to be same as spec
>
> src/java.base/share/classes/sun/security/provider/ML_D
On Mon, 19 Aug 2024 19:38:37 GMT, Ferenc Rakoczi wrote:
> In preparation for the new PQC algorithms implementations, internal XOF
> (eXtendable Output Function) methods are added to the SHAKE128 and SHAKE256
> implementations.
This pull request has now been integrated.
Changeset:
On Wed, 28 Aug 2024 16:42:38 GMT, Ferenc Rakoczi wrote:
>> In preparation for the new PQC algorithms implementations, internal XOF
>> (eXtendable Output Function) methods are added to the SHAKE128 and SHAKE256
>> implementations.
>
> Ferenc Rakoczi has updated the pu
> In preparation for the new PQC algorithms implementations, internal XOF
> (eXtendable Output Function) methods are added to the SHAKE128 and SHAKE256
> implementations.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last revision:
A
On Wed, 28 Aug 2024 18:18:22 GMT, Valerie Peng wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fixing typos and simplify the squeeze() method as suggested by Weijun
>
> src/java.b
On Wed, 28 Aug 2024 13:24:04 GMT, Weijun Wang wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Code style changes suggested by Andrey Turbanov
>
> src/java.base/share/classes/sun/se
1 - 100 of 214 matches
Mail list logo
