On Tue, 7 Mar 2023 01:40:48 GMT, Cesar Soares Lucas wrote:
> Can I please get reviews for this PR?
>
> The most common and frequent use of NonEscaping Phis merging object
> allocations is for debugging information. The two graphs below show numbers
> for Renaissance and Da
On Tue, 20 Jun 2023 16:44:28 GMT, Vladimir Ivanov wrote:
>> Thank you once more for the comments @iwanowww . I’ll address them asap.
>>
>> Can I ask what requirements are there for a product flag?
>
>> Can I ask what requirements are there for a product flag?
>
> Product flags are treated as p
On Thu, 6 Jul 2023 13:06:30 GMT, Cesar Soares Lucas wrote:
>> Can I please get reviews for this PR?
>>
>> The most common and frequent use of NonEscaping Phis merging object
>> allocations is for debugging information. The two graphs below show numbers
>&
On Tue, 20 Jun 2023 16:44:28 GMT, Vladimir Ivanov wrote:
>> Thank you once more for the comments @iwanowww . I’ll address them asap.
>>
>> Can I ask what requirements are there for a product flag?
>
>> Can I ask what requirements are there for a product flag?
>
> Product flags are treated as p
e
> any failure. I also ran tests with "-ea -esa -Xbatch -Xcomp
> -XX:+UnlockExperimentalVMOptions -XX:-TieredCompilation -server
> -XX:+IgnoreUnrecognizedVMOptions -XX:+UnlockDiagnosticVMOptions
> -XX:+StressLCM -XX:+StressGCM -XX:+StressCCP" and didn't observe any related
> f
On Wed, 14 Jun 2023 20:48:36 GMT, Vladimir Ivanov wrote:
>> Cesar Soares Lucas has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 19 commits:
>>
>> - Merge branch 'openjdk:master' into rematerial
On Fri, 23 Jun 2023 21:24:20 GMT, Vladimir Ivanov wrote:
>> @iwanowww - I'm confused by what a "Diagnostic" flag is. According to [this
>> documentation](https://wiki.openjdk.org/display/HotSpot/Hotspot+Command-line+Flags%3A+Kinds%2C+Lifecycle+and+the+CSR+Process)
>> "Diagnostic flags are not m
e
> any failure. I also ran tests with "-ea -esa -Xbatch -Xcomp
> -XX:+UnlockExperimentalVMOptions -XX:-TieredCompilation -server
> -XX:+IgnoreUnrecognizedVMOptions -XX:+UnlockDiagnosticVMOptions
> -XX:+StressLCM -XX:+StressGCM -XX:+StressCCP" and didn't observe a
e
> any failure. I also ran tests with "-ea -esa -Xbatch -Xcomp
> -XX:+UnlockExperimentalVMOptions -XX:-TieredCompilation -server
> -XX:+IgnoreUnrecognizedVMOptions -XX:+UnlockDiagnosticVMOptions
> -XX:+StressLCM -XX:+StressGCM -XX:+StressCCP" and didn't observe any related
> f
On Wed, 14 Jun 2023 20:19:58 GMT, Vladimir Ivanov wrote:
>> Cesar Soares Lucas has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 19 commits:
>>
>> - Merge branch 'openjdk:master' into rematerial
On Sat, 17 Jun 2023 00:41:32 GMT, Vladimir Ivanov wrote:
>> Cesar Soares Lucas has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 19 commits:
>>
>> - Merge branch 'openjdk:master' into rematerial
e
> any failure. I also ran tests with "-ea -esa -Xbatch -Xcomp
> -XX:+UnlockExperimentalVMOptions -XX:-TieredCompilation -server
> -XX:+IgnoreUnrecognizedVMOptions -XX:+UnlockDiagnosticVMOptions
> -XX:+StressLCM -XX:+StressGCM -XX:+StressCCP" and didn't observe any related
> f
On Fri, 9 Jun 2023 17:23:22 GMT, Vladimir Ivanov wrote:
>> Cesar Soares Lucas has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Rome minor refactorings.
>
> Overall, I like how this patch shapes.
>
On Tue, 6 Jun 2023 23:14:14 GMT, Cesar Soares Lucas wrote:
>> Can I please get reviews for this PR?
>>
>> The most common and frequent use of NonEscaping Phis merging object
>> allocations is for debugging information. The two graphs below show numbers
>&
On Tue, 23 May 2023 17:19:23 GMT, Vladimir Ivanov wrote:
>>> I verified that the new test cases do trigger SR+NSR scenario.
>>>
>>> How do you test that deoptimization works as expected?
>>>
>>
>> I have a copy of the tests in AllocationMergesTests.java in a separate file
>> (not included in
On Tue, 23 May 2023 17:19:23 GMT, Vladimir Ivanov wrote:
>>> I verified that the new test cases do trigger SR+NSR scenario.
>>>
>>> How do you test that deoptimization works as expected?
>>>
>>
>> I have a copy of the tests in AllocationMergesTests.java in a separate file
>> (not included in
e
> any failure. I also ran tests with "-ea -esa -Xbatch -Xcomp
> -XX:+UnlockExperimentalVMOptions -XX:-TieredCompilation -server
> -XX:+IgnoreUnrecognizedVMOptions -XX:+UnlockDiagnosticVMOptions
> -XX:+StressLCM -XX:+StressGCM -XX:+StressCCP" and didn't observe an
e
> any failure. I also ran tests with "-ea -esa -Xbatch -Xcomp
> -XX:+UnlockExperimentalVMOptions -XX:-TieredCompilation -server
> -XX:+IgnoreUnrecognizedVMOptions -XX:+UnlockDiagnosticVMOptions
> -XX:+StressLCM -XX:+StressGCM -XX:+StressCCP" and didn't observe any related
> f
e
> any failure. I also ran tests with "-ea -esa -Xbatch -Xcomp
> -XX:+UnlockExperimentalVMOptions -XX:-TieredCompilation -server
> -XX:+IgnoreUnrecognizedVMOptions -XX:+UnlockDiagnosticVMOptions
> -XX:+StressLCM -XX:+StressGCM -XX:+StressCCP" and didn't observe any related
> f
On Mon, 5 Jun 2023 22:03:59 GMT, Vladimir Ivanov wrote:
>> Thanks @iwanowww . Does the output below look good to you? It prints
>> ObjectValue in the same format as it was before this PR and only print
>> details of the merge in the "Objects" section. Is there other output section
>> that you
On Mon, 5 Jun 2023 05:05:26 GMT, Vladimir Ivanov wrote:
>> Cesar Soares Lucas has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 15 commits:
>>
>> - Catching up with master branch.
>>
>>
On Mon, 5 Jun 2023 20:27:48 GMT, Vladimir Ivanov wrote:
>>> If you mean the tabs on lines 303/304/306/307
>>
>> Yes, it confused me. As an alternative, you could put selector and
>> merge_pointer-related statements on the same line, but I'm not sure how much
>> it improves readability:
>>
>>
On Mon, 5 Jun 2023 05:10:13 GMT, Vladimir Ivanov wrote:
>> Cesar Soares Lucas has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 15 commits:
>>
>> - Catching up with master branch.
>>
>>
On Mon, 5 Jun 2023 19:26:59 GMT, Cesar Soares Lucas wrote:
>> src/hotspot/share/code/debugInfo.cpp line 301:
>>
>>> 299: void ObjectMergeValue::print_detailed(outputStream* st) const {
>>> 300: st->print("merge: ID=%d", _id);
>>> 301: #ifnde
On Mon, 5 Jun 2023 18:05:47 GMT, Vladimir Ivanov wrote:
>> Cesar Soares Lucas has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 15 commits:
>>
>> - Catching up with master branch.
>>
>>
On Tue, 23 May 2023 17:19:23 GMT, Vladimir Ivanov wrote:
>>> I verified that the new test cases do trigger SR+NSR scenario.
>>>
>>> How do you test that deoptimization works as expected?
>>>
>>
>> I have a copy of the tests in AllocationMergesTests.java in a separate file
>> (not included in
e
> any failure. I also ran tests with "-ea -esa -Xbatch -Xcomp
> -XX:+UnlockExperimentalVMOptions -XX:-TieredCompilation -server
> -XX:+IgnoreUnrecognizedVMOptions -XX:+UnlockDiagnosticVMOptions
> -XX:+StressLCM -XX:+StressGCM -XX:+StressCCP" and didn't observe any related
> failu
On Mon, 22 May 2023 17:56:41 GMT, Cesar Soares Lucas
wrote:
> Speaking of _only_merge_candidate flag, I find it easier about the code when
> the property being tracked is whether the ObjectValue is referenced from
> corresponding JVM state or not. (Maybe call it is_root()?) So,
&g
On Fri, 19 May 2023 04:06:47 GMT, Vladimir Ivanov wrote:
> I verified that the new test cases do trigger SR+NSR scenario.
>
> How do you test that deoptimization works as expected?
>
I have a copy of the tests in AllocationMergesTests.java in a separate file
(not included in this PR) and I ru
e
> any failure. I also ran tests with "-ea -esa -Xbatch -Xcomp
> -XX:+UnlockExperimentalVMOptions -XX:-TieredCompilation -server
> -XX:+IgnoreUnrecognizedVMOptions -XX:+UnlockDiagnosticVMOptions
> -XX:+StressLCM -XX:+StressGCM -XX:+StressCCP" and didn't observe any related
On Tue, 9 May 2023 00:03:26 GMT, Vladimir Ivanov wrote:
>> Cesar Soares Lucas has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 12 commits:
>>
>> - Merge remote-tracking branch 'origin/master' in
On Tue, 9 May 2023 00:03:26 GMT, Vladimir Ivanov wrote:
>> Cesar Soares Lucas has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 12 commits:
>>
>> - Merge remote-tracking branch 'origin/master' in
On Mon, 8 May 2023 18:21:09 GMT, Vladimir Ivanov wrote:
>> Cesar Soares Lucas has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 12 commits:
>>
>> - Merge remote-tracking branch 'origin/master' in
On Fri, 21 Apr 2023 19:23:37 GMT, Vladimir Kozlov wrote:
>>> Again got failures in the test on Aarch64 running with -XX:-UseTLAB:
>>>
>>> ```
>>> testCmpMergeWithNull(boolean,int,int):
>>> - Failed comparison: [found] 0 = 2 [given]
>>> testCmpMergeWithNull_Second(boolean,int,int)
>>> - Failed co
e
> any failure. I also ran tests with "-ea -esa -Xbatch -Xcomp
> -XX:+UnlockExperimentalVMOptions -XX:-TieredCompilation -server
> -XX:+IgnoreUnrecognizedVMOptions -XX:+UnlockDiagnosticVMOptions
> -XX:+StressLCM -XX:+StressGCM -XX:+StressCCP" and didn't observe any related
> f
On Thu, 27 Apr 2023 23:36:06 GMT, Vladimir Ivanov wrote:
>> Can `ObjectCandidateValue` be a wrapper around a `ObjectAllocationValue`?
>>
>> It does make sense to separate `ObjectMergeValue` and `ObjectValue`.
>
> I need to to study the code in more details. Seems like I'm missing something
> im
On Wed, 26 Apr 2023 17:28:53 GMT, Cesar Soares Lucas
wrote:
>> Can I please get reviews for this PR?
>>
>> The most common and frequent use of NonEscaping Phis merging object
>> allocations is for debugging information. The two graphs below show numbers
>&
On Sat, 22 Apr 2023 01:42:41 GMT, Vladimir Ivanov wrote:
>> Cesar Soares Lucas has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 10 commits:
>>
>> - Catching up with master
>>
>>Merge r
On Wed, 26 Apr 2023 17:42:23 GMT, Vladimir Ivanov wrote:
> Is it possible for an ObjectValue to be shared between multiple merges?
When I posted my previous comment I thought that could happen. But now I
realize that in the current implementation that won't happen: an ObjectValue is
created fo
e
> any failure. I also ran tests with "-ea -esa -Xbatch -Xcomp
> -XX:+UnlockExperimentalVMOptions -XX:-TieredCompilation -server
> -XX:+IgnoreUnrecognizedVMOptions -XX:+UnlockDiagnosticVMOptions
> -XX:+StressLCM -XX:+StressGCM -XX:+StressCCP" and didn't observe any related
>
On Tue, 25 Apr 2023 21:19:06 GMT, Vladimir Ivanov wrote:
>> @iwanowww - may I ask why always allocating a fresh object might be better
>> than returning a pointer to a previous "selected" object?
>
> I don't mind there's caching happening if it gives any noticeable benefit. As
> of now, the cod
On Sat, 22 Apr 2023 01:42:41 GMT, Vladimir Ivanov wrote:
> Does it make sense to introduce 3 different subclasses under ObjectValue to
> clearly distinguish the scenarios?
I think that's a good idea. I'll give it a shot. Thanks.
> src/java.base/share/classes/java/security/AccessController.java
On Sat, 22 Apr 2023 01:52:37 GMT, Vladimir Ivanov wrote:
>> Cesar Soares Lucas has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 10 commits:
>>
>> - Catching up with master
>>
>>Merge r
On Sat, 22 Apr 2023 01:12:32 GMT, Vladimir Ivanov wrote:
>> Cesar Soares Lucas has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 10 commits:
>>
>> - Catching up with master
>>
>>Merge r
On Thu, 20 Apr 2023 00:35:19 GMT, Vladimir Kozlov wrote:
> Again got failures in the test on Aarch64 running with -XX:-UseTLAB:
>
> ```
> testCmpMergeWithNull(boolean,int,int):
> - Failed comparison: [found] 0 = 2 [given]
> testCmpMergeWithNull_Second(boolean,int,int)
> - Failed comparison: [fou
On Thu, 20 Apr 2023 19:27:58 GMT, Cesar Soares Lucas
wrote:
>> Can I please get reviews for this PR?
>>
>> The most common and frequent use of NonEscaping Phis merging object
>> allocations is for debugging information. The two graphs below show numbers
>&
e
> any failure. I also ran tests with "-ea -esa -Xbatch -Xcomp
> -XX:+UnlockExperimentalVMOptions -XX:-TieredCompilation -server
> -XX:+IgnoreUnrecognizedVMOptions -XX:+UnlockDiagnosticVMOptions
> -XX:+StressLCM -XX:+StressGCM -XX:+StressCCP" and didn't observe any related
> failu
On Sat, 15 Apr 2023 00:17:55 GMT, Vladimir Kozlov wrote:
>> Cesar Soares Lucas has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address PR review 3. Some comments and be able to abort compilation.
>
> N
e
> any failure. I also ran tests with "-ea -esa -Xbatch -Xcomp
> -XX:+UnlockExperimentalVMOptions -XX:-TieredCompilation -server
> -XX:+IgnoreUnrecognizedVMOptions -XX:+UnlockDiagnosticVMOptions
> -XX:+StressLCM -XX:+StressGCM -XX:+StressCCP" and didn't observe any related
> fail
On Fri, 24 Mar 2023 16:40:15 GMT, Vladimir Kozlov wrote:
>> Cesar Soares Lucas has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add support for SR'ing some inputs of merges used for field loads
>
> You
On Fri, 31 Mar 2023 18:30:19 GMT, Xin Liu wrote:
>> Cesar Soares Lucas has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address PR feeedback 1: make ObjectMergeValue subclass of ObjectValue &
>>
o tested with several applications and didn't see any
> failure. I also ran tests with "-ea -esa -Xbatch -Xcomp
> -XX:+UnlockExperimentalVMOptions -XX:-TieredCompilation -server
> -XX:+IgnoreUnrecognizedVMOptions -XX:+UnlockDiagnosticVMOptions
> -XX:+StressLCM -XX:+
On Thu, 6 Apr 2023 03:25:31 GMT, Vladimir Kozlov wrote:
>> Cesar Soares Lucas has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains seven commits:
>>
>> - Merge with Master
>> - Addressing PR review 2
On Thu, 6 Apr 2023 04:34:52 GMT, Vladimir Kozlov wrote:
>> Cesar Soares Lucas has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains seven commits:
>>
>> - Merge with Master
>> - Addressing PR review 2
o tested with several applications and didn't see any
> failure. I also ran tests with "-ea -esa -Xbatch -Xcomp
> -XX:+UnlockExperimentalVMOptions -XX:-TieredCompilation -server
> -XX:+IgnoreUnrecognizedVMOptions -XX:+UnlockDiagnosticVMOptions
> -XX:+StressLCM -XX:+StressGCM
On Wed, 5 Apr 2023 00:59:29 GMT, Cesar Soares Lucas wrote:
>> Do you really need the boolean parameter ignore_merges here?
>> It looks like we can use (safepoints == nullptr) instead?
>
>> It looks like we can use (safepoints == nullptr) instead?
>
> Yeap. Thanks
On Fri, 31 Mar 2023 18:38:43 GMT, Xin Liu wrote:
>> I see, you use it in escape.cpp. Okay. I need to review changes there too.
>
> or you could construct a temporary PhaseMacroExpand object in EA.
>
> I see that you convert many member function to static so you can query in EA.
> the only bloc
On Fri, 31 Mar 2023 18:24:45 GMT, Xin Liu wrote:
> It looks like we can use (safepoints == nullptr) instead?
Yeap. Thanks. I don't know how I missed that.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/12897#discussion_r1157909570
On Sat, 1 Apr 2023 00:44:55 GMT, Xin Liu wrote:
> Do you consider to perform the transformation in MacroExpand? Your prior
> changes have already removed NSR marks, ME/SR will consider 'ptn'.
Yes, I actually did. However, that makes the changes much more complicated.
I patched this method to r
On Sat, 25 Mar 2023 00:07:20 GMT, Vladimir Kozlov wrote:
>> I had considered that but decided not to do it to prevent adding a new IR
>> node. I'll give that a shot and update this thread with how it goes.
>
> It **will** complicate your DebugInfo code (packing/unpacking) information.
> But I t
On Fri, 24 Mar 2023 19:02:57 GMT, Vladimir Kozlov wrote:
>> Cesar Soares Lucas has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add support for SR'ing some inputs of merges used for field loads
>
> s
o tested with several applications and didn't see any
> failure. I also ran tests with "-ea -esa -Xbatch -Xcomp
> -XX:+UnlockExperimentalVMOptions -XX:-TieredCompilation -server
> -XX:+IgnoreUnrecognizedVMOptions -XX:+UnlockDiagnosticVMOptions
> -XX:+StressLCM -XX:+
o tested with several applications and didn't see any
> failure. I also ran tests with "-ea -esa -Xbatch -Xcomp
> -XX:+UnlockExperimentalVMOptions -XX:-TieredCompilation -server
> -XX:+IgnoreUnrecognizedVMOptions -XX:+UnlockDiagnosticVMOptions
> -XX:+StressLCM -XX:+
On Mon, 20 Mar 2023 19:23:34 GMT, Cesar Soares Lucas
wrote:
>> Can I please get reviews for this PR?
>>
>> The most common and frequent use of NonEscaping Phis merging object
>> allocations is for debugging information. The two graphs below show numbers
>&
On Fri, 24 Mar 2023 19:02:57 GMT, Vladimir Kozlov wrote:
>> Cesar Soares Lucas has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add support for SR'ing some inputs of merges used for field loads
>
> s
On Fri, 24 Mar 2023 19:53:52 GMT, Xin Liu wrote:
>> Cesar Soares Lucas has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add support for SR'ing some inputs of merges used for field loads
>
> src/hotsp
On Fri, 24 Mar 2023 19:06:18 GMT, Vladimir Kozlov wrote:
>> Cesar Soares Lucas has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add support for SR'ing some inputs of merges used for field loads
>
>
o tested with several applications and didn't see any
> failure. I also run tests with "-ea -esa -Xbatch -Xcomp
> -XX:+UnlockExperimentalVMOptions -XX:-TieredCompilation -server
> -XX:+IgnoreUnrecognizedVMOptions -XX:+UnlockDiagnosticVMOptions
> -XX:+StressLCM -XX:+
On Thu, 23 Feb 2023 18:15:35 GMT, Ahmed Muhsin wrote:
> This change will move the instantiation of BadPaddingException into the
> branch of the if statement where it is thrown. This will decrease the
> overhead of calling `unpadV15` and `unpadOAEP`. Please see the associated
> work item for p
tier 1-4 (Windows, Linux, and Mac) and didn't
> see regression that might be related. I also tested with several applications
> and didn't see any failure.
Cesar Soares Lucas has updated the pull request incrementally with one
additional commit since the last revision:
Fix
tier 1-4 (Windows, Linux, and Mac) and didn't
> see regression that might be related. I also tested with several applications
> and didn't see any failure.
Cesar Soares Lucas has updated the pull request with a new target base due to a
merge or a rebase. The pull request now conta
Can I please get reviews for this PR to add support for the rematerialization
of scalar-replaced objects that participate in allocation merges?
The most common and frequent use of NonEscaping Phis merging object allocations
is for debugging information. The two graphs below show numbers for Rena
On Thu, 23 Feb 2023 21:52:14 GMT, Ahmed Muhsin wrote:
> There is one failure in the pre-submit tests which I believe is unrelated to
> this change:
The same test is failing in at least one other PR:
https://github.com/openjdk/jdk/pull/12735/checks?check_run_id=11564672673
-
PR: h
73 matches
Mail list logo
