On Sat, 22 Apr 2023 01:42:41 GMT, Vladimir Ivanov <vliva...@openjdk.org> wrote:
> Does it make sense to introduce 3 different subclasses under ObjectValue to > clearly distinguish the scenarios? I think that's a good idea. I'll give it a shot. Thanks. > src/java.base/share/classes/java/security/AccessController.java line 786: > >> 784: // allocation merge Phi leading to it) might become NonEscaping >> and get >> 785: // scalar replaced. The call below enforces 'result' to always >> escape. >> 786: ensureMaterializedForStackWalk(result); > > Why don't you add the same call in the other `executePrivileged` overload? It > has the very same code shape. Totally missed that! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/12897#discussion_r1175906046 PR Review Comment: https://git.openjdk.org/jdk/pull/12897#discussion_r1175905602
