On Fri, 23 May 2025 00:03:08 GMT, Artur Barashev wrote:
>> The stateless session ticket is included in the ClientHello message, either
>> in the stateless_ticket extension (pre-TLS1.3), or in the pre_shared_key
>> extension (TLS1.3). With the current construction, the ticket is often the
>> la
On Fri, 23 May 2025 21:15:06 GMT, Artur Barashev wrote:
>> The stateless session ticket is included in the ClientHello message, either
>> in the stateless_ticket extension (pre-TLS1.3), or in the pre_shared_key
>> extension (TLS1.3). With the current construction, the ticket is often the
>> la
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 36 commits:
- Remove TlsExporterKeyingMaterial for now. Can add later if needed.
- Merge branch &
On Thu, 22 May 2025 19:23:22 GMT, Artur Barashev wrote:
>> The stateless session ticket is included in the ClientHello message, either
>> in the stateless_ticket extension (pre-TLS1.3), or in the pre_shared_key
>> extension (TLS1.3). With the current construction, the ticket is often the
>> la
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 34 commits:
- Merge branch 'master' into JDK-8341346
- Added PKCS11 testing
- Minor bug
-
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
Added PKCS11 testing
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24976/files
- new: https://
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
Minor bug
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24976/files
- new: https://git.openjdk.
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
Missed one change
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24976/files
- new: https://git.op
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 30 commits:
- Merge branch 'master' into JDK-8341346
- Private Codereview comment: Don'
On Mon, 19 May 2025 22:24:52 GMT, Jamil Nimeh wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> get*() no longer needed, backout error (oops!)
>
> src/java.base/share/classes/sun/se
On Mon, 19 May 2025 15:13:26 GMT, Hai-May Chao wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Updated copyright dates.
>
> src/java.base/share/classes/sun/security/ssl
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
get*() no longer needed, backout error (oops!)
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24
On Mon, 19 May 2025 15:06:26 GMT, Hai-May Chao wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Updated copyright dates.
>
> src/java.base/share/classes/sun/security/ssl/SSLSessio
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 27 commits:
- Merge branch 'master' into JDK-8341346
- Updated copyright dates.
- Merg
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
Updated copyright dates.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24976/files
- new: https://
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 25 commits:
- Merge branch 'master' into JDK-8341346
- Updated API to include SecretKey t
On Wed, 7 May 2025 16:21:23 GMT, Weijun Wang wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Updated to use the upcoming KDF (still in preview) + bits of JDK-8353578
>> for
On Thu, 8 May 2025 06:03:03 GMT, Bradford Wetmore wrote:
>> src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java line 1694:
>>
>>> 1692:
>>> 1693: // ...now the final expand.
>>> 1694: SecretKey key = h
On Fri, 16 May 2025 17:17:04 GMT, Bradford Wetmore wrote:
>> How about adding a `String alg` parameter to `exportKeyingMaterialKey` like
>> in the `KDF.deriveKey` API?
>
> As discussed with @seanjmullan / @wangweij , that is the direction I'll try.
> It's not
On Tue, 13 May 2025 13:07:18 GMT, Weijun Wang wrote:
>> It seems like it should be an exception, whatever you decide to do. The
>> caller is asking for the keying material data, and the provider cannot
>> fulfill that request, so I think explaining why it could not be done would
>> be best rep
On Thu, 15 May 2025 04:22:42 GMT, Bradford Wetmore wrote:
>> src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java line 1650:
>>
>>> 1648: emptyHash = md.digest();
>>> 1649: } catch (NoSuchAlgor
On Fri, 16 May 2025 16:50:22 GMT, Sean Mullan wrote:
>> Personally, I would like to give user the chance to specify the algorithm
>> themselves. A "TlsExporterKeyingMaterial" key will not be accepted by an AES
>> cipher. If you are not ready for this, I'd rather only provide the
>> `exportKeyi
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 23 commits:
- Merge branch 'master' into JDK-8341346
- Minor Codereview comments.
- Codereview
On Thu, 15 May 2025 20:42:39 GMT, Sean Mullan wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Merged with changes for JDK-8353578
>
> src/java.base/share/classes/javax/net/ssl/Ex
On Thu, 15 May 2025 12:51:16 GMT, Artur Barashev wrote:
>> Sure.
>
> Also, the parentheses are not needed around `context != null`
If there's one things to know about me, it's my liberal use of parens. I want
my code to match my intent.
I plan to update the "missing" parens.
-
P
On Tue, 13 May 2025 13:37:18 GMT, Weijun Wang wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Missed one review comment
>
> src/java.base/share/classes/sun/security/ssl
On Tue, 13 May 2025 13:25:21 GMT, Weijun Wang wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Missed one review comment
>
> src/java.base/share/classes/sun/security/ssl
On Tue, 13 May 2025 17:13:03 GMT, Artur Barashev wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Missed one review comment
>
> test/jdk/javax/net/ssl/ExtendedSSLSession/Expor
On Wed, 14 May 2025 20:13:36 GMT, Artur Barashev wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Merged with changes for JDK-8353578
>
> src/java.base/share/classes/sun/securit
On Tue, 13 May 2025 13:23:16 GMT, Weijun Wang wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Missed one review comment
>
> src/java.base/share/classes/sun/security/ssl
On Tue, 13 May 2025 21:44:21 GMT, Artur Barashev wrote:
>> Bradford Wetmore has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains 16 commits:
>>
>> - Merge branch 'master' into JDK-8341346
>>
On Wed, 14 May 2025 21:42:06 GMT, Bradford Wetmore wrote:
>> src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java line 329:
>>
>>> 327: */
>>> 328:
>>> 329: SSLSessionImpl(HandshakeContext hc, ByteBuffer buf) throws
>>> I
On Tue, 13 May 2025 12:16:37 GMT, Sean Mullan wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Missed one review comment
>
> src/java.base/share/classes/javax/net/ssl/ExtendedSSLSe
On Wed, 14 May 2025 19:17:15 GMT, Daniel Jeliński wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Merged with changes for JDK-8353578
>
> src/java.base/share/classes/sun/securit
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
Merged with changes for JDK-8353578
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 17 commits:
- Merge
- Merge branch 'master' into JDK-8341346
- Missed one review comment
-
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 16 commits:
- Merge branch 'master' into JDK-8341346
- Missed one review comment
- More c
On Mon, 12 May 2025 15:07:20 GMT, Sean Mullan wrote:
>> Bradford Wetmore has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains 13 commits:
>>
>> - Merge branch 'master' into JDK-8341346
>
On Mon, 12 May 2025 14:58:07 GMT, Sean Mullan wrote:
>> Bradford Wetmore has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains 13 commits:
>>
>> - Merge branch 'master' into JDK-8341346
>
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
Missed one review comment
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24976/files
- new: htt
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
More codereview comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24976/files
- new: https://
On Mon, 12 May 2025 15:02:31 GMT, Sean Mullan wrote:
>> Bradford Wetmore has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains 13 commits:
>>
>> - Merge branch 'master' into JDK-8341346
>
On Sat, 10 May 2025 13:48:05 GMT, Weijun Wang wrote:
>> Bradford Wetmore has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains 13 commits:
>>
>> - Merge branch 'master' into JDK-8341346
>
On Mon, 12 May 2025 14:45:36 GMT, Sean Mullan wrote:
>> Bradford Wetmore has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains 13 commits:
>>
>> - Merge branch 'master' into JDK-8341346
>
On Thu, 8 May 2025 21:19:10 GMT, Valerie Peng wrote:
>> This PR removes the internal JSSE HKDF impl and changes to use the KDF API
>> for the HKDF support from JCA/JCE providers.
>>
>> This is just code refactoring. Known-answer regression test for the internal
>> JSSE HKDF impl is removed as
On Thu, 8 May 2025 18:50:16 GMT, Valerie Peng wrote:
>> I just found that we had talked about this previously. What was your
>> reasoning for pulling it?
>>
>> Call me paranoid, but I'm not seeing where the [JDK 24
>> javadocs](https://docs.oracle.com/en/java/javase/24/docs/api/java.base/ja
On Sat, 10 May 2025 02:06:43 GMT, Bradford Wetmore wrote:
>> Me neither. However, given `HKDF-PRK` is not a standard algorithm and also
>> not recognized by the `SunPKCS11` provider, I changed it to `Generic`.
>> Existing `HKDF` impl in the `SunPKCS11` provider is quit
On Thu, 8 May 2025 18:44:27 GMT, Valerie Peng wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/DHKEM.java line 409:
>>
>>> 407: HKDFParameterSpec spec =
>>> 408:
>>> HKDFParameterSpec.ofExtract().addIKM(s).extractOnly();
>>> 409: return h
On Thu, 8 May 2025 18:04:58 GMT, Valerie Peng wrote:
>> Or in the meantime:
>>
>> } finally {
>> // Best effort
>> if (eae_prk instanceof SecretKeySpec s) {
>> SharedSecrets.getJavaxCryptoSpecAccess()
>> .clearSecretKeySpec(s);
>> } els
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 13 commits:
- Merge branch 'master' into JDK-8341346
- Adjustments made for JDK-8350830
- Merg
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
Rework to avoid PKCS11 data extraction problems, and enhanced input
verification and unit testing
-
On Wed, 7 May 2025 16:28:27 GMT, Weijun Wang wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Updated to use the upcoming KDF (still in preview) + bits of JDK-8353578
>> for
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
More Codereview comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24976/files
- new: https://
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
Updated to use the upcoming KDF (still in preview) + bits of JDK-8353578 for
compilation)
-
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
Add in the SharedSecrets SecretKeySpec clearing mechanism
-
Changes:
- all: https://git.openjdk.org/jdk/
On Fri, 25 Apr 2025 18:23:14 GMT, Valerie Peng wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/DHKEM.java line 260:
>>
>>> 258: if (eae_prk instanceof SecretKeySpec s) {
>>> 259: SharedSecrets.getJavaxCryptoSpecAccess()
>>> 260:
On Tue, 6 May 2025 04:58:41 GMT, Bradford Wetmore wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address review comments from Sean.
>
> src/java.base/share/classes/sun/security/
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains six additional
commits
On Thu, 1 May 2025 18:49:33 GMT, Valerie Peng wrote:
>> This PR removes the internal JSSE HKDF impl and changes to use the KDF API
>> for the HKDF support from JCA/JCE providers.
>>
>> This is just code refactoring. Known-answer regression test for the internal
>> JSSE HKDF impl is removed as
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
Codereview comments.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24976/files
- new: https://
On Thu, 1 May 2025 18:26:03 GMT, Artur Barashev wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Moved too fast
>
> test/jdk/javax/net/ssl/ExtendedSSLSession/TLSKeyExpo
On Thu, 1 May 2025 18:24:19 GMT, Artur Barashev wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Moved too fast
>
> test/jdk/javax/net/ssl/ExtendedSSLSession/TLSKeyExpo
On Thu, 1 May 2025 15:18:43 GMT, Weijun Wang wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Moved too fast
>
> src/java.base/share/classes/sun/security/ssl/SSLSessionI
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
Tweak API to be more KDF like in unextractable case.
-
Changes:
- all: https://git.openjdk.org/jdk/
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
Moved too fast
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24976/files
- new: https://git.op
On Tue, 29 Apr 2025 21:44:26 GMT, Valerie Peng wrote:
>> This PR removes the internal JSSE HKDF impl and changes to use the KDF API
>> for the HKDF support from JCA/JCE providers.
>>
>> This is just code refactoring. Known-answer regression test for the internal
>> JSSE HKDF impl is removed as
Adds the RFC 5705/8446 TLS Key Exporters API/implementation to JSSE/SunJSSE
respectively.
CSR is underway.
Tests include new unit tests for TLSv1-1.3. Will run tier1-2, plus the JCK API
(jck:api/java_security jck:api/javax_crypto jck:api/javax_net
jck:api/javax_security jck:api/org_ietf jck:a
On Thu, 24 Apr 2025 17:57:33 GMT, Artur Barashev wrote:
> I wasn't able to reproduce the issue. Most likely it was caused by unusually
> high CPU load in test environment. Increasing the server's "accept" call
> time-out value from 5 to 10 seconds to make the test more robust.
LGTM.
-
On Sat, 26 Apr 2025 04:54:10 GMT, Bradford Wetmore wrote:
> Minor error in the `SSLSessionImpl` comments as to how the class is
> "serialized. Fix the ordering.
>
> Do a little cleaning on the class on some obvious errors.
>
> No testing needed.
This pull request
Minor error in the `SSLSessionImpl` comments as to how the class is
"serialized. Fix the ordering.
Do a little cleaning on the class on some obvious errors.
No testing needed.
-
Commit messages:
- 8355637: SSLSessionImpl's "serialization" list documentation is incorrectly
ordered
On Thu, 17 Apr 2025 15:25:36 GMT, Sean Coffey wrote:
>> Breaking the parent JDK-8044609 JBS issue into sub tasks.
>>
>> This patch addresses the main issue which is that `javax.net.debug=ssl `
>> option is completely broken since TLSv1.3 support was introduced. This
>> patch should be easier
On Mon, 14 Apr 2025 18:42:40 GMT, Sean Coffey wrote:
>> Breaking the parent JDK-8044609 JBS issue into sub tasks.
>>
>> This patch addresses the main issue which is that `javax.net.debug=ssl `
>> option is completely broken since TLSv1.3 support was introduced. This
>> patch should be easier
On Thu, 6 Mar 2025 20:10:58 GMT, Sean Coffey wrote:
>> Breaking the parent JDK-8044609 JBS issue into sub tasks.
>>
>> This patch addresses the main issue which is that `javax.net.debug=ssl `
>> option is completely broken since TLSv1.3 support was introduced. This
>> patch should be easier
On Wed, 2 Apr 2025 21:43:19 GMT, Valerie Peng wrote:
> This PR removes the internal JSSE HKDF impl and changes to use the KDF API
> for the HKDF support from JCA/JCE providers.
>
> This is just code refactoring. Known-answer regression test for the internal
> JSSE HKDF impl is removed as the t
On Thu, 3 Apr 2025 00:51:44 GMT, Valerie Peng wrote:
>> src/java.base/share/classes/sun/security/ssl/KAKeyDerivation.java line 120:
>>
>>> 118: SecretKey earlySecret =
>>> hkdf.deriveKey("TlsEarlySecret",
>>> 119: HKDFParameterSpec.ofExtract().addSalt(zer
On Sat, 22 Feb 2025 02:25:42 GMT, Bradford Wetmore wrote:
> Typo: s/ficticious/fictitious/
>
> No unit test. Check that javadoc still builds.
This pull request has now been integrated.
Changeset: 990d40e9
Author: Bradford Wetmore
URL:
https://git.openjdk.org/j
Typo: s/ficticious/fictitious/
No unit test. Check that javadoc still builds.
-
Commit messages:
- 8350476: Fix typo introduced in JDK-8350147
Changes: https://git.openjdk.org/jdk/pull/23733/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23733&range=00
Issue: https://
On Tue, 18 Feb 2025 17:28:21 GMT, Sean Mullan wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Further codereview Comments from Weijun
>
> src/java.base/share/classes/javax/cry
On Sat, 15 Feb 2025 05:02:44 GMT, Bradford Wetmore wrote:
> The example code in the JEP was much clearer than that in the current `KEM`
> class. It's easier to keep the various nested classes straight, rather than
> using `var`s which require scrolling to see what the re
t;
> Generated/checked javadocs, but no regression/JCK tests is necessary.
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
Further codereview Comments from Weijun
-
Changes:
- all: https://git.openjdk.org/jdk/pull/
t;
> Generated/checked javadocs, but no regression/JCK tests is necessary.
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
Codereview Comments from Weijun
-
Changes:
- all: https://git.openjdk.org/jdk/pull/
On Sat, 15 Feb 2025 14:28:04 GMT, Weijun Wang wrote:
>> The example code in the JEP was much clearer than that in the current `KEM`
>> class. It's easier to keep the various nested classes straight, rather than
>> using `var`s which require scrolling to see what the return types are.
>>
>> A
On Sat, 15 Feb 2025 14:28:04 GMT, Weijun Wang wrote:
>> The example code in the JEP was much clearer than that in the current `KEM`
>> class. It's easier to keep the various nested classes straight, rather than
>> using `var`s which require scrolling to see what the return types are.
>>
>> A
The example code in the JEP was much clearer than that in the current `KEM`
class. It's easier to keep the various nested classes straight, rather than
using `var`s which require scrolling to see what the return types are.
Added/tweaked example for clarity.
Generated/checked javadocs, but no
On Thu, 13 Feb 2025 19:37:39 GMT, Daniel Jeliński wrote:
>> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsKeyMaterialGenerator.java
>> line 124:
>>
>>> 122: } else if (tlsVersion == 0x0303) {
>>> 123: mechanism = CKM_TLS12_KEY_AND_MAC_DERIVE;
>>> 124:
On Wed, 12 Feb 2025 10:02:55 GMT, Daniel Jeliński wrote:
> Please review this trivial fix that ensures that the mechanism always matches
> the parameter class type.
>
> I added a new test case that crashes without the fix, passes with the fix.
> Existing tier1-3 test cases continue to pass.
M
On Fri, 31 Jan 2025 01:45:47 GMT, Bradford Wetmore wrote:
> Update and clarify the sample code.
>
> Docs only, no additional testing other than verifying javadoc is correctly
> output.
This pull request has now been integrated.
Changeset: 88a84835
Author: Bradford
> Update and clarify the sample code.
>
> Docs only, no additional testing other than verifying javadoc is correctly
> output.
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
minor wording tweak
-
Chan
On Thu, 6 Feb 2025 19:10:04 GMT, Artur Barashev wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Codereview Comments
>
> src/java.base/share/classes/javax/net/ssl/SSLParam
On Wed, 5 Feb 2025 12:02:26 GMT, Daniel Fuchs wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Codereview Comments
>
> src/java.base/share/classes/javax/net/ssl/SSLParam
On Wed, 5 Feb 2025 12:03:52 GMT, Daniel Fuchs wrote:
>> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 672:
>>
>>> 670: * // Also, encode a two byte RFC 8701 GREASE ALPN value
>>> 671: * // e.g. 0x0A, 0x1A, 0x2A...0xFA
>>> 672: * String rfc8701Gr
Nothing I'm aware of.
We are focused on the JSSE TLS stack.
Brad
On 2/5/2025 12:00 AM, Baesken, Matthias wrote:
Hello, are there some plans or experiments to use Kernel TLS (KTLS)
in OpenJDK ?
https://www.kernel.org/doc/html/v6.6/networking/tls.html
Best regards, Matthias
On Tue, 4 Feb 2025 17:18:09 GMT, Daniel Fuchs wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Codereview Comments
>
> src/java.base/share/classes/javax/net/ssl/SSLParam
> Update and clarify the sample code.
>
> Docs only, no additional testing other than verifying javadoc is correctly
> output.
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
Codereview Comments
-
Chan
> Update and clarify the sample code.
>
> Docs only, no additional testing other than verifying javadoc is correctly
> output.
Bradford Wetmore has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
b
Update and clarify the sample code.
Docs only, no additional testing other than verifying javadoc is correctly
output.
-
Commit messages:
- 8349121: SSLParameters.setApplicationProtocols() ALPN example could be
clarified
Changes: https://git.openjdk.org/jdk/pull/23379/files
Web
On Tue, 10 Dec 2024 06:25:51 GMT, Bradford Wetmore wrote:
> SunJSSE has many of the IANA TLS handshake message types defined, but some
> are reserved and could be added for debugging output.
>
> https://www.iana.org/assignments/tls-parameters/tls-parameters.xhtml
>
> Test
> SunJSSE has many of the IANA TLS handshake message types defined, but some
> are reserved and could be added for debugging output.
>
> https://www.iana.org/assignments/tls-parameters/tls-parameters.xhtml
>
> Testing coverage: JDK compilation only.
Bradford Wetmore ha
> SunJSSE has many of the IANA TLS handshake message types defined, but some
> are reserved and could be added for debugging output.
>
> https://www.iana.org/assignments/tls-parameters/tls-parameters.xhtml
>
> Testing coverage: JDK compilation only.
Bradford Wetmore ha
SunJSSE has many of the IANA TLS handshake message types defined, but some are
reserved and could be added for debugging output.
https://www.iana.org/assignments/tls-parameters/tls-parameters.xhtml
Testing coverage: JDK compilation only.
-
Commit messages:
- Updated copyright
-
1 - 100 of 230 matches
Mail list logo
