Re: RFR: 8348732: SunJCE and SunPKCS11 have different PBE key encodings

2025-03-24 Thread Valerie Peng
On Wed, 19 Mar 2025 17:39:39 GMT, Francisco Ferrari Bihurriet wrote: >> test/jdk/sun/security/pkcs11/Mac/PBAMac.java line 1: >> >>> 1: /* >> >> I suggest changing this test's password to contain non-ASCII characters, so >> we have a better coverage in both _SunJCE_ (when checking the assertio

Re: RFR: 8348732: SunJCE and SunPKCS11 have different PBE key encodings [v2]

2025-03-24 Thread Valerie Peng
> As part of [https://bugs.openjdk.org/browse/JDK-8301553](JDK-8301553), > SunPKCS11 provider added support for PBE SecretKeyFactories for > `HmacPBESHAxxx` and `PBEWithHmacSHAxxxAndAES_yyy`. These impls produce keys > whose encoding contains the PBKDF2 derived bytes. Given that SunJCE provider

Re: RFR: 8348732: SunJCE and SunPKCS11 have different PBE key encodings

2025-03-24 Thread Valerie Peng
On Tue, 18 Mar 2025 23:35:45 GMT, Francisco Ferrari Bihurriet wrote: > Hi @valeriepeng, I found code assuming `com.sun.crypto.provider.PBEKey` > contains only ASCII, please find my suggestions in the review comments. I > also added a suggestion for the tests, in order to increase the coverage

Re: RFR: 8351034: Add AVX-512 intrinsics for ML-DSA [v10]

2025-03-24 Thread Volodymyr Paprotski
On Sat, 22 Mar 2025 16:45:31 GMT, Volodymyr Paprotski wrote: >> Ferenc Rakoczi has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix windows build > > src/hotspot/cpu/x86/stubGenerator_x86_64_dilithium.cpp line 216: > >> 214: // Zmm8-Zmm

Re: RFR: 8349583: Add mechanism to disable signature schemes based on their TLS scope [v19]

2025-03-24 Thread Artur Barashev
> Currently when a signature scheme constraint is specified with > "jdk.tls.disabledAlgorithms" property we don't differentiate between > signatures used to sign a TLS handshake exchange and the signatures used in > TLS certificates: > https://datatracker.ietf.org/doc/html/rfc8446#section-4.2.3

Re: RFR: 8350459: MontgomeryIntegerPolynomialP256 multiply intrinsic with AVX2 on x86_64 [v4]

2025-03-24 Thread Volodymyr Paprotski
On Thu, 20 Mar 2025 17:34:53 GMT, Anthony Scarpino wrote: >> I used it this testcase for development (and figured I should also check it >> in..) so what might be 'obvious' to me, might not be for anyone else? >> >> Typically, when a test failed, I grabbed the SEED from the test output, >> re

Re: RFR: 8350459: MontgomeryIntegerPolynomialP256 multiply intrinsic with AVX2 on x86_64 [v7]

2025-03-24 Thread Volodymyr Paprotski
> Add AVX2 montgomery multiplication intrinsic. (About 60-80% gain) > > Also add reduction to existing AVX512 multiplication (this was left-over from > https://github.com/openjdk/jdk/pull/19893 where a quick fix was required). > This is mostly for cleanup, but there is about 1-2% gain. > > Befo

Re: RFR: 8351034: Add AVX-512 intrinsics for ML-DSA [v11]

2025-03-24 Thread Volodymyr Paprotski
On Sat, 22 Mar 2025 20:02:31 GMT, Ferenc Rakoczi wrote: >> By using the AVX-512 vector registers the speed of the computation of the >> ML-DSA algorithms (key generation, document signing, signature verification) >> can be approximately doubled. > > Ferenc Rakoczi has updated the pull request i

Re: RFR: 8351034: Add AVX-512 intrinsics for ML-DSA [v11]

2025-03-24 Thread Volodymyr Paprotski
On Sat, 22 Mar 2025 20:38:19 GMT, Volodymyr Paprotski wrote: >> Ferenc Rakoczi has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Further readability improvements. >> - Added asserts for array sizes > > src/hotspot/cpu/x86/stubGenerator

Re: RFR: 8352719: Add an equals sign to the modules statement

2025-03-24 Thread Sean Mullan
On Mon, 24 Mar 2025 12:30:57 GMT, Leo Korinth wrote: > krb5/auto/TEST.properties: add an equals sign to the modules statement (this > is the only `TEST.properties` file that uses this undocumented feature) . > > compare: > > find -name "TEST.properties" | xargs grep 'modules.*java' > find -na

Re: RFR: 8352719: Add an equals sign to the modules statement

2025-03-24 Thread Weijun Wang
On Mon, 24 Mar 2025 12:30:57 GMT, Leo Korinth wrote: > krb5/auto/TEST.properties: add an equals sign to the modules statement (this > is the only `TEST.properties` file that uses this undocumented feature) . > > compare: > > find -name "TEST.properties" | xargs grep 'modules.*java' > find -na

RFR: 8350705: [JMH] test security.SSLHandshake failed for 2 threads configuration

2025-03-24 Thread Daniel JeliƄski
Update the SSLHandshake benchmark to enable running in multiple threads. This PR changes the scope of the state from per-benchmark to per-thread. The server SSLContext is still shared across all threads to simulate the scenario where multiple clients try to connect to the same server at the same

RFR: 8352719: Add an equals sign to the modules statement

2025-03-24 Thread Leo Korinth
krb5/auto/TEST.properties: add an equals sign to the modules statement (this is the only `TEST.properties` file that uses this undocumented feature) . compare: find -name "TEST.properties" | xargs grep 'modules.*java' | find -name "TEST.properties" | xargs grep 'modules.*java' | grep -v = -