Re: RFR: 8348561: Add aarch64 intrinsics for ML-DSA [v8]

2025-02-27 Thread Ferenc Rakoczi
> By using the aarch64 vector registers the speed of the computation of the > ML-DSA algorithms (key generation, document signing, signature verification) > can be approximately doubled. Ferenc Rakoczi has updated the pull request with a new target base due to a merge or a rebase. The pull requ

Withdrawn: 8341775: Duplicate manifest files are removed by jarsigner after signing

2025-02-27 Thread duke
On Mon, 18 Nov 2024 22:40:40 GMT, Kevin Driver wrote: > JDK-8341775: In the case where there is a *single* META-INF directory but > potentially *multiple* manifest files of different cases, print a warning > before selecting the first one and ignoring the rest (the current behavior > should be

Re: RFR: 8350582: Correct the parsing of the ssl value in javax.net.debug

2025-02-27 Thread Mikhail Yankelevich
On Thu, 27 Feb 2025 20:18:38 GMT, Sean Coffey wrote: > Thanks for the feedback @myankelev - changes incorporated Thanks, LGTM - PR Comment: https://git.openjdk.org/jdk/pull/23781#issuecomment-2689188485

Re: RFR: 8349583: Add mechanism to disable signature schemes based on their TLS scope [v10]

2025-02-27 Thread Artur Barashev
> Currently when a signature scheme constraint is specified with > "jdk.tls.disabledAlgorithms" property we don't differentiate between > signatures used to sign a TLS handshake exchange and the signatures used in > TLS certificates: > https://datatracker.ietf.org/doc/html/rfc8446#section-4.2.3

Re: RFR: 8350582: Correct the parsing of the ssl value in javax.net.debug

2025-02-27 Thread Sean Coffey
On Tue, 25 Feb 2025 16:20:59 GMT, Sean Coffey wrote: > Breaking the parent JDK-8044609 JBS issue into sub tasks. > > This patch addresses the main issue which is that `javax.net.debug=ssl ` > option is completely broken since TLSv1.3 support was introduced. This patch > should be easier for

Re: RFR: 8350582: Correct the parsing of the ssl value in javax.net.debug [v2]

2025-02-27 Thread Sean Coffey
> Breaking the parent JDK-8044609 JBS issue into sub tasks. > > This patch addresses the main issue which is that `javax.net.debug=ssl ` > option is completely broken since TLSv1.3 support was introduced. This patch > should be easier for backporting also. > > Wider corrections can be followe

Re: 8245545: TLS_RSA roadmap

2025-02-27 Thread Sean Mullan
Hi Bernd, On 2/27/25 11:24 AM, Bernd wrote: Hello, Just noticed you plan to disable TLS_RSA ciphers in 2026. I wonder there are some Legacy entries which are both disabled and marked as Legacy, but some are only disabled. Is there a plan to this? I would expect TLS_RSA to be more likely to

Re: RFR: 8349583: Add mechanism to disable signature schemes based on their TLS scope [v9]

2025-02-27 Thread Artur Barashev
> Currently when a signature scheme constraint is specified with > "jdk.tls.disabledAlgorithms" property we don't differentiate between > signatures used to sign a TLS handshake exchange and the signatures used in > TLS certificates: > https://datatracker.ietf.org/doc/html/rfc8446#section-4.2.3

Re: RFR: 8349583: Add mechanism to disable signature schemes based on their TLS scope [v8]

2025-02-27 Thread Artur Barashev
> Currently when a signature scheme constraint is specified with > "jdk.tls.disabledAlgorithms" property we don't differentiate between > signatures used to sign a TLS handshake exchange and the signatures used in > TLS certificates: > https://datatracker.ietf.org/doc/html/rfc8446#section-4.2.3

Re: RFR: 8350459: MontgomeryIntegerPolynomialP256 multiply intrinsic with AVX2 on x86_64

2025-02-27 Thread Sandhya Viswanathan
On Thu, 20 Feb 2025 21:49:42 GMT, Volodymyr Paprotski wrote: > Add AVX2 montgomery multiplication intrinsic. (About 60-80% gain) > > Also add reduction to existing AVX512 multiplication (this was left-over from > https://github.com/openjdk/jdk/pull/19893 where a quick fix was required). > Thi

Re: RFR: 8349348: Refactor ClassLoaderDeadlock.sh and Deadlock.sh to run fully in java [v2]

2025-02-27 Thread Mikhail Yankelevich
> Refactor the following to run fully in java: > test/java/security//Security/ClassLoaderDeadlock/ClassLoaderDeadlock.sh > test/java/security//Security/ClassLoaderDeadlock/Deadlock.sh Mikhail Yankelevich has updated the pull request with a new target base due to a merge or a rebase. The increment

Re: RFR: 8336289: Obliterate most references to _snprintf in the Windows JDK [v5]

2025-02-27 Thread Kevin Walls
On Sat, 24 Aug 2024 05:12:42 GMT, Julian Waters wrote: >> snprintf has been available for all officially and unofficially supported >> compilers for Windows, Visual Studio since version 2015 and gcc since, well, >> forever. snprintf is conforming to C99 since the start when compiling using >>

Re: RFR: 8336289: Obliterate most references to _snprintf in the Windows JDK [v5]

2025-02-27 Thread Julian Waters
On Sat, 24 Aug 2024 05:12:42 GMT, Julian Waters wrote: >> snprintf has been available for all officially and unofficially supported >> compilers for Windows, Visual Studio since version 2015 and gcc since, well, >> forever. snprintf is conforming to C99 since the start when compiling using >>

Re: RFR: 8348561: Add aarch64 intrinsics for ML-DSA [v5]

2025-02-27 Thread Ferenc Rakoczi
On Thu, 27 Feb 2025 10:15:48 GMT, Andrew Haley wrote: >> OK, so GNU as is more forgiving than Apple as... > > Did my patch to aarch64-asmtest.py solve the problem? I haven't tried, I just used GNU as. - PR Review Comment: https://git.openjdk.org/jdk/pull/23300#discussion_r197397035

Re: RFR: 8336289: Obliterate most references to _snprintf in the Windows JDK [v5]

2025-02-27 Thread Kevin Walls
On Sat, 24 Aug 2024 05:12:42 GMT, Julian Waters wrote: >> snprintf has been available for all officially and unofficially supported >> compilers for Windows, Visual Studio since version 2015 and gcc since, well, >> forever. snprintf is conforming to C99 since the start when compiling using >>

Re: RFR: 8349348: Refactor ClassLoaderDeadlock.sh and Deadlock.sh to run fully in java

2025-02-27 Thread Jaikiran Pai
On Tue, 4 Feb 2025 14:08:05 GMT, Mikhail Yankelevich wrote: > Refactor the following to run fully in java: > test/java/security//Security/ClassLoaderDeadlock/ClassLoaderDeadlock.sh > test/java/security//Security/ClassLoaderDeadlock/Deadlock.sh Hello Mikhail, since we are updating these tests to

8245545: TLS_RSA roadmap

2025-02-27 Thread Bernd
Hello,Just noticed you plan to disable TLS_RSA ciphers in 2026. I wonder there are some Legacy entries which are both disabled and marked as Legacy, but some are only disabled.Is there a plan to this? I would expect TLS_RSA to be more likely to be re-enabled, so maybe it should be delivered on the

Re: RFR: 8349348: Refactor ClassLoaderDeadlock.sh and Deadlock.sh to run fully in java

2025-02-27 Thread Mikhail Yankelevich
On Thu, 27 Feb 2025 15:37:47 GMT, Matthew Donovan wrote: >> Refactor the following to run fully in java: >> test/java/security//Security/ClassLoaderDeadlock/ClassLoaderDeadlock.sh >> test/java/security//Security/ClassLoaderDeadlock/Deadlock.sh > > test/jdk/java/security/Security/ClassLoaderDeadlo

Re: RFR: 8349348: Refactor ClassLoaderDeadlock.sh and Deadlock.sh to run fully in java

2025-02-27 Thread Matthew Donovan
On Tue, 4 Feb 2025 14:08:05 GMT, Mikhail Yankelevich wrote: > Refactor the following to run fully in java: > test/java/security//Security/ClassLoaderDeadlock/ClassLoaderDeadlock.sh > test/java/security//Security/ClassLoaderDeadlock/Deadlock.sh test/jdk/java/security/Security/ClassLoaderDeadlock/

Re: RFR: 8349583: Add mechanism to disable signature schemes based on their TLS scope [v7]

2025-02-27 Thread Sean Mullan
On Wed, 26 Feb 2025 02:03:25 GMT, Artur Barashev wrote: >> Currently when a signature scheme constraint is specified with >> "jdk.tls.disabledAlgorithms" property we don't differentiate between >> signatures used to sign a TLS handshake exchange and the signatures used in >> TLS certificates:

Re: RFR: 8348561: Add aarch64 intrinsics for ML-DSA [v5]

2025-02-27 Thread Andrew Haley
On Tue, 25 Feb 2025 15:58:18 GMT, Ferenc Rakoczi wrote: >> Aha! >> >> >> aph@Andrews-MacBook-Pro ~ % as t.s >> t.s:1:19: error: expected 'sxtx' 'uxtx' or 'lsl' with optional integer in >> range [0, 4] >> sub x1, x10, x23, sxth #2 >> ^ >> aph@Andrews-MacBook-Pro ~ % as --ve

Re: RFR: 8350582: Correct the parsing of the ssl value in javax.net.debug

2025-02-27 Thread Mikhail Yankelevich
On Tue, 25 Feb 2025 16:20:59 GMT, Sean Coffey wrote: > Breaking the parent JDK-8044609 JBS issue into sub tasks. > > This patch addresses the main issue which is that `javax.net.debug=ssl ` > option is completely broken since TLSv1.3 support was introduced. This patch > should be easier for

Re: RFR: 8348561: Add aarch64 intrinsics for ML-DSA [v7]

2025-02-27 Thread Andrew Dinn
On Wed, 26 Feb 2025 14:18:14 GMT, Ferenc Rakoczi wrote: >> By using the aarch64 vector registers the speed of the computation of the >> ML-DSA algorithms (key generation, document signing, signature verification) >> can be approximately doubled. > > Ferenc Rakoczi has updated the pull request i

Re: RFR: 8348561: Add aarch64 intrinsics for ML-DSA [v5]

2025-02-27 Thread Andrew Dinn
On Fri, 21 Feb 2025 10:23:37 GMT, Ferenc Rakoczi wrote: >> Hi. Here is the test result of our CI. >> >> ### copyright year >> >> the following files should update the copyright year to 2025. >> >> >> src/hotspot/cpu/aarch64/assembler_aarch64.hpp >> src/hotspot/cpu/aarch64/stubRoutines_aarch64