Re: RFR: 8346050: Update BuildTestLib.gmk to build whole testlibrary [v2]

2025-02-10 Thread Magnus Ihse Bursie
On Sat, 8 Feb 2025 05:01:03 GMT, Leonid Mesnik wrote: >> The fix add remaining classes to the testlibrary jar and fix some warnings >> in security-related classes. > > Leonid Mesnik has updated the pull request incrementally with one additional > commit since the last revision: > > Update ma

Re: RFR: 8348561: Add aarch64 intrinsics for ML-DSA [v5]

2025-02-10 Thread Mark Powers
On Thu, 6 Feb 2025 18:47:54 GMT, Ferenc Rakoczi wrote: >> By using the aarch64 vector registers the speed of the computation of the >> ML-DSA algorithms (key generation, document signing, signature verification) >> can be approximately doubled. > > Ferenc Rakoczi has updated the pull request in

Re: RFR: 8349534: Refactor jdk/sun/security/krb5/runNameEquals.sh to java test

2025-02-10 Thread Matthew Donovan
On Mon, 10 Feb 2025 17:50:21 GMT, Mikhail Yankelevich wrote: > Refactored the runNameEquals.sh to java test test/jdk/sun/security/krb5/Krb5NameEquals.java line 94: > 92: > 93: if (installationIssue) { > 94: System.out.println(""" You should probably

Integrated: 8349501: Relocate supporting classes in security/testlibrary to test/lib/jdk tree

2025-02-10 Thread Jamil Nimeh
On Sat, 8 Feb 2025 16:23:59 GMT, Jamil Nimeh wrote: > This takes a few test classes and moves them away from their current location > in `test/jdk/java/security/testlibrary` to `test/lib/jdk/test/lib/security`, > grouping them together with many other existing test utility classes. It > also

RFR: 8349534: Refactor jdk/sun/security/krb5/runNameEquals.sh to java test

2025-02-10 Thread Mikhail Yankelevich
Refactored the runNameEquals.sh to java test - Commit messages: - 8349534: Refactor jdk/sun/security/krb5/runNameEquals.sh to java test Changes: https://git.openjdk.org/jdk/pull/23542/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23542&range=00 Issue: https://bugs.openj

Re: RFR: 8349501: Relocate supporting classes in security/testlibrary to test/lib/jdk tree [v2]

2025-02-10 Thread Rajan Halade
On Sun, 9 Feb 2025 05:32:10 GMT, Jamil Nimeh wrote: >> This takes a few test classes and moves them away from their current >> location in `test/jdk/java/security/testlibrary` to >> `test/lib/jdk/test/lib/security`, grouping them together with many other >> existing test utility classes. It a

Re: RFR: 8349400: Improve startup speed via eliminating nested classes

2025-02-10 Thread Roger Riggs
On Sat, 8 Feb 2025 08:44:04 GMT, Shaojin Wen wrote: >> You could define the static field on another class, like SecurityConstants, >> and then use it in the enum constructor. > > Creating a new empty string array every time is the original behavior, which > has nothing to do with the purpose of

Re: RFR: 8346094: Harden X509CertImpl.getExtensionValue for NPE cases [v2]

2025-02-10 Thread Weijun Wang
On Mon, 10 Feb 2025 06:46:45 GMT, Konanki Sreenath wrote: >> Earlier code will trigger NPE if the certificate does not contain the >> extensions or if the requested extensions does not exist. The better >> approach for hardening **getExtensionValue** here is to to check for NULL >> explicitly