A lot of jfr tests are very specific. Currently all of them are marked with jfr
keyword and excluded when VM flags are set.
It makes sense to mark them with @requires to be complaint with all
other openjdk tests.
The next step is to review tests and remove vm.flagless from tests that should
b
On Fri, 10 Jan 2025 19:22:52 GMT, Koushik Muthukrishnan Thirupattur
wrote:
> **Description:**
> [JDK-8305406](https://bugs.openjdk.org/browse/JDK-8305406) added the `@spec`
> tags to multiple places where there were links to
> "{@docRoot}/../specs/security/standard-names.html". However, it has
On Thu, 23 Jan 2025 22:13:09 GMT, Sean Mullan wrote:
>> done
>
> I think you added the fields for the root certificates, and not these
> certificates. Also, these are not root certificates, so I would remove "Root
> Certificate".
>
> You can use `keytool -printcert -file ...` and just include
On Thu, 23 Jan 2025 20:20:04 GMT, Mark Powers wrote:
>> test/jdk/sun/security/ssl/X509TrustManagerImpl/distrust/chains/camerfirma/camerfirmachambersca-chain.pem
>> line 1:
>>
>>> 1: -BEGIN CERTIFICATE-
>>
>> Can you put some basic information about the certs at the top of these
>> fil
**Description:**
[JDK-8305406](https://bugs.openjdk.org/browse/JDK-8305406) added the `@spec`
tags to multiple places where there were links to
"{@docRoot}/../specs/security/standard-names.html". However, it has not covered
those cases where a link is an anchor inside this document. This PR will
On Wed, 8 Jan 2025 16:50:01 GMT, Martin Balao wrote:
>> In addition to the goals, scope, motivation, specification and requirement
>> notes in [JDK-8315487](https://bugs.openjdk.org/browse/JDK-8315487), we
>> would like to describe the most relevant decisions taken during the
>> implementation
On Mon, 20 Jan 2025 16:06:56 GMT, Sean Coffey wrote:
> Correct a corner case where null should be returned if a service from the
> legacyMap is marked invalid.
>
> New test case added.
Looks good to me. Thanks~
-
Marked as reviewed by valeriep (Reviewer).
PR Review: https://git
Removed algorithm-specific information from `KeyPairGenerator` class
description and instead linked out to the Sun Provider documentation
-
Commit messages:
- Updated language on KeyPairGenerator class description
Changes: https://git.openjdk.org/jdk/pull/23280/files
Webrev: http
On Thu, 23 Jan 2025 17:56:06 GMT, Sean Mullan wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> comments from Sean
>
> test/jdk/sun/security/ssl/X509TrustManagerImpl/distrust/Camerfirma.java line
> 58:
>
>> 56:
>>
> [JDK-8346587](https://bugs.openjdk.org/browse/JDK-8346587)
Mark Powers has updated the pull request incrementally with one additional
commit since the last revision:
comments from Sean
-
Changes:
- all: https://git.openjdk.org/jdk/pull/22985/files
- new: https://git.openjdk
On Thu, 23 Jan 2025 18:08:18 GMT, Mikhail Yankelevich wrote:
> The following test files were deleted and has been removed from the problem
> list:
> - sun/security/provider/PolicyFile/GrantAllPermToExtWhenNoPolicy.java
> - sun/security/provider/PolicyParser/PrincipalExpansionError.java
This pul
On Thu, 23 Jan 2025 18:08:18 GMT, Mikhail Yankelevich wrote:
> The following test files were deleted and has been removed from the problem
> list:
> - sun/security/provider/PolicyFile/GrantAllPermToExtWhenNoPolicy.java
> - sun/security/provider/PolicyParser/PrincipalExpansionError.java
Marked a
On Thu, 23 Jan 2025 18:08:18 GMT, Mikhail Yankelevich wrote:
> The following test files were deleted and has been removed from the problem
> list:
> - sun/security/provider/PolicyFile/GrantAllPermToExtWhenNoPolicy.java
> - sun/security/provider/PolicyParser/PrincipalExpansionError.java
@myankel
The following test files were deleted and has been removed from the problem
list:
- sun/security/provider/PolicyFile/GrantAllPermToExtWhenNoPolicy.java
- sun/security/provider/PolicyParser/PrincipalExpansionError.java
-
Commit messages:
- JDK-8348406: Remove tests GrantAllPermToExtW
On Wed, 8 Jan 2025 23:27:34 GMT, Mark Powers wrote:
> [JDK-8346587](https://bugs.openjdk.org/browse/JDK-8346587)
test/jdk/sun/security/ssl/X509TrustManagerImpl/distrust/Camerfirma.java line 58:
> 56:
> 57: public static void main(String[] args) throws Exception {
> 58: String prop
On Wed, 22 Jan 2025 16:59:04 GMT, Aleksey Shipilev wrote:
> `Reference.waitForReferenceProcessing` is in internal API, which should go
> away with [JDK-8344332](https://bugs.openjdk.org/browse/JDK-8344332). There
> is single use of that internal API in the tests, the last use of which was
> re
On Wed, 22 Jan 2025 16:59:04 GMT, Aleksey Shipilev wrote:
> `Reference.waitForReferenceProcessing` is in internal API, which should go
> away with [JDK-8344332](https://bugs.openjdk.org/browse/JDK-8344332). There
> is single use of that internal API in the tests, the last use of which was
> re
On Thu, 23 Jan 2025 14:49:28 GMT, Aleksey Shipilev wrote:
> I think I need another review for integration?
Alan's review should be sufficient I think. The bug should have a `noreg-self`
label.
-
PR Comment: https://git.openjdk.org/jdk/pull/23239#issuecomment-2610341728
On Wed, 22 Jan 2025 20:35:22 GMT, Phil Race wrote:
>> Only the `writeExternal` method is required to have a `@serialData` tag in
>> order to keep javadoc running with `-serialwarn` option from complaining. I
>> guess the thinking is that the `readExternal` logic can be derived from that.
>>
>>
On Thu, 23 Jan 2025 11:59:06 GMT, Mikhail Yankelevich wrote:
>> * Changed security/auth/callback/TextCallbackHandler/Password.java to run
>> with JTReg, now the dialog box with instructions will appear as a ui
>
> Mikhail Yankelevich has updated the pull request incrementally with one
> additio
[JDK-8346587](https://bugs.openjdk.org/browse/JDK-8346587)
-
Commit messages:
- first iteration
Changes: https://git.openjdk.org/jdk/pull/22985/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22985&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8346587
Stats: 342 l
On Wed, 22 Jan 2025 16:59:04 GMT, Aleksey Shipilev wrote:
> `Reference.waitForReferenceProcessing` is in internal API, which should go
> away with [JDK-8344332](https://bugs.openjdk.org/browse/JDK-8344332). There
> is single use of that internal API in the tests, the last use of which was
> re
> * Changed security/auth/callback/TextCallbackHandler/Password.java to run
> with JTReg, now the dialog box with instructions will appear as a ui
Mikhail Yankelevich has updated the pull request incrementally with one
additional commit since the last revision:
typos
-
Changes:
On Thu, 23 Jan 2025 10:54:23 GMT, Alan Bateman wrote:
> So the test wasn't actually calling Reference::waitForReferenceProcessing, do
> I have this right? In that case, this PR looks fine.
Yup. The last use of `Reference::waitForReferenceProcessing` was removed by
[JDK-8080225](https://bugs.op
On Wed, 22 Jan 2025 16:59:04 GMT, Aleksey Shipilev wrote:
> `Reference.waitForReferenceProcessing` is in internal API, which should go
> away with [JDK-8344332](https://bugs.openjdk.org/browse/JDK-8344332). There
> is single use of that internal API in the tests, the last use of which was
> re
25 matches
Mail list logo
