Re: RFR: 8328119: Support HKDF in SunPKCS11 (Preview) [v10]

2025-01-10 Thread Martin Balao
On Sat, 11 Jan 2025 01:44:06 GMT, Valerie Peng wrote: >> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11HKDF.java line >> 230: >> >>> 228: } >>> 229: >>> 230: private abstract sealed class KeyMaterialMerger permits >> >> Hmm, instead of all these different sub-classes wh

Re: RFR: 8346468: SM cleanup of common test library [v4]

2025-01-10 Thread Jaikiran Pai
On Fri, 10 Jan 2025 17:10:03 GMT, Roger Riggs wrote: >> SM Cleanup of common test library test/lib/...: >> >> Remove unnecessary catches of SecurityException >> Remove AccessController and doPrivileged from SimpleSSLContext and >> ProcessTools. > > Roger Riggs has updated the pull request incre

Re: RFR: 8328119: Support HKDF in SunPKCS11 (Preview) [v10]

2025-01-10 Thread Valerie Peng
On Sat, 11 Jan 2025 01:40:39 GMT, Valerie Peng wrote: >> Martin Balao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Renaming of P11KDF fix. >> >> Co-authored-by: Martin Balao Alonso >> Co-authored-by: Francisco Ferrari Bihurrie

Re: RFR: 8328119: Support HKDF in SunPKCS11 (Preview) [v10]

2025-01-10 Thread Valerie Peng
On Wed, 8 Jan 2025 02:31:38 GMT, Martin Balao wrote: >> We would like to propose an implementation of the HKDF algorithms for >> SunPKCS11, aligned with the KDF API proposed for JDK 24 (see [JEP 478: Key >> Derivation Function API >> (Preview)](https://bugs.openjdk.org/browse/JDK-8189808)). >>

Re: On 8346720: Support Generic keys in SunPKCS11 SecretKeyFactory

2025-01-10 Thread Wei-Jun Wang
I’ve added the SecurityKeyFactort.Generic part into https://bugs.openjdk.org/browse/JDK-8346997. You can remove yours. Thanks, Weijun On Jan 9, 2025, at 10:06, Martin Balao wrote: If it's more clear or easier for you, we can do it. I've re-opened JDK-8346720. We will reference JDK-8346720 in

Re: RFR: 8342062: Reformat keytool and jarsigner output for keys with a named parameter set [v6]

2025-01-10 Thread Sean Mullan
On Fri, 10 Jan 2025 16:13:14 GMT, Weijun Wang wrote: >> Traditionally, an asymmetric key has a key size. The size is displayed by >> `keytool` and `jarsigner`, both in informational output and weak-key >> warnings. However, for the recently added ML-DSA algorithm, key size is not >> defined. >

Re: RFR: 8346736: Java Security Standard Algorithm Names spec should include key algorithm names [v3]

2025-01-10 Thread Hai-May Chao
On Wed, 8 Jan 2025 19:36:31 GMT, Weijun Wang wrote: >> Add links to the new Key Algorithms section in the Java Security Standard >> Algorithm Names Specification. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > address more

Re: RFR: 8344316: Add extra line in security/auth/callback/TextCallbackHandler/Password.java to make clear it is not a JTReg test [v3]

2025-01-10 Thread Shivangi Gupta
On Fri, 10 Jan 2025 12:10:40 GMT, Mikhail Yankelevich wrote: >> I think it is good to put. As this the manual test and ran by IMT. They are >> raising issue if the test is failing and actually not going inside the test >> and checking the steps how to run. As they run all the test using jtreg t

Re: RFR: 8346468: SM cleanup of common test library [v4]

2025-01-10 Thread Roger Riggs
> SM Cleanup of common test library test/lib/...: > > Remove unnecessary catches of SecurityException > Remove AccessController and doPrivileged from SimpleSSLContext and > ProcessTools. Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8342062: Reformat keytool and jarsigner output for keys with a named parameter set [v6]

2025-01-10 Thread Weijun Wang
> Traditionally, an asymmetric key has a key size. The size is displayed by > `keytool` and `jarsigner`, both in informational output and weak-key > warnings. However, for the recently added ML-DSA algorithm, key size is not > defined. > > Thus when an ML-DSA key is created, `keytool` shows >

Re: RFR: 8342062: Reformat keytool and jarsigner output for keys with a named parameter set [v5]

2025-01-10 Thread Weijun Wang
On Fri, 10 Jan 2025 14:36:11 GMT, Sean Mullan wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> one missing year change > > src/java.base/share/classes/sun/security/tools/keytool/Main.java line 2068: > >> 2066:

Re: RFR: 8346468: SM cleanup of common test library [v3]

2025-01-10 Thread Jaikiran Pai
On Wed, 18 Dec 2024 21:07:14 GMT, Roger Riggs wrote: >> SM Cleanup of common test library test/lib/...: >> >> Remove unnecessary catches of SecurityException >> Remove AccessController and doPrivileged from SimpleSSLContext and >> ProcessTools. > > Roger Riggs has updated the pull request incre

Re: RFR: 8346468: SM cleanup of common test library [v3]

2025-01-10 Thread Jaikiran Pai
On Wed, 18 Dec 2024 21:07:14 GMT, Roger Riggs wrote: >> SM Cleanup of common test library test/lib/...: >> >> Remove unnecessary catches of SecurityException >> Remove AccessController and doPrivileged from SimpleSSLContext and >> ProcessTools. > > Roger Riggs has updated the pull request incre

Re: RFR: 8342062: Reformat keytool and jarsigner output for keys with a named parameter set [v5]

2025-01-10 Thread Sean Mullan
On Fri, 10 Jan 2025 01:01:28 GMT, Weijun Wang wrote: >> Traditionally, an asymmetric key has a key size. The size is displayed by >> `keytool` and `jarsigner`, both in informational output and weak-key >> warnings. However, for the recently added ML-DSA algorithm, key size is not >> defined. >

Re: RFR: 8189441: Define algorithm names for keys derived from KeyAgreement [v15]

2025-01-10 Thread Sean Mullan
On Thu, 9 Jan 2025 19:06:26 GMT, Weijun Wang wrote: >> Allow `Generic` as an algorithm in the `KeyAgreement::generateSecret(alg)` >> method. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > "secret-key" to "secret key" Mark

Re: RFR: 8346736: Java Security Standard Algorithm Names spec should include key algorithm names [v3]

2025-01-10 Thread Sean Mullan
On Wed, 8 Jan 2025 19:36:31 GMT, Weijun Wang wrote: >> Add links to the new Key Algorithms section in the Java Security Standard >> Algorithm Names Specification. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > address more

RFR: 8347424: Fix and rewrite sun/security/x509/DNSName/LeadingPeriod.java test

2025-01-10 Thread Aleksey Shipilev
Noticed this when backporting [JDK-8311546](https://bugs.openjdk.org/browse/JDK-8311546). The test is actually broken, as it does not include CA cert in the certification path. So it passes even without the fix, and thus does not actually tests what the fix is supposed to test. The test is als

Re: RFR: 8344316: Add extra line in security/auth/callback/TextCallbackHandler/Password.java to make clear it is not a JTReg test

2025-01-10 Thread Mikhail Yankelevich
On Wed, 8 Jan 2025 06:40:47 GMT, Amit Kumar wrote: > Also please enable GHA on your repo. It run once the OCA was confirmed - PR Comment: https://git.openjdk.org/jdk/pull/22951#issuecomment-2582587264

Re: RFR: 8344316: Add extra line in security/auth/callback/TextCallbackHandler/Password.java to make clear it is not a JTReg test [v3]

2025-01-10 Thread Mikhail Yankelevich
> * Add extra line in security/auth/callback/TextCallbackHandler/Password.java > to make clear it is not a JTReg test > * Test will now fail if run with JTReg Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: chaned the wording

Re: RFR: 8344316: Add extra line in security/auth/callback/TextCallbackHandler/Password.java to make clear it is not a JTReg test [v2]

2025-01-10 Thread Mikhail Yankelevich
On Fri, 10 Jan 2025 10:27:50 GMT, Shivangi Gupta wrote: >> test/jdk/com/sun/security/auth/callback/TextCallbackHandler/Password.java >> line 53: >> >>> 51: >>> 52: if (System.getProperty("java.class.path").contains("jtreg")){ >>> 53: throw new RuntimeException("This is a ma

Re: RFR: 8344316: Add extra line in security/auth/callback/TextCallbackHandler/Password.java to make clear it is not a JTReg test [v2]

2025-01-10 Thread Shivangi Gupta
On Wed, 8 Jan 2025 06:40:15 GMT, Amit Kumar wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> minor, but to the @bug > > test/jdk/com/sun/security/auth/callback/TextCallbackHandler/Password.java > line 53: >

Re: RFR: 8346468: SM cleanup of common test library [v3]

2025-01-10 Thread Andrey Turbanov
On Wed, 18 Dec 2024 21:07:14 GMT, Roger Riggs wrote: >> SM Cleanup of common test library test/lib/...: >> >> Remove unnecessary catches of SecurityException >> Remove AccessController and doPrivileged from SimpleSSLContext and >> ProcessTools. > > Roger Riggs has updated the pull request incre