Re: RFR: 8345415: Rollback JDK-8301991 change on xmlsecurity_de.properties

2024-12-03 Thread Weijun Wang
On Tue, 3 Dec 2024 22:31:57 GMT, Sean Mullan wrote: > Bug needs a noreg label, but otherwise looks fine. Thanks. I chose `noreg-undo`. - PR Comment: https://git.openjdk.org/jdk/pull/22522#issuecomment-2515699497

Integrated: 8345415: Rollback JDK-8301991 change on xmlsecurity_de.properties

2024-12-03 Thread Weijun Wang
On Tue, 3 Dec 2024 18:31:30 GMT, Weijun Wang wrote: > Revert a previous change to a file from an upstream Apache repo. This pull request has now been integrated. Changeset: 82e8aa62 Author:Weijun Wang URL: https://git.openjdk.org/jdk/commit/82e8aa62de5d6854978efd66190654f05299e523 S

Re: RFR: 8345065: Cleanup DomainCombiner, SubjectDomainCombiner, Subject, and PrivilegedAction specifications [v2]

2024-12-03 Thread Weijun Wang
On Tue, 3 Dec 2024 22:26:17 GMT, Sean Mullan wrote: >> A few additional changes should be made to the API specs for these classes . >> These changes are documenting behavior of other APIs that has already been >> approved as part of JEP 486, so I don't think a CSR is necessary, but >> opinion

Re: RFR: 8344629: SSLSocketNoServerHelloClientShutdown test timeout [v4]

2024-12-03 Thread Bradford Wetmore
On Tue, 26 Nov 2024 00:26:54 GMT, Artur Barashev wrote: >> SAP complains about SSLSocketNoServerHelloClientShutdown timing out in their >> test environment (concurrent test execution with high CPU load). This change >> addresses this issue in 2 ways: >> - Increase default timeout value >> - All

Re: RFR: 8345065: Cleanup DomainCombiner, SubjectDomainCombiner, Subject, and PrivilegedAction specifications [v2]

2024-12-03 Thread Sean Mullan
On Tue, 3 Dec 2024 22:26:17 GMT, Sean Mullan wrote: >> A few additional changes should be made to the API specs for these classes . >> These changes are documenting behavior of other APIs that has already been >> approved as part of JEP 486, so I don't think a CSR is necessary, but >> opinion

Re: RFR: 8344629: SSLSocketNoServerHelloClientShutdown test timeout [v4]

2024-12-03 Thread Bradford Wetmore
On Wed, 27 Nov 2024 21:10:24 GMT, Artur Barashev wrote: >> I don't think we need this second one here. > > What would be the first one? Server thread is timing out but I don't think we > need to reverse the logic because of this, we are expecting an exception in > the server thread, the client

Re: RFR: 8345415: Rollback JDK-8301991 change on xmlsecurity_de.properties

2024-12-03 Thread Sean Mullan
On Tue, 3 Dec 2024 18:31:30 GMT, Weijun Wang wrote: > Revert a previous change to a file from an upstream Apache repo. Bug needs a noreg label, but otherwise looks fine. - Marked as reviewed by mullan (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/22522#pullrequestreview-

Re: RFR: 8345065: Cleanup DomainCombiner, SubjectDomainCombiner, Subject, and PrivilegedAction specifications [v2]

2024-12-03 Thread Sean Mullan
> A few additional changes should be made to the API specs for these classes . > These changes are documenting behavior of other APIs that has already been > approved as part of JEP 486, so I don't think a CSR is necessary, but > opinions on that are welcome. > > The `DomainCombiner` and `Subj

Re: RFR: 8315487: Security Providers Filter [v14]

2024-12-03 Thread Martin Balao
> In addition to the goals, scope, motivation, specification and requirement > notes in [JDK-8315487](https://bugs.openjdk.org/browse/JDK-8315487), we would > like to describe the most relevant decisions taken during the implementation > of this enhancement. These notes are organized by feature,

Integrated: 8345221: Replace legacy with new Provider APIs in SunNativeGSS

2024-12-03 Thread Francisco Ferrari Bihurriet
On Fri, 29 Nov 2024 14:50:47 GMT, Francisco Ferrari Bihurriet wrote: > Hi, this pull request modifies the _SunNativeGSS_ security provider to stop > using the legacy Provider APIs (`Provider::putAll`) and start using the new > ones (`Provider::putService`). > > Changes in this pull request ha

RFR: 8345415: Rollback JDK-8301991 change on xmlsecurity_de.properties

2024-12-03 Thread Weijun Wang
Revert a previous change to a file from an upstream Apache repo. - Commit messages: - the change Changes: https://git.openjdk.org/jdk/pull/22522/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22522&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8345415 Stats: 76 l

Re: RFR: 8345221: Replace legacy with new Provider APIs in SunNativeGSS [v3]

2024-12-03 Thread duke
On Mon, 2 Dec 2024 22:31:01 GMT, Francisco Ferrari Bihurriet wrote: >> Hi, this pull request modifies the _SunNativeGSS_ security provider to stop >> using the legacy Provider APIs (`Provider::putAll`) and start using the new >> ones (`Provider::putService`). >> >> Changes in this pull reques

Re: RFR: 8345221: Replace legacy with new Provider APIs in SunNativeGSS [v3]

2024-12-03 Thread Weijun Wang
On Mon, 2 Dec 2024 22:31:01 GMT, Francisco Ferrari Bihurriet wrote: >> Hi, this pull request modifies the _SunNativeGSS_ security provider to stop >> using the legacy Provider APIs (`Provider::putAll`) and start using the new >> ones (`Provider::putService`). >> >> Changes in this pull reques

Integrated: 8345325: SM cleanup of GetPropertyAction in java.base

2024-12-03 Thread Roger Riggs
On Mon, 2 Dec 2024 20:12:39 GMT, Roger Riggs wrote: > Remove sun/security/action/GetPropertyAction.java and all uses. > > Dependent on PR#22418 This pull request has now been integrated. Changeset: fcf185c8 Author:Roger Riggs URL: https://git.openjdk.org/jdk/commit/fcf185c8b425a698

Re: RFR: 8345325: SM cleanup of GetPropertyAction in java.base [v4]

2024-12-03 Thread Roger Riggs
On Tue, 3 Dec 2024 14:53:41 GMT, Eirik Bjørsnøs wrote: >> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove an obsolete comment related to long ago removed useNewThrowable > > src/java.base/share/classes/java/lang/StackS

Re: RFR: 8345325: SM cleanup of GetPropertyAction in java.base [v4]

2024-12-03 Thread Eirik Bjørsnøs
On Tue, 3 Dec 2024 14:45:22 GMT, Roger Riggs wrote: >> Remove sun/security/action/GetPropertyAction.java and all uses. >> >> Dependent on PR#22418 > > Roger Riggs has updated the pull request incrementally with one additional > commit since the last revision: > > Remove an obsolete comment r

Re: RFR: 8345325: SM cleanup of GetPropertyAction in java.base [v4]

2024-12-03 Thread Alan Bateman
On Tue, 3 Dec 2024 14:45:22 GMT, Roger Riggs wrote: >> Remove sun/security/action/GetPropertyAction.java and all uses. >> >> Dependent on PR#22418 > > Roger Riggs has updated the pull request incrementally with one additional > commit since the last revision: > > Remove an obsolete comment r

Re: RFR: 8345325: SM cleanup of GetPropertyAction in java.base [v3]

2024-12-03 Thread Roger Riggs
On Tue, 3 Dec 2024 09:40:39 GMT, Eirik Bjørsnøs wrote: >> Roger Riggs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 15 commits: >> >> - Merge branch 'master' into 8345325-sm-remove-getpropertyaction >> - Remove unused import o

Re: RFR: 8345325: SM cleanup of GetPropertyAction in java.base [v4]

2024-12-03 Thread Roger Riggs
> Remove sun/security/action/GetPropertyAction.java and all uses. > > Dependent on PR#22418 Roger Riggs has updated the pull request incrementally with one additional commit since the last revision: Remove an obsolete comment related to long ago removed useNewThrowable - Changes

Re: RFR: 8345286: Remove use of SecurityManager API from misc areas [v8]

2024-12-03 Thread Daniel Fuchs
On Tue, 3 Dec 2024 06:14:31 GMT, Jaikiran Pai wrote: >> src/java.base/linux/classes/jdk/internal/platform/CgroupSubsystemController.java >> line 68: >> >>> 66: try (Stream lines = Files.lines(filePath)) { >>> 67: Optional firstLine = lines.findFirst(); >>> 68: re

Re: RFR: 8345065: Cleanup DomainCombiner, SubjectDomainCombiner, Subject, and PrivilegedAction specifications

2024-12-03 Thread Sean Mullan
On Tue, 3 Dec 2024 13:43:25 GMT, Alan Bateman wrote: >> A few additional changes should be made to the API specs for these classes . >> These changes are documenting behavior of other APIs that has already been >> approved as part of JEP 486, so I don't think a CSR is necessary, but >> opinio

Re: RFR: 8345065: Cleanup DomainCombiner, SubjectDomainCombiner, Subject, and PrivilegedAction specifications

2024-12-03 Thread Alan Bateman
On Mon, 2 Dec 2024 22:18:33 GMT, Sean Mullan wrote: > A few additional changes should be made to the API specs for these classes . > These changes are documenting behavior of other APIs that has already been > approved as part of JEP 486, so I don't think a CSR is necessary, but > opinions on

RFR: 8345065: Cleanup DomainCombiner, SubjectDomainCombiner, Subject, and PrivilegedAction specifications

2024-12-03 Thread Sean Mullan
A few additional changes should be made to the API specs for these classes . These changes are documenting behavior of other APIs that has already been approved as part of JEP 486, so I don't think a CSR is necessary, but opinions on that are welcome. The `DomainCombiner` and `SubjectDomainCom

Re: RFR: 8345325: SM cleanup of GetPropertyAction in java.base [v3]

2024-12-03 Thread Eirik Bjørsnøs
On Mon, 2 Dec 2024 22:51:55 GMT, Roger Riggs wrote: >> Remove sun/security/action/GetPropertyAction.java and all uses. >> >> Dependent on PR#22418 > > Roger Riggs has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 15 commits: > > -

Re: RFR: 8345286: Remove use of SecurityManager API from misc areas [v9]

2024-12-03 Thread Jaikiran Pai
On Tue, 3 Dec 2024 06:12:13 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which removes usages of >> SecurityManager related APIs and some leftover related to SecurityManager >> changes? >> >> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these >>

Re: RFR: 8345286: Remove use of SecurityManager API from misc areas [v9]

2024-12-03 Thread Alan Bateman
On Tue, 3 Dec 2024 06:12:13 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which removes usages of >> SecurityManager related APIs and some leftover related to SecurityManager >> changes? >> >> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these >>