On Tue, 26 Nov 2024 00:26:54 GMT, Artur Barashev <abaras...@openjdk.org> wrote:
>> SAP complains about SSLSocketNoServerHelloClientShutdown timing out in their >> test environment (concurrent test execution with high CPU load). This change >> addresses this issue in 2 ways: >> - Increase default timeout value >> - Allow adjustment of timeout value by setting "test.timeout.factor" system >> property > > Artur Barashev has updated the pull request incrementally with one additional > commit since the last revision: > > Remove timeout as JTREG has a default test timeout I was moving too fast last week and didn't catch that you had removed **both** `Socket.SoTimeOut`s. I thought you were still trying to minimize the client/server interaction time in one place. The default `Socket` timeout is likely just fine. So yes, let's pull the `CountDownLatch`, as we no longer need the lockstep control, and I think it's good to go. One minor suggestion, you might also add to the class comment (lines 53-55) that you're using the `SSLEngine` to prevent the the client from receiving/responding to the server's ServerHello, and thus force the generation of the plaintext shutdown. ------------- PR Review: https://git.openjdk.org/jdk/pull/22263#pullrequestreview-2476901487
