Re: RFR: 8345325: SM cleanup of GetPropertyAction in java.base [v3]

2024-12-02 Thread Alan Bateman
On Mon, 2 Dec 2024 22:51:55 GMT, Roger Riggs wrote: >> Remove sun/security/action/GetPropertyAction.java and all uses. >> >> Dependent on PR#22418 > > Roger Riggs has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 15 commits: > > -

Re: RFR: 8345286: Remove use of SecurityManager API from misc areas [v8]

2024-12-02 Thread Jaikiran Pai
On Mon, 2 Dec 2024 17:47:57 GMT, Daniel Fuchs wrote: >> Jaikiran Pai has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 13 commits: >> >> - merge latest from master branch >> - remove changes to >> src/java.base/unix/classes/sun/s

Re: RFR: 8345286: Remove use of SecurityManager API from misc areas [v8]

2024-12-02 Thread Jaikiran Pai
On Mon, 2 Dec 2024 18:54:33 GMT, Alan Bateman wrote: >> src/java.base/share/classes/jdk/internal/misc/InnocuousThread.java line 31: >> >>> 29: >>> 30: /** >>> 31: * A thread that has no permissions, is not a member of any user-defined >> >> I think you can also remove the words "has no permis

Re: RFR: 8345286: Remove use of SecurityManager API from misc areas [v9]

2024-12-02 Thread Jaikiran Pai
> Can I please get a review of this change which removes usages of > SecurityManager related APIs and some leftover related to SecurityManager > changes? > > This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these > changes are trivial. The > `src/java.base/linux/classes/jdk/

Re: RFR: 8345325: SM cleanup of GetPropertyAction in java.base [v3]

2024-12-02 Thread Naoto Sato
On Mon, 2 Dec 2024 22:51:55 GMT, Roger Riggs wrote: >> Remove sun/security/action/GetPropertyAction.java and all uses. >> >> Dependent on PR#22418 > > Roger Riggs has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 15 commits: > > -

Re: RFR: 8345325: SM cleanup of GetPropertyAction in java.base [v3]

2024-12-02 Thread Roger Riggs
On Mon, 2 Dec 2024 22:51:55 GMT, Roger Riggs wrote: >> Remove sun/security/action/GetPropertyAction.java and all uses. >> >> Dependent on PR#22418 > > Roger Riggs has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 15 commits: > > -

Re: RFR: 8344397: Remove Security Manager dependencies from java.security and sun.security packages [v5]

2024-12-02 Thread Sean Mullan
> Now that JEP 486 has been integrated, `java.security` and `sun.security` > implementation dependencies on `System.getSecurityManager` and > `AccessController.doPrivileged` can be removed. > > This should cover most of the remaining cleanup in the security libraries > area. A couple of the `s

Re: RFR: 8345325: SM cleanup of GetPropertyAction in java.base [v3]

2024-12-02 Thread Roger Riggs
On Mon, 2 Dec 2024 22:51:55 GMT, Roger Riggs wrote: >> Remove sun/security/action/GetPropertyAction.java and all uses. >> >> Dependent on PR#22418 > > Roger Riggs has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 15 commits: > > -

Re: RFR: 8345325: SM cleanup of GetPropertyAction in java.base [v3]

2024-12-02 Thread Roger Riggs
> Remove sun/security/action/GetPropertyAction.java and all uses. > > Dependent on PR#22418 Roger Riggs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 15 commits: - Merge branch 'master' into 8345325-sm-remove-getpropertyaction -

Re: RFR: 8345221: Replace legacy with new Provider APIs in SunNativeGSS [v3]

2024-12-02 Thread Martin Balao
On Mon, 2 Dec 2024 21:18:10 GMT, Weijun Wang wrote: >> Francisco Ferrari Bihurriet has updated the pull request with a new target >> base due to a merge or a rebase. The pull request now contains three commits: >> >> - Merge openjdk/master into JDK-8345221 >> - Method rename. >> >>Co-

Re: RFR: 8345286: Remove use of SecurityManager API from misc areas [v5]

2024-12-02 Thread Jaikiran Pai
> Can I please get a review of this change which removes usages of > SecurityManager related APIs and some leftover related to SecurityManager > changes? > > This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these > changes are trivial. The > `src/java.base/linux/classes/jdk/

Re: RFR: 8345325: SM cleanup of GetPropertyAction in java.base [v2]

2024-12-02 Thread Chen Liang
On Mon, 2 Dec 2024 22:02:54 GMT, Sean Mullan wrote: > This includes a lot of changes already integrated in 8344397. Is that normal? I believe this is due to GitHub's diff rendering when it detects a merge conflict. It should go away once the conflict is fixed. - PR Comment: https

Re: RFR: 8345221: Replace legacy with new Provider APIs in SunNativeGSS [v3]

2024-12-02 Thread Francisco Ferrari Bihurriet
> Hi, this pull request modifies the _SunNativeGSS_ security provider to stop > using the legacy Provider APIs (`Provider::putAll`) and start using the new > ones (`Provider::putService`). > > Changes in this pull request have been removed from #15539, as they aren't a > dependency for that wor

Re: RFR: 8345221: Replace legacy with new Provider APIs in SunNativeGSS

2024-12-02 Thread Martin Balao
On Mon, 2 Dec 2024 21:19:29 GMT, Weijun Wang wrote: > Do you need a `noreg-` label for the JBS issue? Sounds good. Added. - PR Comment: https://git.openjdk.org/jdk/pull/22461#issuecomment-2513077138

Re: RFR: 8345221: Replace legacy with new Provider APIs in SunNativeGSS [v2]

2024-12-02 Thread Francisco Ferrari Bihurriet
> Hi, this pull request modifies the _SunNativeGSS_ security provider to stop > using the legacy Provider APIs (`Provider::putAll`) and start using the new > ones (`Provider::putService`). Additionally, it removes > `sun.security.action.PutAllAction`, no longer used since #22256. > > Changes in

Re: RFR: 8345325: SM cleanup of GetPropertyAction in java.base [v2]

2024-12-02 Thread Sean Mullan
On Mon, 2 Dec 2024 20:47:16 GMT, Roger Riggs wrote: >> Remove sun/security/action/GetPropertyAction.java and all uses. >> >> Dependent on PR#22418 > > Roger Riggs has updated the pull request incrementally with two additional > commits since the last revision: > > - Remove unused import of Pr

Integrated: 8344397: Remove Security Manager dependencies from java.security and sun.security packages

2024-12-02 Thread Sean Mullan
On Wed, 27 Nov 2024 17:51:12 GMT, Sean Mullan wrote: > Now that JEP 486 has been integrated, `java.security` and `sun.security` > implementation dependencies on `System.getSecurityManager` and > `AccessController.doPrivileged` can be removed. > > This should cover most of the remaining cleanu

Re: RFR: 8341775: Duplicate manifest files are removed by jarsigner after signing

2024-12-02 Thread Weijun Wang
On Mon, 18 Nov 2024 22:40:40 GMT, Kevin Driver wrote: > JDK-8341775: In the case where there is a *single* META-INF directory but > potentially *multiple* manifest files of different cases, print a warning > before selecting the first one and ignoring the rest (the current behavior > should be

Re: RFR: 8344397: Remove Security Manager dependencies from java.security and sun.security packages [v4]

2024-12-02 Thread Sean Mullan
On Mon, 2 Dec 2024 16:35:55 GMT, Sean Mullan wrote: >> Now that JEP 486 has been integrated, `java.security` and `sun.security` >> implementation dependencies on `System.getSecurityManager` and >> `AccessController.doPrivileged` can be removed. >> >> This should cover most of the remaining cl

Re: RFR: 8344397: Remove Security Manager dependencies from java.security and sun.security packages [v6]

2024-12-02 Thread Weijun Wang
On Mon, 2 Dec 2024 20:59:53 GMT, Sean Mullan wrote: >> Now that JEP 486 has been integrated, `java.security` and `sun.security` >> implementation dependencies on `System.getSecurityManager` and >> `AccessController.doPrivileged` can be removed. >> >> This should cover most of the remaining cl

Re: RFR: 8345286: Remove use of SecurityManager API from misc areas [v7]

2024-12-02 Thread Jaikiran Pai
On Mon, 2 Dec 2024 15:42:37 GMT, Alan Bateman wrote: >> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove changes to >> src/java.base/unix/classes/sun/security/provider/NativePRNG.java > > src/java.base/unix/classes/su

Re: RFR: 8344397: Remove Security Manager dependencies from java.security and sun.security packages [v2]

2024-12-02 Thread Sean Mullan
On Thu, 28 Nov 2024 20:29:24 GMT, Daniel Fuchs wrote: > I am seing some doPrivileged in > `src/java.base/unix/classes/sun/security/provider/NativePRNG.java` - should > this PR also fix them? Good catch. Fixed in https://github.com/openjdk/jdk/pull/22418/commits/91afd302b91651923a4a075d9fc129f

Re: RFR: 8345286: Remove use of SecurityManager API from misc areas [v2]

2024-12-02 Thread Jaikiran Pai
On Mon, 2 Dec 2024 13:43:41 GMT, Severin Gehwolf wrote: >> Jaikiran Pai has updated the pull request incrementally with four additional >> commits since the last revision: >> >> - remove unnecessary space >> - Path.of() instead of Paths.get() >> - fix formatting of try-with-resources in Cgro

Re: RFR: 8345286: Remove use of SecurityManager API from misc areas [v8]

2024-12-02 Thread Jaikiran Pai
> Can I please get a review of this change which removes usages of > SecurityManager related APIs and some leftover related to SecurityManager > changes? > > This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these > changes are trivial. The > `src/java.base/linux/classes/jdk/

Re: RFR: 8345286: Remove use of SecurityManager API from misc areas [v5]

2024-12-02 Thread Severin Gehwolf
On Mon, 2 Dec 2024 14:16:02 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which removes usages of >> SecurityManager related APIs and some leftover related to SecurityManager >> changes? >> >> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these >>

Re: RFR: 8345286: Remove use of SecurityManager API from misc areas [v3]

2024-12-02 Thread Jaikiran Pai
> Can I please get a review of this change which removes usages of > SecurityManager related APIs and some leftover related to SecurityManager > changes? > > This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these > changes are trivial. The > `src/java.base/linux/classes/jdk/

Re: RFR: 8345221: Replace legacy with new Provider APIs in SunNativeGSS

2024-12-02 Thread Weijun Wang
On Fri, 29 Nov 2024 14:50:47 GMT, Francisco Ferrari Bihurriet wrote: > Hi, this pull request modifies the _SunNativeGSS_ security provider to stop > using the legacy Provider APIs (`Provider::putAll`) and start using the new > ones (`Provider::putService`). Additionally, it removes > `sun.sec

Integrated: 8345060: Remove Security Manager dependencies from java.security.KeyStore and Identity APIs and implementations

2024-12-02 Thread Sean Mullan
On Tue, 26 Nov 2024 21:06:14 GMT, Sean Mullan wrote: > Now that JEP 486 has been integrated, `java.security.KeyStore` and `Identity` > API and impl dependencies on `System.getSecurityManager`, > `AccessController.doPrivileged` and `AccessControlContext` can be removed. > > Most of the changes

Re: RFR: 8345286: Remove use of SecurityManager API from misc areas [v6]

2024-12-02 Thread Jaikiran Pai
On Mon, 2 Dec 2024 14:25:12 GMT, Alan Bateman wrote: >> Jaikiran Pai has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - remove unused import >> - replace remaining Paths.get() with Path.of() in the updated files > > src/java.base/linux/c

Re: RFR: 8344397: Remove Security Manager dependencies from java.security and sun.security packages [v4]

2024-12-02 Thread Sean Mullan
> Now that JEP 486 has been integrated, `java.security` and `sun.security` > implementation dependencies on `System.getSecurityManager` and > `AccessController.doPrivileged` can be removed. > > This should cover most of the remaining cleanup in the security libraries > area. A couple of the `s

Re: RFR: 8345286: Remove use of SecurityManager API from misc areas [v7]

2024-12-02 Thread Jaikiran Pai
> Can I please get a review of this change which removes usages of > SecurityManager related APIs and some leftover related to SecurityManager > changes? > > This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these > changes are trivial. The > `src/java.base/linux/classes/jdk/

Re: RFR: 8345286: Remove use of SecurityManager API from misc areas [v2]

2024-12-02 Thread Severin Gehwolf
On Mon, 2 Dec 2024 13:39:57 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which removes usages of >> SecurityManager related APIs and some leftover related to SecurityManager >> changes? >> >> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these >>

Re: RFR: 8345325: SM cleanup of GetPropertyAction in java.base [v2]

2024-12-02 Thread Mandy Chung
On Mon, 2 Dec 2024 20:47:16 GMT, Roger Riggs wrote: >> Remove sun/security/action/GetPropertyAction.java and all uses. >> >> Dependent on PR#22418 > > Roger Riggs has updated the pull request incrementally with two additional > commits since the last revision: > > - Remove unused import of Pr

Re: RFR: 8315487: Security Providers Filter [v13]

2024-12-02 Thread Martin Balao
On Mon, 2 Dec 2024 00:37:45 GMT, Xue-Lei Andrew Fan wrote: >> Martin Balao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Undo SunNativeProvider provider changes. They will be implemented in >> JDK-8345221. > > Thank you for the respon

Re: RFR: 8344397: Remove Security Manager dependencies from java.security and sun.security packages [v6]

2024-12-02 Thread Hai-May Chao
On Mon, 2 Dec 2024 20:59:53 GMT, Sean Mullan wrote: >> Now that JEP 486 has been integrated, `java.security` and `sun.security` >> implementation dependencies on `System.getSecurityManager` and >> `AccessController.doPrivileged` can be removed. >> >> This should cover most of the remaining cl

Re: RFR: 8344397: Remove Security Manager dependencies from java.security and sun.security packages [v6]

2024-12-02 Thread Roger Riggs
On Mon, 2 Dec 2024 20:59:53 GMT, Sean Mullan wrote: >> Now that JEP 486 has been integrated, `java.security` and `sun.security` >> implementation dependencies on `System.getSecurityManager` and >> `AccessController.doPrivileged` can be removed. >> >> This should cover most of the remaining cl

Re: RFR: 8345286: Remove use of SecurityManager API from misc areas [v5]

2024-12-02 Thread Jaikiran Pai
On Mon, 2 Dec 2024 14:17:10 GMT, Severin Gehwolf wrote: > cgroups changes look good. Haven't looked at the other bits. Thank you Severin. > src/java.base/linux/classes/jdk/internal/platform/CgroupSubsystemController.java > line 29: > >> 27: package jdk.internal.platform; >> 28: >> 29: import

Re: RFR: 8344397: Remove Security Manager dependencies from java.security and sun.security packages [v6]

2024-12-02 Thread Sean Mullan
> Now that JEP 486 has been integrated, `java.security` and `sun.security` > implementation dependencies on `System.getSecurityManager` and > `AccessController.doPrivileged` can be removed. > > This should cover most of the remaining cleanup in the security libraries > area. A couple of the `s

Re: RFR: 8344397: Remove Security Manager dependencies from java.security and sun.security packages [v5]

2024-12-02 Thread Roger Riggs
On Mon, 2 Dec 2024 18:12:55 GMT, Sean Mullan wrote: >> Now that JEP 486 has been integrated, `java.security` and `sun.security` >> implementation dependencies on `System.getSecurityManager` and >> `AccessController.doPrivileged` can be removed. >> >> This should cover most of the remaining cl

Re: RFR: 8345325: SM cleanup of GetPropertyAction in java.base [v2]

2024-12-02 Thread Roger Riggs
On Mon, 2 Dec 2024 20:40:23 GMT, Eirik Bjørsnøs wrote: >> Yes, with Sean's changes in #22418, GetPropertyAction et.al. is deleted. > > @RogerRiggs Alan may have referred to the import of `java.util.Properties`. Right, thanks - PR Review Comment: https://git.openjdk.org/jdk/pull/224

Re: RFR: 8345325: SM cleanup of GetPropertyAction in java.base [v2]

2024-12-02 Thread Eirik Bjørsnøs
On Mon, 2 Dec 2024 20:28:13 GMT, Roger Riggs wrote: >> src/java.base/share/classes/java/lang/invoke/MethodHandleNatives.java line >> 710: >> >>> 708: >>> 709: static { >>> 710: Properties props = GetPropertyAction.privilegedGetProperties(); >> >> This is probably the last usage of

Re: RFR: 8345325: SM cleanup of GetPropertyAction in java.base [v2]

2024-12-02 Thread Mandy Chung
On Mon, 2 Dec 2024 20:44:05 GMT, Roger Riggs wrote: >> Remove sun/security/action/GetPropertyAction.java and all uses. >> >> Dependent on PR#22418 > > Roger Riggs has updated the pull request incrementally with two additional > commits since the last revision: > > - Remove unused import of Pr

Re: RFR: 8345325: SM cleanup of GetPropertyAction in java.base [v2]

2024-12-02 Thread Roger Riggs
> Remove sun/security/action/GetPropertyAction.java and all uses. > > Dependent on PR#22418 Roger Riggs has updated the pull request incrementally with two additional commits since the last revision: - Remove unused import of Properties - Update copyrights Remove jdk/sun/security/action/Ge

Re: RFR: 8345325: SM cleanup of GetPropertyAction in java.base

2024-12-02 Thread Roger Riggs
On Mon, 2 Dec 2024 20:19:23 GMT, Alan Bateman wrote: >> Remove sun/security/action/GetPropertyAction.java and all uses. >> >> Dependent on PR#22418 > > src/java.base/share/classes/java/lang/invoke/MethodHandleNatives.java line > 710: > >> 708: >> 709: static { >> 710: Properties p

Re: RFR: 8345325: SM cleanup of GetPropertyAction in java.base

2024-12-02 Thread Naoto Sato
On Mon, 2 Dec 2024 20:12:39 GMT, Roger Riggs wrote: > Remove sun/security/action/GetPropertyAction.java and all uses. > > Dependent on PR#22418 LGTM - Marked as reviewed by naoto (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/22497#pullrequestreview-2473841217

Re: RFR: 8345325: SM cleanup of GetPropertyAction in java.base

2024-12-02 Thread Alan Bateman
On Mon, 2 Dec 2024 20:12:39 GMT, Roger Riggs wrote: > Remove sun/security/action/GetPropertyAction.java and all uses. > > Dependent on PR#22418 src/java.base/share/classes/java/lang/invoke/MethodHandleNatives.java line 710: > 708: > 709: static { > 710: Properties props = GetPrope

Re: RFR: 8345325: SM cleanup of GetPropertyAction in java.base

2024-12-02 Thread Lance Andersen
On Mon, 2 Dec 2024 20:12:39 GMT, Roger Riggs wrote: > Remove sun/security/action/GetPropertyAction.java and all uses. > > Dependent on PR#22418 Changes Look Good Roger - Marked as reviewed by lancea (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/22497#pullrequestreview-2

RFR: 8345325: SM cleanup of GetPropertyAction in java.base

2024-12-02 Thread Roger Riggs
Remove sun/security/action/GetPropertyAction.java and all uses. Dependent on PR#22418 - Depends on: https://git.openjdk.org/jdk/pull/22418 Commit messages: - 8345325: SM cleanup of GetPropertyAction in java.base Changes: https://git.openjdk.org/jdk/pull/22497/files Webrev: https

Re: RFR: 8345286: Remove use of SecurityManager API from misc areas [v2]

2024-12-02 Thread Jaikiran Pai
On Mon, 2 Dec 2024 14:07:45 GMT, Severin Gehwolf wrote: >> Is the catch for `UncheckedIOException` due to some previously known failure >> resulting in the use of these APIs? > > Without using `Files.lines()` no `UncheckedIOException` would be thrown. Just > `IOException` and `null` returned. T

Re: RFR: 8344397: Remove Security Manager dependencies from java.security and sun.security packages [v3]

2024-12-02 Thread Sean Mullan
> Now that JEP 486 has been integrated, `java.security` and `sun.security` > implementation dependencies on `System.getSecurityManager` and > `AccessController.doPrivileged` can be removed. > > This should cover most of the remaining cleanup in the security libraries > area. A couple of the `s

Re: RFR: 8345286: Remove use of SecurityManager API from misc areas [v8]

2024-12-02 Thread Daniel Fuchs
On Mon, 2 Dec 2024 16:11:57 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which removes usages of >> SecurityManager related APIs and some leftover related to SecurityManager >> changes? >> >> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these >>

Re: RFR: 8344397: Remove Security Manager dependencies from java.security and sun.security packages [v2]

2024-12-02 Thread Sean Mullan
On Thu, 28 Nov 2024 17:18:36 GMT, Alan Bateman wrote: >> Sean Mullan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removal of unused fields from AccessControlContext - no longer needed now >> that VM cleanup is done. > > src/java.base

Re: RFR: 8344397: Remove Security Manager dependencies from java.security and sun.security packages [v5]

2024-12-02 Thread Hai-May Chao
On Mon, 2 Dec 2024 18:12:55 GMT, Sean Mullan wrote: >> Now that JEP 486 has been integrated, `java.security` and `sun.security` >> implementation dependencies on `System.getSecurityManager` and >> `AccessController.doPrivileged` can be removed. >> >> This should cover most of the remaining cl

Re: RFR: 8344397: Remove Security Manager dependencies from java.security and sun.security packages [v5]

2024-12-02 Thread Daniel Fuchs
On Mon, 2 Dec 2024 18:12:55 GMT, Sean Mullan wrote: >> Now that JEP 486 has been integrated, `java.security` and `sun.security` >> implementation dependencies on `System.getSecurityManager` and >> `AccessController.doPrivileged` can be removed. >> >> This should cover most of the remaining cl

Integrated: 8344768: Consider removing "sun.security.krb5.autodeducerealm" system property

2024-12-02 Thread Weijun Wang
On Mon, 2 Dec 2024 17:29:44 GMT, Weijun Wang wrote: > The system property was used to signal a case where a certain permission is > required. It's now useless. This pull request has now been integrated. Changeset: d6a5f1ba Author:Weijun Wang URL: https://git.openjdk.org/jdk/commit/

Re: RFR: 8344768: Consider removing "sun.security.krb5.autodeducerealm" system property

2024-12-02 Thread Sean Mullan
On Mon, 2 Dec 2024 17:29:44 GMT, Weijun Wang wrote: > The system property was used to signal a case where a certain permission is > required. It's now useless. Marked as reviewed by mullan (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/22492#pullrequestreview-2473728847

Re: RFR: 8345286: Remove use of SecurityManager API from misc areas [v6]

2024-12-02 Thread Alan Bateman
On Mon, 2 Dec 2024 14:24:57 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which removes usages of >> SecurityManager related APIs and some leftover related to SecurityManager >> changes? >> >> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these >>

Re: RFR: 8345286: Remove use of SecurityManager API from misc areas [v6]

2024-12-02 Thread Alan Bateman
On Mon, 2 Dec 2024 14:24:57 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which removes usages of >> SecurityManager related APIs and some leftover related to SecurityManager >> changes? >> >> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these >>

Re: RFR: 8344397: Remove Security Manager dependencies from java.security and sun.security packages [v2]

2024-12-02 Thread Sean Mullan
On Thu, 28 Nov 2024 16:20:56 GMT, Francisco Ferrari Bihurriet wrote: >> Sean Mullan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removal of unused fields from AccessControlContext - no longer needed now >> that VM cleanup is done. >

Re: RFR: 8344397: Remove Security Manager dependencies from java.security and sun.security packages [v5]

2024-12-02 Thread Sean Mullan
On Mon, 2 Dec 2024 18:12:55 GMT, Sean Mullan wrote: >> Now that JEP 486 has been integrated, `java.security` and `sun.security` >> implementation dependencies on `System.getSecurityManager` and >> `AccessController.doPrivileged` can be removed. >> >> This should cover most of the remaining cl

Re: RFR: 8344768: Consider removing "sun.security.krb5.autodeducerealm" system property

2024-12-02 Thread Weijun Wang
On Mon, 2 Dec 2024 18:58:10 GMT, Sean Mullan wrote: > > The system property was used to signal a case where a certain permission is > > required. It's not useless. > > I assume you mean "It's now useless"? Yes. Fixed. - PR Comment: https://git.openjdk.org/jdk/pull/22492#issuecomm

Re: RFR: 8344768: Consider removing "sun.security.krb5.autodeducerealm" system property

2024-12-02 Thread Sean Mullan
On Mon, 2 Dec 2024 17:29:44 GMT, Weijun Wang wrote: > The system property was used to signal a case where a certain permission is > required. It's now useless. > The system property was used to signal a case where a certain permission is > required. It's not useless. I assume you mean "It's n

Re: RFR: 8345286: Remove use of SecurityManager API from misc areas [v2]

2024-12-02 Thread Severin Gehwolf
On Mon, 2 Dec 2024 14:03:10 GMT, Jaikiran Pai wrote: >> src/java.base/linux/classes/jdk/internal/platform/CgroupSubsystemController.java >> line 70: >> >>> 68: String line = bufferedReader.readLine(); >>> 69: return line; >>> 70: } catch (IOException e) { >> >>

Re: RFR: 8345286: Remove use of SecurityManager API from misc areas [v8]

2024-12-02 Thread Alan Bateman
On Mon, 2 Dec 2024 18:48:27 GMT, Sean Mullan wrote: >> Jaikiran Pai has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 13 commits: >> >> - merge latest from master branch >> - remove changes to >> src/java.base/unix/classes/sun/se

Re: RFR: 8344397: Remove Security Manager dependencies from java.security and sun.security packages [v2]

2024-12-02 Thread Weijun Wang
On Wed, 27 Nov 2024 19:59:24 GMT, Sean Mullan wrote: >> Now that JEP 486 has been integrated, `java.security` and `sun.security` >> implementation dependencies on `System.getSecurityManager` and >> `AccessController.doPrivileged` can be removed. >> >> This should cover most of the remaining c

Re: RFR: 8345286: Remove use of SecurityManager API from misc areas [v8]

2024-12-02 Thread Sean Mullan
On Mon, 2 Dec 2024 16:11:57 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which removes usages of >> SecurityManager related APIs and some leftover related to SecurityManager >> changes? >> >> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these >>

Re: RFR: 8344397: Remove Security Manager dependencies from java.security and sun.security packages [v4]

2024-12-02 Thread Aleksei Efimov
On Mon, 2 Dec 2024 16:39:55 GMT, Sean Mullan wrote: > I just pushed [a > change](https://github.com/openjdk/jdk/pull/22418/commits/a447dd44da5394620c62bac7e05142898d092153) > to replace the remaining calls to > `SecurityProperties.privilegedGetOverridable()`with > `SecurityProperties.getOverr

Re: RFR: 8344397: Remove Security Manager dependencies from java.security and sun.security packages [v5]

2024-12-02 Thread Alan Bateman
On Mon, 2 Dec 2024 18:12:55 GMT, Sean Mullan wrote: >> Now that JEP 486 has been integrated, `java.security` and `sun.security` >> implementation dependencies on `System.getSecurityManager` and >> `AccessController.doPrivileged` can be removed. >> >> This should cover most of the remaining cl

Re: RFR: 8344397: Remove Security Manager dependencies from java.security and sun.security packages [v2]

2024-12-02 Thread Sean Mullan
On Mon, 2 Dec 2024 14:54:57 GMT, Weijun Wang wrote: >> Sean Mullan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removal of unused fields from AccessControlContext - no longer needed now >> that VM cleanup is done. > > src/java.base/s

RFR: 8344768: Consider removing "sun.security.krb5.autodeducerealm" system property

2024-12-02 Thread Weijun Wang
The system property was used to signal a case where a certain permission is required. It's not useless. - Commit messages: - the fix Changes: https://git.openjdk.org/jdk/pull/22492/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22492&range=00 Issue: https://bugs.openjdk

Re: RFR: 8345286: Remove use of SecurityManager API from misc areas [v8]

2024-12-02 Thread Severin Gehwolf
On Mon, 2 Dec 2024 16:11:57 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which removes usages of >> SecurityManager related APIs and some leftover related to SecurityManager >> changes? >> >> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these >>

Re: RFR: 8345060: Remove Security Manager dependencies from java.security.KeyStore and Identity APIs and implementations [v2]

2024-12-02 Thread Weijun Wang
On Wed, 27 Nov 2024 14:39:21 GMT, Sean Mullan wrote: >> Now that JEP 486 has been integrated, `java.security.KeyStore` and >> `Identity` API and impl dependencies on `System.getSecurityManager`, >> `AccessController.doPrivileged` and `AccessControlContext` can be removed. >> >> Most of the cha

Re: RFR: 8345286: Remove use of SecurityManager API from misc areas [v6]

2024-12-02 Thread Jaikiran Pai
> Can I please get a review of this change which removes usages of > SecurityManager related APIs and some leftover related to SecurityManager > changes? > > This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these > changes are trivial. The > `src/java.base/linux/classes/jdk/

Re: RFR: 8345286: Remove use of SecurityManager API from misc areas [v4]

2024-12-02 Thread Jaikiran Pai
> Can I please get a review of this change which removes usages of > SecurityManager related APIs and some leftover related to SecurityManager > changes? > > This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these > changes are trivial. The > `src/java.base/linux/classes/jdk/

Re: RFR: 8345286: Remove use of SecurityManager API from misc areas [v3]

2024-12-02 Thread Jaikiran Pai
On Mon, 2 Dec 2024 13:06:05 GMT, Severin Gehwolf wrote: >> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Path.of() instead of Paths.get() in CgroupV2Subsystem.java > > src/java.base/linux/classes/jdk/internal/platform/cgro

Re: RFR: 8345286: Remove use of SecurityManager API from misc areas [v2]

2024-12-02 Thread Severin Gehwolf
On Mon, 2 Dec 2024 12:43:20 GMT, Alan Bateman wrote: >> Jaikiran Pai has updated the pull request incrementally with four additional >> commits since the last revision: >> >> - remove unnecessary space >> - Path.of() instead of Paths.get() >> - fix formatting of try-with-resources in CgroupS

Re: RFR: 8345286: Remove use of SecurityManager API from misc areas [v2]

2024-12-02 Thread Jaikiran Pai
> Can I please get a review of this change which removes usages of > SecurityManager related APIs and some leftover related to SecurityManager > changes? > > This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these > changes are trivial. The > `src/java.base/linux/classes/jdk/

Re: RFR: 8345286: Remove use of SecurityManager API from misc areas [v2]

2024-12-02 Thread Jaikiran Pai
On Mon, 2 Dec 2024 12:42:47 GMT, Alan Bateman wrote: >> Jaikiran Pai has updated the pull request incrementally with four additional >> commits since the last revision: >> >> - remove unnecessary space >> - Path.of() instead of Paths.get() >> - fix formatting of try-with-resources in CgroupS

Re: RFR: 8345286: Remove use of SecurityManager API from misc areas

2024-12-02 Thread Alan Bateman
On Mon, 2 Dec 2024 12:13:57 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which removes usages of > SecurityManager related APIs and some leftover related to SecurityManager > changes? > > This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these > change

RFR: 8345286: Remove use of SecurityManager API from misc areas

2024-12-02 Thread Jaikiran Pai
Can I please get a review of this change which removes usages of SecurityManager related APIs and some leftover related to SecurityManager changes? This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these changes are trivial. The `src/java.base/linux/classes/jdk/internal/platf

Re: RFR: 8345286: Remove use of SecurityManager API from misc areas

2024-12-02 Thread Jaikiran Pai
On Mon, 2 Dec 2024 12:13:57 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which removes usages of > SecurityManager related APIs and some leftover related to SecurityManager > changes? > > This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these > change