On Mon, 18 Nov 2024 22:40:40 GMT, Kevin Driver <kdri...@openjdk.org> wrote:

> JDK-8341775: In the case where there is a *single* META-INF directory but 
> potentially *multiple* manifest files of different cases, print a warning 
> before selecting the first one and ignoring the rest (the current behavior 
> should be maintained).
> 
> **Note**: We cannot (so far) pass whether the verbose flag is set to the 
> class that does this processing. We may want to add a property to the builder 
> for this. As-is, the message will be printed via `System.err` whether verbose 
> is set or not.

Two comments:
1. The warning should only be shown by the `jarsigner` tool. `JarSigner` is an 
API and should not write to `System.err`.
2. There are other warnings by `jarsigner` and the new one should be a part of 
them, i.e. no separate header. It also should be localized.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22222#issuecomment-2512929699

Reply via email to