Re: RFR: JDK-8338587 - Internal XOF Methods for SHAKE128 and SHAKE256 [v4]

2024-08-27 Thread Ferenc Rakoczi
On Tue, 27 Aug 2024 13:05:42 GMT, Ferenc Rakoczi wrote: >> In preparation for the new PQC algorithms implementations, internal XOF >> (eXtendable Output Function) methods are added to the SHAKE128 and SHAKE256 >> implementations. > > Ferenc Rakoczi has updated the pull request incrementally wit

Re: RFR: JDK-8338587 - Internal XOF Methods for SHAKE128 and SHAKE256 [v4]

2024-08-27 Thread Ferenc Rakoczi
> In preparation for the new PQC algorithms implementations, internal XOF > (eXtendable Output Function) methods are added to the SHAKE128 and SHAKE256 > implementations. Ferenc Rakoczi has updated the pull request incrementally with one additional commit since the last revision: Code style

Re: RFR: JDK-8338587 - Internal XOF Methods for SHAKE128 and SHAKE256 [v2]

2024-08-27 Thread Ferenc Rakoczi
On Mon, 26 Aug 2024 15:33:42 GMT, Weijun Wang wrote: >> Ferenc Rakoczi has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Accepting review comments. > > src/java.base/share/classes/sun/security/provider/SHA3.java line 78: > >> 76: >> 77:

Re: RFR: JDK-8338587 - Internal XOF Methods for SHAKE128 and SHAKE256 [v3]

2024-08-27 Thread Ferenc Rakoczi
On Tue, 27 Aug 2024 12:48:31 GMT, Andrey Turbanov wrote: >> Ferenc Rakoczi has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixed comment, added test contributed by Weijun > > src/java.base/share/classes/sun/security/provider/SHA3.java li

Re: RFR: JDK-8338587 - Internal XOF Methods for SHAKE128 and SHAKE256 [v3]

2024-08-27 Thread Andrey Turbanov
On Tue, 27 Aug 2024 12:35:24 GMT, Ferenc Rakoczi wrote: >> In preparation for the new PQC algorithms implementations, internal XOF >> (eXtendable Output Function) methods are added to the SHAKE128 and SHAKE256 >> implementations. > > Ferenc Rakoczi has updated the pull request incrementally wit

Re: RFR: JDK-8338587 - Internal XOF Methods for SHAKE128 and SHAKE256 [v3]

2024-08-27 Thread Ferenc Rakoczi
> In preparation for the new PQC algorithms implementations, internal XOF > (eXtendable Output Function) methods are added to the SHAKE128 and SHAKE256 > implementations. Ferenc Rakoczi has updated the pull request incrementally with one additional commit since the last revision: fixed comme

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v9]

2024-08-27 Thread Sean Mullan
On Fri, 16 Aug 2024 21:03:11 GMT, Kevin Driver wrote: >> If that's the case, then I think the `ikms` and `salts` method should >> specify that an empty List may be returned and under what conditions, as it >> is an edge case. For example, "Returns an empty list if there are no salt >> values".

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v15]

2024-08-27 Thread Sean Mullan
On Mon, 26 Aug 2024 17:54:18 GMT, Weijun Wang wrote: >> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> code review comments and test renaming > > src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 282

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v15]

2024-08-27 Thread Sean Mullan
On Fri, 23 Aug 2024 21:48:44 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another P

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v15]

2024-08-27 Thread Sean Mullan
On Fri, 23 Aug 2024 21:48:44 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another P

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v15]

2024-08-27 Thread Sean Mullan
On Fri, 23 Aug 2024 21:48:44 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another P

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v15]

2024-08-27 Thread Sean Mullan
On Fri, 23 Aug 2024 21:48:44 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another P