Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v11]

2024-08-15 Thread Valerie Peng
On Tue, 13 Aug 2024 15:24:11 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another P

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v11]

2024-08-15 Thread Valerie Peng
On Tue, 13 Aug 2024 15:24:11 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another P

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v11]

2024-08-15 Thread Valerie Peng
On Tue, 13 Aug 2024 15:24:11 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another P

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v11]

2024-08-15 Thread Valerie Peng
On Tue, 13 Aug 2024 15:24:11 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another P

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v11]

2024-08-15 Thread Valerie Peng
On Tue, 13 Aug 2024 15:24:11 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another P

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v11]

2024-08-15 Thread Valerie Peng
On Tue, 13 Aug 2024 15:24:11 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another P

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v11]

2024-08-15 Thread Valerie Peng
On Tue, 13 Aug 2024 15:24:11 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another P

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v11]

2024-08-15 Thread Kevin Driver
On Thu, 15 Aug 2024 20:30:38 GMT, Valerie Peng wrote: >> src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java >> line 293: >> >>> 291: * {@code HkdfParameterSpec} >>> 292: */ >>> 293: protected byte[] hkdfExtract(SecretKey inputKey, byte[] salt) >> >> Us

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v11]

2024-08-15 Thread Kevin Driver
On Thu, 15 Aug 2024 20:12:09 GMT, Valerie Peng wrote: >> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> addressed several review comments, namely: - renaming the getParameters >> method - renaming the AlgorithmParameterSpe

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v11]

2024-08-15 Thread Valerie Peng
On Thu, 15 Aug 2024 20:26:50 GMT, Valerie Peng wrote: >> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> addressed several review comments, namely: - renaming the getParameters >> method - renaming the AlgorithmParameterSpe

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v11]

2024-08-15 Thread Valerie Peng
On Tue, 13 Aug 2024 15:24:11 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another P

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v11]

2024-08-15 Thread Valerie Peng
On Tue, 13 Aug 2024 15:24:11 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another P

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v11]

2024-08-15 Thread Valerie Peng
On Tue, 13 Aug 2024 15:24:11 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another P

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v11]

2024-08-15 Thread Valerie Peng
On Tue, 13 Aug 2024 15:24:11 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another P

Re: RFR: 8319332: Security properties files inclusion [v19]

2024-08-15 Thread Sean Mullan
On Mon, 12 Aug 2024 21:20:18 GMT, Martin Balao wrote: > We've not made a decision in regards to proposing this enhancement to old > releases. With that said, I wouldn't consider anything older than 21u. If > necessary, we can make backport-specific adjustments to the CSR and be more > conserva

Re: RFR: 8336665: CCE in X509CRLImpl$TBSCertList.getCertIssuer [v2]

2024-08-15 Thread Mark Powers
On Mon, 12 Aug 2024 19:20:17 GMT, Sean Mullan wrote: >> Mark Powers has updated the pull request incrementally with one additional >> commit since the last revision: >> >> copyright and unnecessary initialization > > src/java.base/share/classes/sun/security/x509/X509CRLImpl.java line 291: >

RFR: 8338395: Add test coverage for instantiating NativePRNG with SecureRandomParameters

2024-08-15 Thread Fernando Guallini
In order to improve performance when instantiating NativePRNG, a dummy constructor was added in the PR: https://github.com/openjdk/jdk/pull/17560 which takes and ignores a `java.security.SecureRandomParameters`, throwing an exception if any parameter is passed. This PR adds test coverage for th