Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v11]

2024-08-13 Thread Valerie Peng
On Tue, 13 Aug 2024 15:24:11 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another P

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v11]

2024-08-13 Thread Valerie Peng
On Tue, 13 Aug 2024 15:24:11 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another P

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v10]

2024-08-13 Thread Valerie Peng
On Fri, 9 Aug 2024 01:40:51 GMT, Anthony Scarpino wrote: >> Kevin Driver has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 16 additional >> commit

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v11]

2024-08-13 Thread Valerie Peng
On Tue, 13 Aug 2024 15:24:11 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another P

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v11]

2024-08-13 Thread Valerie Peng
On Tue, 13 Aug 2024 15:24:11 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another P

Re: RFR: 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout

2024-08-13 Thread SendaoYan
On Sat, 20 Jul 2024 15:32:37 GMT, SendaoYan wrote: > Hi all, > The testcase > `test/jdk/security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#actalisauthenticationrootca` > run Error, because the `@run` set conflicted with `/manual` and `/timeout`. > I think the `/ti

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v11]

2024-08-13 Thread Valerie Peng
On Tue, 13 Aug 2024 15:24:11 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another P

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v11]

2024-08-13 Thread Valerie Peng
On Tue, 13 Aug 2024 15:24:11 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another P

Integrated: 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout

2024-08-13 Thread SendaoYan
On Sat, 20 Jul 2024 15:32:37 GMT, SendaoYan wrote: > Hi all, > The testcase > `test/jdk/security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#actalisauthenticationrootca` > run Error, because the `@run` set conflicted with `/manual` and `/timeout`. > I think the `/ti

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v11]

2024-08-13 Thread Valerie Peng
On Mon, 5 Aug 2024 18:00:08 GMT, Sean Mullan wrote: >> Not sure. Maybe your sentence is OK. > > I agree that this might lead to some question as to whether a `derive` method > can be called concurrently. I think we should just remove this sentence. I > think one should assume a method can be ca

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v11]

2024-08-13 Thread Valerie Peng
On Tue, 13 Aug 2024 15:24:11 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another P

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v10]

2024-08-13 Thread Valerie Peng
On Tue, 13 Aug 2024 14:42:23 GMT, Kevin Driver wrote: >> src/java.base/share/classes/javax/crypto/KDFSpi.java line 89: >> >>> 87: * @throws UnsupportedOperationException if this method is not >>> overridden >>> 88: * by a provider >>> 89: */ >> >> The method is abstract meaning

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v10]

2024-08-13 Thread Valerie Peng
On Tue, 13 Aug 2024 21:42:39 GMT, Valerie Peng wrote: >> @valeriepeng: Addressed in >> https://github.com/openjdk/jdk/pull/20301/commits/59a3f02015f7fc3ad81ca29b90d83b1c9bd70fc5. >> Please resolve this conversation if satisfied. > > Ok~ I don't see the resolve this conversation setting though.

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v10]

2024-08-13 Thread Valerie Peng
On Tue, 13 Aug 2024 15:21:16 GMT, Kevin Driver wrote: >> src/java.base/share/classes/javax/crypto/KDF.java line 149: >> >>> 147: } >>> 148: >>> 149: private KDF(Service s, Iterator t, String algorithm, >> >> nit: add comment that this constructor is used when no provider is supplied. >

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v10]

2024-08-13 Thread Valerie Peng
On Tue, 13 Aug 2024 14:31:59 GMT, Kevin Driver wrote: >> src/java.base/share/classes/javax/crypto/KDF.java line 52: >> >>> 50: * of methods. For https://www.rfc-editor.org/rfc/rfc5869";>RFC >>> 5869, >>> 51: * KDF algorithm names follow a naming convention of >>> 52: * AlgorithmWithPRF. For

Jdk 21 PKCS11 ECDH Key agreement failing

2024-08-13 Thread Pushkar Marathe
Hi I have some java code written using javax.crypto package which does a derivation using ht ECDH algorithm. This code is run against a HSM card and uses key pair on the hsm. Example code below: Provider CRYPTOKI_PROVIDER = Security.getProvider("SunPKCS11");     CRYPTOKI_PROVIDER =

RFR: 8232838: Update VerifyCACerts test to ensure cacerts contain entries for CA

2024-08-13 Thread Rajan Halade
Updated VerifyCACerts test to check if BasicConstraints lists "CA:true" and KeyUsage, if included, asserts the keyCertSign bit. - Commit messages: - 8232838: Update VerifyCACerts test to ensure cacerts contain entries for CA Changes: https://git.openjdk.org/jdk/pull/20573/files W

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v11]

2024-08-13 Thread Kevin Driver
On Tue, 13 Aug 2024 18:08:29 GMT, Valerie Peng wrote: >> Will discuss "offline" with the other `KDFParameters` & DPS discussion. > > This will imp[act the API, e.g. whether KDFSpi needs an > `engineGetKDFParameters()` method. BTW, I find the name > "KDFParameters" very confusing as there is a p

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v10]

2024-08-13 Thread Weijun Wang
On Tue, 13 Aug 2024 14:23:12 GMT, Kevin Driver wrote: >> src/java.base/share/classes/javax/crypto/KDF.java line 465: >> >>> 463: * permitting a {@code null} return value here, >>> implementations will >>> 464: * handle cases where a value cannot be returned by throwing an >>>

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v10]

2024-08-13 Thread Valerie Peng
On Fri, 2 Aug 2024 19:19:54 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another PR

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v10]

2024-08-13 Thread Valerie Peng
On Fri, 2 Aug 2024 19:19:54 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another PR

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v10]

2024-08-13 Thread Valerie Peng
On Tue, 13 Aug 2024 15:20:13 GMT, Kevin Driver wrote: >> src/java.base/share/classes/javax/crypto/KDF.java line 413: >> >>> 411: * algorithm >>> 412: * @throws InvalidAlgorithmParameterException >>> 413: * if the {@code KDFParameters} is an invalid value >> >> I don't thi

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v11]

2024-08-13 Thread Valerie Peng
On Fri, 2 Aug 2024 18:11:35 GMT, Kevin Driver wrote: >> src/java.base/share/classes/javax/crypto/KDF.java line 183: >> >>> 181: * if no additional parameters were provided >>> 182: */ >>> 183: public KDFParameters getKDFParameters() { >> >> I still want to know if this method alwa

Re: RFR: 8336665: CCE in X509CRLImpl$TBSCertList.getCertIssuer [v3]

2024-08-13 Thread Mark Powers
> https://bugs.openjdk.org/browse/JDK-8336665 Mark Powers has updated the pull request incrementally with one additional commit since the last revision: comment from Sean - Changes: - all: https://git.openjdk.org/jdk/pull/20528/files - new: https://git.openjdk.org/jdk/pull/20

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v10]

2024-08-13 Thread Kevin Driver
On Wed, 7 Aug 2024 23:50:16 GMT, Valerie Peng wrote: >> Kevin Driver has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 16 additional >> commits si

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v10]

2024-08-13 Thread Kevin Driver
On Mon, 5 Aug 2024 20:04:35 GMT, Sean Mullan wrote: >> Kevin Driver has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 16 additional >> commits sin

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v11]

2024-08-13 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). > > Work was begun in [another PR](https://github.com/openjdk/jdk/pull/18924). Kevin Driver

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v10]

2024-08-13 Thread Kevin Driver
On Sat, 3 Aug 2024 00:43:20 GMT, Valerie Peng wrote: >> Kevin Driver has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 16 additional >> commits si

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v10]

2024-08-13 Thread Kevin Driver
On Wed, 7 Aug 2024 21:37:23 GMT, Valerie Peng wrote: >> Kevin Driver has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 16 additional >> commits si

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v10]

2024-08-13 Thread Kevin Driver
On Mon, 5 Aug 2024 17:36:36 GMT, Sean Mullan wrote: >> Kevin Driver has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 16 additional >> commits sin