Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v10]

2024-08-06 Thread Valerie Peng
On Fri, 2 Aug 2024 19:19:54 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another PR

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v10]

2024-08-06 Thread Valerie Peng
On Fri, 2 Aug 2024 19:19:54 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another PR

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v10]

2024-08-06 Thread Valerie Peng
On Fri, 2 Aug 2024 19:19:54 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another PR

Re: RFR: 8319332: Security properties files inclusion [v17]

2024-08-06 Thread Martin Balao
On Tue, 6 Aug 2024 23:19:08 GMT, Martin Balao wrote: >> src/java.base/share/classes/java/security/Security.java line 901: >> >>> 899: if (SecPropLoader.isInclude(key)) { >>> 900: return; >>> 901: } >> >> Don't you want to throw an exception here? > > May be. This is

Re: RFR: 8319332: Security properties files inclusion [v18]

2024-08-06 Thread Francisco Ferrari Bihurriet
> The implementation of this proposal is based on the requirements, > specification and design choices described in the [JDK-8319332] ticket and > its respective CSR [JDK-8319333]. What follows are implementation notes > organized per functional component, with the purpose of assisting to naviga

Re: RFR: 8319332: Security properties files inclusion [v17]

2024-08-06 Thread Martin Balao
On Tue, 6 Aug 2024 21:02:50 GMT, Weijun Wang wrote: >> Francisco Ferrari Bihurriet has updated the pull request incrementally with >> two additional commits since the last revision: >> >> - Ensure Security::setProperty() cannot issue an include >> >>Co-authored-by: Martin Balao >>

Re: RFR: 8335288: SunPKCS11 initialization will call C_GetMechanismInfo on unsupported mechanisms

2024-08-06 Thread Martin Balao
On Wed, 17 Jul 2024 00:48:20 GMT, Valerie Peng wrote: > Can someone help review this fix? Changed the required-mechanism check by > checking if the particular mechanism is inside the list of enabled supported > mechanisms. This should be more reliable than calling C_GetMechanismInfo(..) > on t

Re: RFR: 8335288: SunPKCS11 initialization will call C_GetMechanismInfo on unsupported mechanisms

2024-08-06 Thread Martin Balao
On Tue, 6 Aug 2024 22:27:36 GMT, Martin Balao wrote: >> Can someone help review this fix? Changed the required-mechanism check by >> checking if the particular mechanism is inside the list of enabled supported >> mechanisms. This should be more reliable than calling C_GetMechanismInfo(..) >> o

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v10]

2024-08-06 Thread Valerie Peng
On Fri, 2 Aug 2024 19:19:54 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another PR

Re: RFR: 8319332: Security properties files inclusion [v17]

2024-08-06 Thread Weijun Wang
On Thu, 11 Jul 2024 19:41:56 GMT, Francisco Ferrari Bihurriet wrote: >> The implementation of this proposal is based on the requirements, >> specification and design choices described in the [JDK-8319332] ticket and >> its respective CSR [JDK-8319333]. What follows are implementation notes >>

Re: RFR: 8335172: Add manual steps to run security/auth/callback/TextCallbackHandler/Password.java test

2024-08-06 Thread Rajan Halade
On Mon, 29 Jul 2024 12:43:04 GMT, Fernando Guallini wrote: > The test: > **com/sun/security/auth/callback/TextCallbackHandler/Password.java** would > benefit from detailed manual steps to ensure it runs correctly. It was added > to the problem list because it was not executed properly and fai

Re: RFR: 8337826: Improve logging in OCSPTimeout and SimpleOCSPResponder to help diagnose JDK-8309754 [v2]

2024-08-06 Thread Jamil Nimeh
> This proposed enhancement adds logging to the OCSPTimeout test, which is > intermittently failing and difficult to reproduce. The hope is that with > extra logging enabled that additional clues as to the cause of these rare > failures will become apparent. > > JBS: https://bugs.openjdk.org/b

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v10]

2024-08-06 Thread Sean Mullan
On Thu, 1 Aug 2024 22:29:21 GMT, Weijun Wang wrote: >> I disagree. I think this is a helpful bit of info for the developer who may >> be surprised later by an `Exception`. > > OK. As long as the exception does not cover it. You should be careful putting the word "must" in an API specification -

Re: RFR: 8337826: Improve logging in OCSPTimeout and SimpleOCSPResponder to help diagnose JDK-8309754

2024-08-06 Thread Sean Mullan
On Mon, 5 Aug 2024 19:01:30 GMT, Jamil Nimeh wrote: > This proposed enhancement adds logging to the OCSPTimeout test, which is > intermittently failing and difficult to reproduce. The hope is that with > extra logging enabled that additional clues as to the cause of these rare > failures will