> Add a new system property to control the name comparison in keytab and ccache
> entry lookup.
Weijun Wang has updated the pull request incrementally with two additional
commits since the last revision:
- remove commented out code but leave comment
- fast fail and no need to check null
On Mon, 20 May 2024 22:36:54 GMT, Valerie Peng wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> enhance test
>
> src/java.security.jgss/share/classes/sun/security/krb5/PrincipalName.java
> line 635:
>
>> 633:
On Mon, 20 May 2024 18:38:15 GMT, Weijun Wang wrote:
>> Add a new system property to control the name comparison in keytab and
>> ccache entry lookup.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> enhance test
src/java.s
On Mon, 20 May 2024 18:39:31 GMT, Phil Race wrote:
>> make/conf/module-loader-map.conf line 105:
>>
>>> 103: java.smartcardio \
>>> 104: jdk.accessibility \
>>> 105: jdk.attach \
>>
>> The list of allowed modules has been rewritten from scratch, by looking at
>> the set of modules
On Mon, 13 May 2024 10:49:30 GMT, Maurizio Cimadamore
wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review comments
>
> make/conf/module-loader-map.conf line 105:
>
>> 103: java.smartcardio \
On Fri, 17 May 2024 13:38:25 GMT, Maurizio Cimadamore
wrote:
>> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting
>> the use of JNI in the following ways:
>>
>> * `System::load` and `System::loadLibrary` are now restricted methods
>> * `Runtime::load` and `Runtime::loa
> Add a new system property to control the name comparison in keytab and ccache
> entry lookup.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
enhance test
-
Changes:
- all: https://git.openjdk.org/jdk/pull/19216/file
On Mon, 20 May 2024 16:15:25 GMT, Weijun Wang wrote:
> > Are there any existing interoperability tests?
>
> Not with real KDCs, but I can probably enhance the test to cover the case
> when this prop is not set.
I can only confirm that the default behavior works with Active Directory KDC.
On Mon, 20 May 2024 16:11:35 GMT, Mark Powers wrote:
> Are there any existing interoperability tests?
Not with real KDCs, but I can probably enhance the test to cover the case when
this prop is not set.
> src/java.security.jgss/share/classes/sun/security/krb5/PrincipalName.java
> line 634:
>
On Mon, 13 May 2024 14:34:41 GMT, Weijun Wang wrote:
> Add a new system property to control the name comparison in keytab and ccache
> entry lookup.
Are there any existing interoperability tests?
-
PR Comment: https://git.openjdk.org/jdk/pull/19216#issuecomment-2120764622
On Mon, 13 May 2024 14:34:41 GMT, Weijun Wang wrote:
> Add a new system property to control the name comparison in keytab and ccache
> entry lookup.
LGTM
Only have one comment about existing code.
-
Marked as reviewed by mpowers (Committer).
PR Review: https://git.openjdk.org/jdk
On Mon, 13 May 2024 14:34:41 GMT, Weijun Wang wrote:
> Add a new system property to control the name comparison in keytab and ccache
> entry lookup.
src/java.security.jgss/share/classes/sun/security/krb5/PrincipalName.java line
634:
> 632: // if (this.nameType != pname.nameType) {
> 6
On Mon, 13 May 2024 14:34:41 GMT, Weijun Wang wrote:
> Add a new system property to control the name comparison in keytab and ccache
> entry lookup.
Marked as reviewed by michae...@github.com (no known OpenJDK username).
-
PR Review: https://git.openjdk.org/jdk/pull/19216#pullrequ
13 matches
Mail list logo
