Re: RFR: 8322767: TLS full handshake is slow with PKCS12KeyStore and X509KeyManagerImpl [v3]

2024-03-26 Thread Xue-Lei Andrew Fan
On Tue, 26 Mar 2024 06:00:33 GMT, Hai-May Chao wrote: >> For the PKIX KeyManager and PKCS12 Keystore, when the TLS server sends the >> ServerHello message and ultimately calls the >> X509KeyManagerImpl.chooseEngineServerAlias() method, it retrieves the >> private key from the keystore, decrypt

Re: RFR: 8322767: TLS full handshake is slow with PKCS12KeyStore and X509KeyManagerImpl [v3]

2024-03-26 Thread Hai-May Chao
On Tue, 26 Mar 2024 06:00:33 GMT, Hai-May Chao wrote: >> For the PKIX KeyManager and PKCS12 Keystore, when the TLS server sends the >> ServerHello message and ultimately calls the >> X509KeyManagerImpl.chooseEngineServerAlias() method, it retrieves the >> private key from the keystore, decrypt

Re: RFR: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic

2024-03-26 Thread Valerie Peng
On Tue, 26 Mar 2024 07:48:10 GMT, Daniel Jeliński wrote: > LGTM Thanks for the review~ - PR Comment: https://git.openjdk.org/jdk/pull/18387#issuecomment-2021625533

Re: RFR: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic

2024-03-26 Thread Valerie Peng
On Tue, 26 Mar 2024 19:35:29 GMT, Sean Mullan wrote: > Is "disableLegacy" a standard PKCS11 attribute we are introducing support > for? If so, I think a CSR is probably needed as it is kind of like a system > property. It's a configuration file option. Just for the uncommon case if users would

Re: RFR: 8261433: Better pkcs11 performance for libpkcs11:C_EncryptInit/libpkcs11:C_DecryptInit

2024-03-26 Thread Valerie Peng
On Tue, 26 Mar 2024 15:57:55 GMT, Prajwal Kumaraswamy wrote: > > > > Now that we are going with the normative version first, maybe we should > > > > make additional changes to clean up the flow further?Say, > > > > > > > > 1. update `jGCMParamsToCKGCMParamPtr(JNIEnv *env, jobject jParam, > >

Re: RFR: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic

2024-03-26 Thread Sean Mullan
On Wed, 20 Mar 2024 02:44:19 GMT, Valerie Peng wrote: > Existing legacy mechanism check disables mechanism(s) when the support is > partial, e.g. supports decryption but not encryption, or supports > verification but not signing. Some mechanisms can be used for both > encryption/decryption and

Re: RFR: 8328638: Fallback option for POST-only OCSP requests [v5]

2024-03-26 Thread Rajan Halade
On Mon, 25 Mar 2024 19:24:39 GMT, Aleksey Shipilev wrote: >> See the rationale/discussion in the bug. This patch introduces the option >> that allows to restore >> pre-[JDK-8179503](https://bugs.openjdk.org/browse/JDK-8179503) behavior. The >> default behavior does not change. Better suggestio

Re: RFR: 8328638: Fallback option for POST-only OCSP requests [v5]

2024-03-26 Thread Rajan Halade
On Tue, 26 Mar 2024 18:34:42 GMT, Aleksey Shipilev wrote: >> test/jdk/security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java >> line 478: >> >>> 476: * @library /test/lib >>> 477: * @build jtreg.SkippedException ValidatePathWithURL CAInterop >>> 478: * @run main/oth

Re: RFR: 8328957: Update PKCS11Test.java to not use hardcoded path [v2]

2024-03-26 Thread Martin Balao
On Tue, 26 Mar 2024 17:48:49 GMT, Matthew Donovan wrote: >> When resolving the location of the NSS library, the code appended a >> hard-coded path: `/nss/lib`. This makes it difficult for a person to specify >> the library when it is installed in a location such as `/usr/lib64`. >> >> In this

Re: RFR: 8328638: Fallback option for POST-only OCSP requests [v5]

2024-03-26 Thread Aleksey Shipilev
On Tue, 26 Mar 2024 18:10:39 GMT, Rajan Halade wrote: >> Aleksey Shipilev has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains five commits: >> >> - Merge branch 'master' into JDK-8328638-ocsp-post >> - Merge branch 'master' into JDK

Re: RFR: JDK-8327474 Review use of java.io.tmpdir in jdk tests [v4]

2024-03-26 Thread Bill Huang
> This task addresses an essential aspect of our testing infrastructure: the > proper handling and cleanup of temporary files and socket files created > during test execution. The motivation behind these changes is to prevent the > accumulation of unnecessary files in the default temporary direc

Re: RFR: 8328638: Fallback option for POST-only OCSP requests [v5]

2024-03-26 Thread Rajan Halade
On Mon, 25 Mar 2024 19:24:39 GMT, Aleksey Shipilev wrote: >> See the rationale/discussion in the bug. This patch introduces the option >> that allows to restore >> pre-[JDK-8179503](https://bugs.openjdk.org/browse/JDK-8179503) behavior. The >> default behavior does not change. Better suggestio

Re: RFR: 8328957: Update PKCS11Test.java to not use hardcoded path [v2]

2024-03-26 Thread Matthew Donovan
On Tue, 26 Mar 2024 16:31:06 GMT, Martin Balao wrote: > Hi @mpdonova , > > Thanks for contributing this fix. I've seen in java.nio.file.Files::find doc > an implementation note saying that it should be used in a try-with-resource > fashion to close the stream and any open directories. Should w

Re: RFR: 8328957: Update PKCS11Test.java to not use hardcoded path [v2]

2024-03-26 Thread Matthew Donovan
> When resolving the location of the NSS library, the code appended a > hard-coded path: `/nss/lib`. This makes it difficult for a person to specify > the library when it is installed in a location such as `/usr/lib64`. > > In this PR, I removed the hard-coded path and updated the code to searc

Re: RFR: JDK-8328501 Incorrect `@since` tags for security java security interfaces [v3]

2024-03-26 Thread Nizar Benalla
On Mon, 25 Mar 2024 22:51:48 GMT, Nizar Benalla wrote: >> For context, I am writing tests to check for accurate use of `@since` tags >> in documentation comments in source code. >> We're following these rules for now: >> >> ### Rule 1: Introduction of New Elements >> >> - If an element is new

Re: RFR: JDK-8328501 Incorrect `@since` tags for security java security interfaces [v3]

2024-03-26 Thread Nizar Benalla
On Mon, 25 Mar 2024 22:51:48 GMT, Nizar Benalla wrote: >> For context, I am writing tests to check for accurate use of `@since` tags >> in documentation comments in source code. >> We're following these rules for now: >> >> ### Rule 1: Introduction of New Elements >> >> - If an element is new

Re: RFR: JDK-8328501 Incorrect `@since` tags for security java security interfaces [v3]

2024-03-26 Thread Sean Mullan
On Mon, 25 Mar 2024 22:51:48 GMT, Nizar Benalla wrote: >> For context, I am writing tests to check for accurate use of `@since` tags >> in documentation comments in source code. >> We're following these rules for now: >> >> ### Rule 1: Introduction of New Elements >> >> - If an element is new

Re: RFR: 8328957: Update PKCS11Test.java to not use hardcoded path

2024-03-26 Thread Martin Balao
On Tue, 26 Mar 2024 14:02:27 GMT, Matthew Donovan wrote: > When resolving the location of the NSS library, the code appended a > hard-coded path: `/nss/lib`. This makes it difficult for a person to specify > the library when it is installed in a location such as `/usr/lib64`. > > In this PR,

Re: RFR: 8328638: Fallback option for POST-only OCSP requests [v5]

2024-03-26 Thread Aleksey Shipilev
On Tue, 26 Mar 2024 12:07:49 GMT, Sean Mullan wrote: > Looks good. Please also write a release note and I will review it. Here you go: https://bugs.openjdk.org/browse/JDK-8329111 - PR Comment: https://git.openjdk.org/jdk/pull/18408#issuecomment-2020848495

Re: RFR: 8261433: Better pkcs11 performance for libpkcs11:C_EncryptInit/libpkcs11:C_DecryptInit

2024-03-26 Thread Prajwal Kumaraswamy
On Mon, 25 Mar 2024 21:05:07 GMT, Valerie Peng wrote: > > > Now that we are going with the normative version first, maybe we should > > > make additional changes to clean up the flow further?Say, > > > > > > 1. update `jGCMParamsToCKGCMParamPtr(JNIEnv *env, jobject jParam, > > > CK_ULONG *pLen

Re: RFR: JDK-8327474 Review use of java.io.tmpdir in jdk tests [v3]

2024-03-26 Thread Michael McMahon
On Thu, 21 Mar 2024 17:13:46 GMT, Bill Huang wrote: >> This task addresses an essential aspect of our testing infrastructure: the >> proper handling and cleanup of temporary files and socket files created >> during test execution. The motivation behind these changes is to prevent the >> accumu

RFR: 8328957: Update PKCS11Test.java to not use hardcoded path

2024-03-26 Thread Matthew Donovan
When resolving the location of the NSS library, the code appended a hard-coded path: `/nss/lib`. This makes it difficult for a person to specify the library when it is installed in a location such as `/usr/lib64`. In this PR, I removed the hard-coded path and updated the code to search the spe

Re: RFR: 8328638: Fallback option for POST-only OCSP requests [v5]

2024-03-26 Thread Sean Mullan
On Mon, 25 Mar 2024 19:24:39 GMT, Aleksey Shipilev wrote: >> See the rationale/discussion in the bug. This patch introduces the option >> that allows to restore >> pre-[JDK-8179503](https://bugs.openjdk.org/browse/JDK-8179503) behavior. The >> default behavior does not change. Better suggestio

Re: RFR: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic

2024-03-26 Thread Daniel Jeliński
On Wed, 20 Mar 2024 02:44:19 GMT, Valerie Peng wrote: > Existing legacy mechanism check disables mechanism(s) when the support is > partial, e.g. supports decryption but not encryption, or supports > verification but not signing. Some mechanisms can be used for both > encryption/decryption and

Re: RFR: JDK-8327474 Review use of java.io.tmpdir in jdk tests [v3]

2024-03-26 Thread Andrey Turbanov
On Thu, 21 Mar 2024 17:13:46 GMT, Bill Huang wrote: >> This task addresses an essential aspect of our testing infrastructure: the >> proper handling and cleanup of temporary files and socket files created >> during test execution. The motivation behind these changes is to prevent the >> accumu

RFR: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic

2024-03-26 Thread Nicolas SIMIDE
Thank you Valerie PENG for your PR, that's exactly what we need for French Healthcare card. I look foorward to use this in the next release. Many thanks. Nicolas