RFR: 8320597: RSA signature verification fails on signed data that does not encode params correctly

2023-12-06 Thread Weijun Wang
Add a fallback if an RSA signature was generated without the NULL params in its encoded hash. - Commit messages: - chmod - the fix Changes: https://git.openjdk.org/jdk/pull/17002/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17002&range=00 Issue: https://bugs.openjdk.o

Integrated: 8318756 Create better internal buffer for AEADs

2023-12-06 Thread Anthony Scarpino
On Fri, 3 Nov 2023 04:08:27 GMT, Anthony Scarpino wrote: > Hi, > > I need a review for a new internal buffer class called AEADBufferStream. > AEADBufferStream extends ByteArrayOutputStream, but eliminates some data > checking and copying that are not necessary for what GaloisCounterMode.java

Re: RFR: 8318756 Create better internal buffer for AEADs [v6]

2023-12-06 Thread Daniel Jeliński
On Wed, 6 Dec 2023 16:48:57 GMT, Anthony Scarpino wrote: >> Hi, >> >> I need a review for a new internal buffer class called AEADBufferStream. >> AEADBufferStream extends ByteArrayOutputStream, but eliminates some data >> checking and copying that are not necessary for what GaloisCounterMode.

Re: RFR: 8318756 Create better internal buffer for AEADs [v6]

2023-12-06 Thread Anthony Scarpino
> Hi, > > I need a review for a new internal buffer class called AEADBufferStream. > AEADBufferStream extends ByteArrayOutputStream, but eliminates some data > checking and copying that are not necessary for what GaloisCounterMode.java > and ChaCha20Cipher.java need. > > The changes greates

Re: RFR: 8318756 Create better internal buffer for AEADs [v5]

2023-12-06 Thread Anthony Scarpino
> Hi, > > I need a review for a new internal buffer class called AEADBufferStream. > AEADBufferStream extends ByteArrayOutputStream, but eliminates some data > checking and copying that are not necessary for what GaloisCounterMode.java > and ChaCha20Cipher.java need. > > The changes greates

Re: RFR: 8318756 Create better internal buffer for AEADs [v4]

2023-12-06 Thread Anthony Scarpino
On Wed, 6 Dec 2023 07:24:08 GMT, Daniel Jeliński wrote: >> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> update > > src/java.base/share/classes/com/sun/crypto/provider/AEADBufferedStream.java > line 60: > >> 58: