On Thu, 9 Nov 2023 19:03:27 GMT, Sean Mullan wrote:
>> I'm not sure if the number 8 or 10 really make a good difference in
>> practice. No matter 8 or 10, if customers need lower value, they can
>> always consider adjusting it. My concern is mainly about compatibility
>> issues. If you wan
On Mon, 23 Oct 2023 16:23:55 GMT, Daniel Jeliński wrote:
> Remove the hardcoded maximum heap size.
>
> Verified that the benchmark now passes with 100 threads given sufficient heap:
>
> make test TEST=micro:CacheBench MICRO="OPTIONS=-t 100;JAVA_OPTIONS=-Xmx16g"
Marked as reviewed by redestad (
On Fri, 3 Nov 2023 22:18:22 GMT, Francisco Ferrari Bihurriet
wrote:
>> The implementation of this proposal is based on the requirements,
>> specification and design choices described in the [JDK-8319332] ticket and
>> its respective CSR [JDK-8319333]. What follows are implementation notes
>>
On Thu, 9 Nov 2023 20:46:31 GMT, Kevin Driver wrote:
>> Francisco Ferrari Bihurriet has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> 8319332: use Path::of(URI) to deal with file URLs
>>
>> Instead of the previously introduced FileURL
On Fri, 3 Nov 2023 22:18:22 GMT, Francisco Ferrari Bihurriet
wrote:
>> The implementation of this proposal is based on the requirements,
>> specification and design choices described in the [JDK-8319332] ticket and
>> its respective CSR [JDK-8319333]. What follows are implementation notes
>>
On Fri, 3 Nov 2023 22:18:22 GMT, Francisco Ferrari Bihurriet
wrote:
>> The implementation of this proposal is based on the requirements,
>> specification and design choices described in the [JDK-8319332] ticket and
>> its respective CSR [JDK-8319333]. What follows are implementation notes
>>
On Tue, 7 Nov 2023 20:04:11 GMT, Matthew Donovan wrote:
> In this PR, I included logic to skip tests on Oracle Linux prior to version
> 8. The NSS binaries we are using for testing use a newer version of GLIBC
> than is included with OL 7.9.
test/jdk/ProblemList.txt line 632:
> 630: sun/secu
On Mon, 30 Oct 2023 17:26:53 GMT, Yakov Shafranovich wrote:
> The various Zip/Jar-file related Java APIs have some long-standing
> differences or peculiarities with respect to the ZIP-file specification or
> compared to other implementations which should be documented in the API-doc.
> This do
On Thu, 9 Nov 2023 20:09:20 GMT, Sean Mullan wrote:
>> Please review the comment change in SSLConfiguration class that describes
>> TLS related system properties used to enforce certificate chain length.
>> Thanks.
>
> Marked as reviewed by mullan (Reviewer).
@seanjmullan Thanks for the review
On Wed, 8 Nov 2023 23:34:22 GMT, Hai-May Chao wrote:
> Please review the comment change in SSLConfiguration class that describes TLS
> related system properties used to enforce certificate chain length. Thanks.
This pull request has now been integrated.
Changeset: a95062b3
Author:Hai-May C
On Wed, 8 Nov 2023 23:34:22 GMT, Hai-May Chao wrote:
> Please review the comment change in SSLConfiguration class that describes TLS
> related system properties used to enforce certificate chain length. Thanks.
Marked as reviewed by mullan (Reviewer).
-
PR Review: https://git.open
On Mon, 23 Oct 2023 16:23:55 GMT, Daniel Jeliński wrote:
> Remove the hardcoded maximum heap size.
>
> Verified that the benchmark now passes with 100 threads given sufficient heap:
>
> make test TEST=micro:CacheBench MICRO="OPTIONS=-t 100;JAVA_OPTIONS=-Xmx16g"
Looks ok to me but I would reque
On Wed, 8 Nov 2023 04:18:24 GMT, Xue-Lei Andrew Fan wrote:
>> The choice of 8 for the client is mostly based on different processing
>> requirements and use cases for TLS client vs server certificate chains. If
>> we see evidence that 8 is too low, we can always consider adjusting it.
>
> I'm n
13 matches
Mail list logo
