Re: RFR: 8308453: Convert JKS test keystores in test/jdk/javax/net/ssl/etc to PKCS12 [v10]

2023-10-31 Thread Kevin Driver
On Tue, 31 Oct 2023 20:36:29 GMT, Weijun Wang wrote: >> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix indenting and wildcard imports > > test/jdk/javax/net/ssl/SSLSession/ResumeTLS13withSNI.java line 442: > >> 440:

Re: RFR: 8311546: Certificate name constraints improperly validated with leading period [v3]

2023-10-31 Thread Sean Mullan
On Tue, 31 Oct 2023 19:47:48 GMT, Ben Perez wrote: >> Updated the `constrains` method in `DNSName.java` to accept certificates >> with a leading period. > > Ben Perez has updated the pull request incrementally with one additional > commit since the last revision: > > removed set property Ma

Re: RFR: 8308453: Convert JKS test keystores in test/jdk/javax/net/ssl/etc to PKCS12 [v10]

2023-10-31 Thread Weijun Wang
On Tue, 31 Oct 2023 20:26:50 GMT, Kevin Driver wrote: >> JDK-8308453: JSSE regression test keystore migration from JKS to PKCS12 > > Kevin Driver has updated the pull request incrementally with one additional > commit since the last revision: > > fix indenting and wildcard imports test/jdk/j

Re: RFR: 8308453: Convert JKS test keystores in test/jdk/javax/net/ssl/etc to PKCS12 [v10]

2023-10-31 Thread Kevin Driver
> JDK-8308453: JSSE regression test keystore migration from JKS to PKCS12 Kevin Driver has updated the pull request incrementally with one additional commit since the last revision: fix indenting and wildcard imports - Changes: - all: https://git.openjdk.org/jdk/pull/16159/file

Re: RFR: 8308453: Convert JKS test keystores in test/jdk/javax/net/ssl/etc to PKCS12 [v9]

2023-10-31 Thread Kevin Driver
On Tue, 31 Oct 2023 20:17:59 GMT, Kevin Driver wrote: >> JDK-8308453: JSSE regression test keystore migration from JKS to PKCS12 > > Kevin Driver has updated the pull request incrementally with one additional > commit since the last revision: > > change getInstance to not require keystore typ

Re: RFR: 8308453: Convert JKS test keystores in test/jdk/javax/net/ssl/etc to PKCS12 [v9]

2023-10-31 Thread Kevin Driver
> JDK-8308453: JSSE regression test keystore migration from JKS to PKCS12 Kevin Driver has updated the pull request incrementally with one additional commit since the last revision: change getInstance to not require keystore type - Changes: - all: https://git.openjdk.org/jdk/pu

Re: RFR: 8311546: Certificate name constraints improperly validated with leading period [v3]

2023-10-31 Thread Ben Perez
> Updated the `constrains` method in `DNSName.java` to accept certificates with > a leading period. Ben Perez has updated the pull request incrementally with one additional commit since the last revision: removed set property - Changes: - all: https://git.openjdk.org/jdk/pull/

RFR: JDK-8318105 [jmh] the test java.security.HSS failed with 2 active threads

2023-10-31 Thread Mark Powers
https://bugs.openjdk.org/browse/JDK-8318105 - Commit messages: - @State(Scope.Thread) preference - first iteration Changes: https://git.openjdk.org/jdk/pull/16435/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16435&range=00 Issue: https://bugs.openjdk.org/browse/JDK-831

Re: [External] : Re: RFD: Services lockdown for security providers

2023-10-31 Thread Martin Balao
Hi Tony, Thanks for pointing this out. Your observation is right. We looked at this problem from a different angle, when defining internal consistency of a filter value as out of scope [1]. Our concern was that a filter value may render services unusable because of dependencies (e.g. Signatur

Integrated: 8311596: Add separate system properties for TLS server and client for maximum chain length

2023-10-31 Thread Hai-May Chao
On Fri, 4 Aug 2023 17:30:06 GMT, Hai-May Chao wrote: > Please review the enhancement for JDK-8311596 and its CSR JDK-8313236. Thank > you. This pull request has now been integrated. Changeset: 0064cf90 Author:Hai-May Chao URL: https://git.openjdk.org/jdk/commit/0064cf90ff7d575f3500

Re: RFR: 8311596: Add separate system properties for TLS server and client for maximum chain length [v11]

2023-10-31 Thread Hai-May Chao
> Please review the enhancement for JDK-8311596 and its CSR JDK-8313236. Thank > you. Hai-May Chao has updated the pull request incrementally with one additional commit since the last revision: typo fix - Changes: - all: https://git.openjdk.org/jdk/pull/15163/files - new: ht

Re: RFR: 8311596: Add separate system properties for TLS server and client for maximum chain length [v10]

2023-10-31 Thread Hai-May Chao
On Mon, 30 Oct 2023 22:08:44 GMT, Hai-May Chao wrote: >> Please review the enhancement for JDK-8311596 and its CSR JDK-8313236. Thank >> you. > > Hai-May Chao has updated the pull request incrementally with one additional > commit since the last revision: > > Updated to not longer than 80-ch

Re: RFR: 8311596: Add separate system properties for TLS server and client for maximum chain length [v9]

2023-10-31 Thread Hai-May Chao
On Tue, 31 Oct 2023 13:26:47 GMT, Sean Mullan wrote: >> Hai-May Chao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update comments and property process code > > src/java.base/share/classes/sun/security/ssl/SSLConfiguration.java line 16

Re: RFR: 8311546: Certificate name constraints improperly validated with leading period [v2]

2023-10-31 Thread Sean Mullan
On Fri, 27 Oct 2023 15:07:55 GMT, Sean Mullan wrote: >> Ben Perez has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated documentation, minor fixes in test > > test/jdk/sun/security/x509/DNSName/LeadingPeriod.java line 82: > >> 80:

Re: RFR: 8311596: Add separate system properties for TLS server and client for maximum chain length [v10]

2023-10-31 Thread Sean Mullan
On Mon, 30 Oct 2023 22:08:44 GMT, Hai-May Chao wrote: >> Please review the enhancement for JDK-8311596 and its CSR JDK-8313236. Thank >> you. > > Hai-May Chao has updated the pull request incrementally with one additional > commit since the last revision: > > Updated to not longer than 80-ch

Integrated: 8319136: Skip pkcs11 tests on linux-aarch64

2023-10-31 Thread Matthew Donovan
On Mon, 30 Oct 2023 19:57:02 GMT, Matthew Donovan wrote: > Due to test failures on OL 7.9 aarch64, this PR skips tests for LInux > aarch64. The MultipleLogin.sh script had to be added to the ProblemList > because it reported error when the Java component threw the skipped exception. > > Tests

Re: RFR: 8311596: Add separate system properties for TLS server and client for maximum chain length [v9]

2023-10-31 Thread Sean Mullan
On Mon, 30 Oct 2023 22:01:01 GMT, Hai-May Chao wrote: >> Please review the enhancement for JDK-8311596 and its CSR JDK-8313236. Thank >> you. > > Hai-May Chao has updated the pull request incrementally with one additional > commit since the last revision: > > Update comments and property pro

Re: RFR: 8319136: Skip pkcs11 tests on linux-aarch64 [v2]

2023-10-31 Thread Matthew Donovan
> Due to test failures on OL 7.9 aarch64, this PR skips tests for LInux > aarch64. The MultipleLogin.sh script had to be added to the ProblemList > because it reported error when the Java component threw the skipped exception. > > Tests will be fixed in JDK-8319128. Matthew Donovan has updated