Re: RFR: JDK-8314901: AES-GCM interleaved implementation using AVX2 instructions [v8]

2023-10-11 Thread Daniel Jeliński
On Wed, 11 Oct 2023 22:05:08 GMT, Smita Kamath wrote: >> Hi All, >> I would like to submit AES-GCM optimization for x86_64 architectures using >> AVX2 instructions. This optimization interleaves AES and GHASH operations. >> >> Below are the performance numbers on my desktop system with -XX:Use

Re: RFR: JDK-8314901: AES-GCM interleaved implementation using AVX2 instructions [v8]

2023-10-11 Thread Smita Kamath
> Hi All, > I would like to submit AES-GCM optimization for x86_64 architectures using > AVX2 instructions. This optimization interleaves AES and GHASH operations. > > Below are the performance numbers on my desktop system with -XX:UseAVX=2 > option: > > |Benchmark | Data Size | Base version (

Re: RFR: 8308453: Convert JKS test keystores in test/jdk/javax/net/ssl/etc to PKCS12

2023-10-11 Thread Mark Powers
On Wed, 11 Oct 2023 21:24:30 GMT, Kevin Driver wrote: > JDK-8308453: JSSE regression test keystore migration from JKS to PKCS12 Looks good to me. - PR Review: https://git.openjdk.org/jdk/pull/16159#pullrequestreview-1672643060

RFR: 8308453: Convert JKS test keystores in test/jdk/javax/net/ssl/etc to PKCS12

2023-10-11 Thread Kevin Driver
JDK-8308453: JSSE regression test keystore migration from JKS to PKCS12 - Commit messages: - JDK-8308453: JSSE regression test keystore migration from JKS to PKCS12 Changes: https://git.openjdk.org/jdk/pull/16159/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16159&range=00

Re: RFR: 8317967: Enhance test/jdk/javax/net/ssl/TLSCommon/SSLEngineTestCase.java to handle default cases [v3]

2023-10-11 Thread Rajan Halade
> Template is updated to handle default cases and will also throw an Error on > not supported test protocols. Rajan Halade has updated the pull request incrementally with one additional commit since the last revision: No default for test.security.protocol property - Changes: -

Re: RFR: 8317967: Enhance test/jdk/javax/net/ssl/TLSCommon/SSLEngineTestCase.java to handle default cases [v2]

2023-10-11 Thread Rajan Halade
> Template is updated to handle default cases and will also throw an Error on > not supported test protocols. Rajan Halade has updated the pull request incrementally with one additional commit since the last revision: Update DTLSv1.1 to DTLSv1.2 - Changes: - all: https://git.o

Re: RFR: 8317967: Enhance test/jdk/javax/net/ssl/TLSCommon/SSLEngineTestCase.java to handle default cases

2023-10-11 Thread Sean Mullan
On Wed, 11 Oct 2023 18:01:07 GMT, Rajan Halade wrote: > Template is updated to handle default cases and will also throw an Error on > not supported test protocols. Changes requested by mullan (Reviewer). test/jdk/javax/net/ssl/TLSCommon/SSLEngineTestCase.java line 742: > 740:

RFR: 8317967: Enhance test/jdk/javax/net/ssl/TLSCommon/SSLEngineTestCase.java to handle default cases

2023-10-11 Thread Rajan Halade
Template is updated to handle default cases and will also throw an Error on not supported test protocols. - Commit messages: - 8317967: Enhance test/jdk/javax/net/ssl/TLSCommon/SSLEngineTestCase.java to handle default cases Changes: https://git.openjdk.org/jdk/pull/16156/files We

Re: RFR: 8314283: Support for NSS tests on aarch64 platforms [v4]

2023-10-11 Thread Matthew Donovan
On Tue, 10 Oct 2023 18:08:59 GMT, Rajan Halade wrote: >> Matthew Donovan has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> commi

Integrated: 8314283: Support for NSS tests on aarch64 platforms

2023-10-11 Thread Matthew Donovan
On Fri, 25 Aug 2023 13:02:39 GMT, Matthew Donovan wrote: > This PR updates the version of NSS to 3.91 and includes aarch64 platforms. > > There is a related bug in PR (https://github.com/openjdk/jdk/pull/15217) so > we may want to wait for that to merge before merging this one. This pull reque

Re: RFR: 8314283: Support for NSS tests on aarch64 platforms [v4]

2023-10-11 Thread Matthew Donovan
> This PR updates the version of NSS to 3.91 and includes aarch64 platforms. > > There is a related bug in PR (https://github.com/openjdk/jdk/pull/15217) so > we may want to wait for that to merge before merging this one. Matthew Donovan has updated the pull request with a new target base due to

Re: RFR: JDK-8314901: AES-GCM interleaved implementation using AVX2 instructions [v7]

2023-10-11 Thread Daniel Jeliński
On Tue, 10 Oct 2023 23:49:18 GMT, Smita Kamath wrote: >> Hi All, >> I would like to submit AES-GCM optimization for x86_64 architectures using >> AVX2 instructions. This optimization interleaves AES and GHASH operations. >> >> Below are the performance numbers on my desktop system with -XX:Use

Re: RFR: 8315974: Make fields final in 'com.sun.crypto.provider' package [v2]

2023-10-11 Thread Andrey Turbanov
> A few classes in `com.sun.crypto.provider` package have non-final fields > which could easily be marked `final`. Andrey Turbanov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: - Merge remote-tracking branch 'origin

Re: RFR: 8315974: Make fields final in 'com.sun.crypto.provider' package

2023-10-11 Thread Andrey Turbanov
On Tue, 10 Oct 2023 04:17:47 GMT, Valerie Peng wrote: >> A few classes in `com.sun.crypto.provider` package have non-final fields >> which could easily be marked `final`. > > src/java.base/share/classes/com/sun/crypto/provider/EncryptedPrivateKeyInfo.java > line 1: > >> 1: /* > > Hmm, there i