On Tue, 10 Oct 2023 18:08:59 GMT, Rajan Halade <rhal...@openjdk.org> wrote:
>> Matthew Donovan has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> commits since the last revision: >> >> - removed other reference to x86 windows >> - Merge branch 'master' into pkcs11-nss-upgrade >> - removed 32-bit windows entry >> - Merge branch 'master' into pkcs11-nss-upgrade >> - Merge branch 'master' into pkcs11-nss-upgrade >> - 8314283: Support for NSS tests on aarch64 platforms > > test/jdk/sun/security/pkcs11/PKCS11Test.java line 936: > >> 934: organization = "jpg.tests.jdk.nsslib", >> 935: name = "nsslib-windows_x64", >> 936: revision = "3.46-VS2017", > > nsslib-windows_x86 support is not updated to 3.91. Is it possible to upgrade > this (although we don't have it as a supported platform) I spent a few hours trying to get this to compile but the build environment is corrupted somehow and didn't want to spend a lot of time on this since it's not supported. I can make a new bug to support if if we need it. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15429#discussion_r1355361879
