On Thu, 14 Sep 2023 03:23:55 GMT, Julian Waters wrote:
>> Julian Waters has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Document changes in awt_DnDDS.cpp
>
> Pinging
> @TheShermanTanker In my experience, getting reviews from all areas f
On Wed, 20 Sep 2023 21:56:50 GMT, Valerie Peng wrote:
> This PR reverts part of the changes under JDK-8312306 which zero-out the
> deserialized key bytes after an internal copy has been made. If considering
> the deserialized key bytes as input arguments, such cleaning action may be
> too aggr
On Thu, 24 Aug 2023 21:24:51 GMT, Alexey Bakhtin wrote:
>> JGSS is implemented in the JVM in 2 levels: the standard Java security
>> provider for Kerberos in sun.security.jgss.krb5.Krb5MechFactory and the JAAS
>> login module for Kerberos in com.sun.security.auth.module.Krb5LoginModule.
>> The
On Thu, 21 Sep 2023 19:08:16 GMT, Sean Mullan wrote:
>> Ben Perez has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed copyright, refactored test to get rid of runTest
>
> test/jdk/java/security/KeyStore/PKCS12/java.security line 2:
>
> Replaced "jks" with "pkcs12" in both the spec and fallback for
> `KeyStore.getDefaultType()`
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
Changed @run arguments to completely override java.security
-
Changes:
- all:
On Thu, 21 Sep 2023 17:25:34 GMT, Mark Powers wrote:
>> test/jdk/sun/security/x509/X509CRLImpl/UnexpectedNPE.java line 1:
>>
>>> 1: /*
>>
>> I would suggest write a new test, and you can use the
>> `Utils.runAndCheckException` to make it simpler.
>
> I can do that. My primary motivation for us
On Thu, 21 Sep 2023 15:55:24 GMT, Ben Perez wrote:
>> Replaced "jks" with "pkcs12" in both the spec and fallback for
>> `KeyStore.getDefaultType()`
>
> Ben Perez has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fixed copyright, refactored t
On Wed, 20 Sep 2023 19:51:28 GMT, Sean Mullan wrote:
> Please review this change to ensure this test is tested on different TLS
> protocols (1.0, 1.1, 1.2)
>
> I added a protocol parameter to the test arguments so that different
> protocols are tested. I also removed the boolean exportable arg
On Thu, 21 Sep 2023 16:12:47 GMT, Weijun Wang wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> comment from Valerie
>
> test/jdk/sun/security/x509/X509CRLImpl/UnexpectedNPE.java line 1:
>
>> 1: /*
>
> I would sugge
On Thu, 21 Sep 2023 13:29:10 GMT, Sean Mullan wrote:
>> Please review this change to ensure this test is tested on different TLS
>> protocols (1.0, 1.1, 1.2)
>>
>> I added a protocol parameter to the test arguments so that different
>> protocols are tested. I also removed the boolean exportabl
On Thu, 21 Sep 2023 13:30:07 GMT, Sean Mullan wrote:
>> test/jdk/sun/security/ssl/DHKeyExchange/DHEKeySizing.java line 35:
>>
>>> 33: * @library /javax/net/ssl/templates
>>> 34: * @run main/othervm -Djdk.tls.client.enableSessionTicketExtension=false
>>> 35: * DHEKeySizing TLS_DHE_RSA_WIT
On Thu, 21 Sep 2023 16:03:05 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8315042
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> comment from Valerie
test/jdk/sun/security/x509/X509CRLImpl/UnexpectedNPE.j
> https://bugs.openjdk.org/browse/JDK-8315042
Mark Powers has updated the pull request incrementally with one additional
commit since the last revision:
comment from Valerie
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15844/files
- new: https://git.openjdk.org/jdk/pull
> Replaced "jks" with "pkcs12" in both the spec and fallback for
> `KeyStore.getDefaultType()`
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
Fixed copyright, refactored test to get rid of runTest
-
Changes:
- all: http
> https://bugs.openjdk.org/browse/JDK-8296631
Mark Powers has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains five additional commits since
the last revisi
On Wed, 20 Sep 2023 21:56:50 GMT, Valerie Peng wrote:
> This PR reverts part of the changes under JDK-8312306 which zero-out the
> deserialized key bytes after an internal copy has been made. If considering
> the deserialized key bytes as input arguments, such cleaning action may be
> too aggr
On Thu, 21 Sep 2023 13:26:14 GMT, Michal Sobierski wrote:
>> sun/security/rsa/SignedObjectChain.java is very slow when run with C1, I
>> suspect because some crypto intrinsics are only implemented in C2. Commit
>> contains changes made to parallelize it.
>>
>> Comparison of before and after pa
On Thu, 21 Sep 2023 13:26:14 GMT, Michal Sobierski wrote:
>> sun/security/rsa/SignedObjectChain.java is very slow when run with C1, I
>> suspect because some crypto intrinsics are only implemented in C2. Commit
>> contains changes made to parallelize it.
>>
>> Comparison of before and after pa
On Wed, 20 Sep 2023 20:13:35 GMT, Jamil Nimeh wrote:
>> Sean Mullan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Only adjust sever hello size for TLS_DHE_RSA_WITH_AES_128_CBC_SHA with
>> TLSv1.2.
>> Fix some typos.
>
> test/jdk/sun
> Please review this change to ensure this test is tested on different TLS
> protocols (1.0, 1.1, 1.2)
>
> I added a protocol parameter to the test arguments so that different
> protocols are tested. I also removed the boolean exportable argument as it
> wasn't doing anything.
Sean Mullan has
> sun/security/rsa/SignedObjectChain.java is very slow when run with C1, I
> suspect because some crypto intrinsics are only implemented in C2. Commit
> contains changes made to parallelize it.
>
> Comparison of before and after parallelization:
> time make test TEST=jdk/sun/security/rsa/SignedO
sun/security/rsa/SignedObjectChain.java is very slow when run with C1, I
suspect because some crypto intrinsics are only implemented in C2. Commit
contains changes made to parallelize it.
Comparison of before and after parallelization:
time make test TEST=jdk/sun/security/rsa/SignedObjectChain.j
On Thu, 14 Sep 2023 03:23:55 GMT, Julian Waters wrote:
>> Julian Waters has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Document changes in awt_DnDDS.cpp
>
> Pinging
@TheShermanTanker In my experience, getting reviews from all areas for
On Tue, 8 Aug 2023 19:59:52 GMT, Thomas Stuefe wrote:
>> Julian Waters has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 25 commits:
>>
>> - Merge branch 'master' into patch-10
>> - Document changes in awt_DnDDS.cpp
>> - Remove n
On Tue, 8 Aug 2023 19:57:12 GMT, Thomas Stuefe wrote:
>> Julian Waters has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 22 additional
>> commits
25 matches
Mail list logo
