Re: RFR: 8304956: Update KeyStore.getDefaultType​() specification to return pkcs12 as fallback [v3]

2023-09-19 Thread Valerie Peng
On Tue, 19 Sep 2023 17:09:56 GMT, Ben Perez wrote: >> Replaced "jks" with "pkcs12" in both the spec and fallback for >> `KeyStore.getDefaultType()` > > Ben Perez has updated the pull request incrementally with one additional > commit since the last revision: > > Added test to check that when

Re: RFR: 8304956: Update KeyStore.getDefaultType​() specification to return pkcs12 as fallback [v3]

2023-09-19 Thread Valerie Peng
On Tue, 19 Sep 2023 17:09:56 GMT, Ben Perez wrote: >> Replaced "jks" with "pkcs12" in both the spec and fallback for >> `KeyStore.getDefaultType()` > > Ben Perez has updated the pull request incrementally with one additional > commit since the last revision: > > Added test to check that when

Re: RFR: JDK-8296631 NSS tests failing on OL9 linux-aarch64 hosts

2023-09-19 Thread Valerie Peng
On Mon, 18 Sep 2023 15:49:10 GMT, Mark Powers wrote: >> test/jdk/sun/security/pkcs11/Secmod/AddPrivateKey.java line 74: >> >>> 72: if (version == 0.0 || version >= 3.55) { >>> 73: useSqlite(true); >>> 74: } >> >> Instead of updating various tests with this block, how

Re: RFR: 8304956: Update KeyStore.getDefaultType​() specification to return pkcs12 as fallback [v3]

2023-09-19 Thread Hai-May Chao
On Tue, 19 Sep 2023 17:09:56 GMT, Ben Perez wrote: >> Replaced "jks" with "pkcs12" in both the spec and fallback for >> `KeyStore.getDefaultType()` > > Ben Perez has updated the pull request incrementally with one additional > commit since the last revision: > > Added test to check that when

Re: RFR: 8308995: Update Network IO JFR events to be static mirror events [v6]

2023-09-19 Thread Tim Prinzing
On Tue, 19 Sep 2023 15:35:11 GMT, Tim Prinzing wrote: >> The socket read/write JFR events currently use instrumentation of java.base >> code using templates in the jdk.jfr modules. This results in some java.base >> code residing in the jdk.jfr module which is undesirable. >> >> JDK19 added sta

Re: [External] : Re: RFD: Services lockdown for security providers

2023-09-19 Thread Anthony Scarpino
Hi Martin, Thanks for the proposal. Your documents mostly describe the solution. Can you provide more of the motivations and use-cases for the change? Do you see non FIPS-140 applications using this feature? The feature does provide a comprehensive filtering system for JCA. The syntax, while

Re: [External] : Re: PEM KeyStore Implementation

2023-09-19 Thread Anthony Scarpino
There are no doc links yet. Tony On 9/10/23 1:04 AM, Karl Scheibelhofer wrote: Hi Tony, The motivation was mostly about reading PEM keys and certificates generated somewhere else. This is common practice in enterprise environments I work in. Because corporate key material is subject to central

Re: RFR: 8304956: Update KeyStore.getDefaultType​() specification to return pkcs12 as fallback [v3]

2023-09-19 Thread Hai-May Chao
On Tue, 19 Sep 2023 17:16:58 GMT, Kevin Driver wrote: >> Ben Perez has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Added test to check that when keystore.type is null it defaults to pkcs12 > > @haimaychao Are any accompanying changes nee

Re: RFR: 8304956: Update KeyStore.getDefaultType​() specification to return pkcs12 as fallback [v3]

2023-09-19 Thread Kevin Driver
On Tue, 19 Sep 2023 17:09:56 GMT, Ben Perez wrote: >> Replaced "jks" with "pkcs12" in both the spec and fallback for >> `KeyStore.getDefaultType()` > > Ben Perez has updated the pull request incrementally with one additional > commit since the last revision: > > Added test to check that when

Re: RFR: 8304956: Update KeyStore.getDefaultType​() specification to return pkcs12 as fallback [v3]

2023-09-19 Thread Ben Perez
> Replaced "jks" with "pkcs12" in both the spec and fallback for > `KeyStore.getDefaultType()` Ben Perez has updated the pull request incrementally with one additional commit since the last revision: Added test to check that when keystore.type is null it defaults to pkcs12 - Cha

Integrated: 8308592: Framework for CA interoperability testing

2023-09-19 Thread Rajan Halade
On Wed, 31 May 2023 18:03:57 GMT, Rajan Halade wrote: > The new approach uses test URLs directly to verify interoperability with CA > infrastructure. This would help us avoid having regular test fixes to update > test artifacts as long as CAs keep test domains up to date. This pull request has

Re: RFR: 8308995: Update Network IO JFR events to be static mirror events [v6]

2023-09-19 Thread Tim Prinzing
> The socket read/write JFR events currently use instrumentation of java.base > code using templates in the jdk.jfr modules. This results in some java.base > code residing in the jdk.jfr module which is undesirable. > > JDK19 added static support for event classes. The old instrumentor classes

Re: RFR: 8308995: Update Network IO JFR events to be static mirror events [v5]

2023-09-19 Thread Daniel Fuchs
On Thu, 7 Sep 2023 21:50:17 GMT, Tim Prinzing wrote: >> The socket read/write JFR events currently use instrumentation of java.base >> code using templates in the jdk.jfr modules. This results in some java.base >> code residing in the jdk.jfr module which is undesirable. >> >> JDK19 added stat

Re: RFR: 8308995: Update Network IO JFR events to be static mirror events [v3]

2023-09-19 Thread Daniel Fuchs
On Thu, 7 Sep 2023 21:54:44 GMT, Tim Prinzing wrote: > No. I think it's a relic from the distant past though. I think the timeout > field should be removed. It's not used on SocketChannel at all, and it > doesn't seem useful on Socket. Should we log an RFE to that effect? - PR Re

Re: RFR: 8308995: Update Network IO JFR events to be static mirror events [v4]

2023-09-19 Thread Alan Bateman
On Wed, 6 Sep 2023 15:55:21 GMT, Tim Prinzing wrote: >>> https://bugs.openjdk.org/browse/JDK-8310979 - better exception handling >>> https://bugs.openjdk.org/browse/JDK-8310978 - missing code paths for event >>> generation https://bugs.openjdk.org/browse/JDK-8310994 - non-blocking, >>> event f