On Fri, 4 Aug 2023 21:40:37 GMT, Valerie Peng wrote:
> Why changing the ordering?
The order was changed to be parallel with that of `equals`.
> I was wondering if you'd change this to Objects.hash(...) with all the fields
> as arguments.
Sure, we could use a convenience method, but because `e
On Tue, 1 Aug 2023 08:57:56 GMT, Pavel Rappo wrote:
>> Please review this PR to use modern APIs and language features to simplify
>> `equals` and `hashCode` in security area.
>>
>> I understand that security area is sensitive and a non-expert, such as
>> myself, should tread carefully; so belo
On Tue, 1 Aug 2023 08:57:56 GMT, Pavel Rappo wrote:
>> Please review this PR to use modern APIs and language features to simplify
>> `equals` and `hashCode` in security area.
>>
>> I understand that security area is sensitive and a non-expert, such as
>> myself, should tread carefully; so belo
On Fri, 4 Aug 2023 19:54:58 GMT, Sean Mullan wrote:
> I would add to that list that I think it is really important any change to
> the `hashCode` impl doesn't break the equals/hashCode contract, so it's
> important to look at the `equals` implementation in conjunction with any
> changes to `ha
On Fri, 4 Aug 2023 19:45:34 GMT, Sean Mullan wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Feedback
>
> src/java.base/share/classes/com/sun/crypto/provider/DESKey.java line 113:
>
>> 111: public int hashCode(
On Fri, 4 Aug 2023 15:01:51 GMT, Pavel Rappo wrote:
>> src/java.base/share/classes/sun/security/x509/PolicyInformation.java line
>> 140:
>>
>>> 138: @Override
>>> 139: public int hashCode() {
>>> 140: return Objects.hash(policyIdentifier, policyQualifiers);
>>
>> What is the cr
On Tue, 1 Aug 2023 08:57:56 GMT, Pavel Rappo wrote:
>> Please review this PR to use modern APIs and language features to simplify
>> `equals` and `hashCode` in security area.
>>
>> I understand that security area is sensitive and a non-expert, such as
>> myself, should tread carefully; so belo
Please review the enhancement for JDK-8311596 and its CSR JDK-8313236. Thank
you.
-
Commit messages:
- 8311596: Add separate system properties for TLS server and client for
maximum chain length
Changes: https://git.openjdk.org/jdk/pull/15163/files
Webrev: https://webrevs.openjdk.
On Fri, 4 Aug 2023 00:04:03 GMT, Valerie Peng wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Feedback
>
> src/java.base/share/classes/sun/security/provider/certpath/CertId.java line
> 182:
>
>> 180: m
On Thu, 3 Aug 2023 21:43:44 GMT, Valerie Peng wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Feedback
>
> src/java.base/share/classes/sun/security/x509/PolicyInformation.java line 140:
>
>> 138: @Override
>> 1
On Fri, 4 Aug 2023 09:35:54 GMT, Pavel Rappo wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/PBKDF2KeyImpl.java line
>> 272:
>>
>>> 270: }
>>> 271:
>>> 272: if
>>> (!(that.getAlgorithm().equalsIgnoreCase(getAlgorithm({
>>
>> why removing the space be
On Thu, 3 Aug 2023 20:51:33 GMT, Valerie Peng wrote:
> This change addresses the scenario where a certificate is first stored as
> part of a certificate chain and then stored again as a certificate
> corresponding to a PrivateKey entry. Newer version of NSS errors out with
> CKR_GENERAL_ERROR
On Thu, 3 Aug 2023 22:49:46 GMT, Valerie Peng wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Feedback
>
> src/java.base/share/classes/com/sun/crypto/provider/PBKDF2KeyImpl.java line
> 272:
>
>> 270: }
Please review this patch that ensures that all exceptions thrown by SSLEngine
delegated tasks are translated to alerts.
All exceptions should already be translated to SSLExceptions and alerts by the
time we exit from context.dispatch; these exceptions are rethrown by
`conContext.fatal` without
14 matches
Mail list logo
