On Thu, 22 Jun 2023 09:58:19 GMT, Daniel Jeliński wrote:
>> Artem Semenov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update
>
> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 241:
>
>> 239: DISABLED_WARNINGS_
> On 22 Jun 2023, at 23:50, Peter Firmstone wrote:
>
>
> If you are able to share, I'd be interested to learn about challenges you had
> with SM, if we one day have the opportunity to reimplement it, the lessons
> might be valuable, so we can avoid the same mistakes.
Much of the effort has
> Added single-argument `putTime` method to `DerOutputStream` that selects the
> correct encoding based on the `Date` value. Similarly, a `getTime` method was
> added to `DerValue` to automatically call the correct decoding function based
> on the date type specified by the `tag`. Furthermore, t
On Thu, 22 Jun 2023 19:50:10 GMT, Jamil Nimeh wrote:
>> Ben Perez has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Replaced depreciated ctor in putTime. Added getTime method to
>> DerInputStream
>
> test/jdk/sun/security/util/DerOutputSt
On Thu, 22 Jun 2023 21:21:14 GMT, Ben Perez wrote:
>> Added single-argument `putTime` method to `DerOutputStream` that selects the
>> correct encoding based on the `Date` value. Similarly, a `getTime` method
>> was added to `DerValue` to automatically call the correct decoding function
>> base
Thanks Erik,
This is the best argument I've heard for removal so far. Note that I
understand it will be removed, I'm not arguing to keep it, we are stuck
with versions of OpenJDK that provide it, as there are no migration
options, I was hoping we might be able to reimplement it, but it's no
> Added single-argument `putTime` method to `DerOutputStream` that selects the
> correct encoding based on the `Date` value. Similarly, a `getTime` method was
> added to `DerValue` to automatically call the correct decoding function based
> on the date type specified by the `tag`. Furthermore, t
On Thu, 22 Jun 2023 18:45:14 GMT, Ben Perez wrote:
> Added single-argument `putTime` method to `DerOutputStream` that selects the
> correct encoding based on the `Date` value. Similarly, a `getTime` method was
> added to `DerValue` to automatically call the correct decoding function based
> on
Added single-argument `putTime` method to `DerOutputStream` that selects the
correct encoding based on the `Date` value. Similarly, a `getTime` method was
added to `DerValue` to automatically call the correct decoding function based
on the date type specified by the `tag`. Furthermore, the `enco
On Wed, 21 Jun 2023 18:46:41 GMT, Matthew Donovan wrote:
> In this PR I updated the EC key size and updated the regular expressions used
> to parse the output of the jarsigner. In addition to updating default key
> sizes base on Java version, I also updated the logic for determining the
> defa
> In this PR I updated the EC key size and updated the regular expressions used
> to parse the output of the jarsigner. In addition to updating default key
> sizes base on Java version, I also updated the logic for determining the
> default signing algorithm which is based on the version of jars
On Wed, 21 Jun 2023 18:46:41 GMT, Matthew Donovan wrote:
> In this PR I updated the EC key size and updated the regular expressions used
> to parse the output of the jarsigner. In addition to updating default key
> sizes base on Java version, I also updated the logic for determining the
> defa
On Thu, 22 Jun 2023 09:58:49 GMT, Daniel Jeliński wrote:
>> Artem Semenov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update
>
> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 260:
>
>> 258: DISABLED_WARNINGS_clang_ai
> When using the clang compiler to build OpenJDk on Linux, we encounter various
> "warnings as errors".
> They can be fixed with small changes.
Artem Semenov has updated the pull request incrementally with one additional
commit since the last revision:
update
-
Changes:
- all:
On Wed, 21 Jun 2023 14:50:21 GMT, Sergey Bylokhov wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [bdd81b31](https://github.com/openjdk/jdk/commit/bdd81b31825a9eb6a0f0883fca56a011ac2aebf8)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit
> I'd suggest cost of maintenance also appears overestimated
It isn’t. We have nothing to gain from removing a feature whose benefits
outweigh its cost
The cost is very high. I've spent probably a year on the SM just for jdk.jfr
module.
Erik
From: security-dev
On Thu, 22 Jun 2023 11:53:59 GMT, Daniel Fuchs wrote:
> The new code seems to accurately correspond to what the various
> `*Instrumentor` classes were doing, so that is good. I agree with Alan that
> potential exception that may arise when generating the event are an issue
> (e.g. call to getR
On Tue, 6 Jun 2023 19:39:31 GMT, Tim Prinzing wrote:
> The socket read/write JFR events currently use instrumentation of java.base
> code using templates in the jdk.jfr modules. This results in some java.base
> code residing in the jdk.jfr module which is undesirable.
>
> JDK19 added static su
> On 22 Jun 2023, at 02:21, Peter Firmstone wrote:
>
> This discussion on OpenSearch is worth a read.
> https://github.com/opensearch-project/OpenSearch/issues/1687
The cross-platform API (SystemCallFilter) is something that looks like it would
make for an interesting separate library.
I a
On Wed, 21 Jun 2023 15:48:30 GMT, Alan Bateman wrote:
>> The socket read/write JFR events currently use instrumentation of java.base
>> code using templates in the jdk.jfr modules. This results in some java.base
>> code residing in the jdk.jfr module which is undesirable.
>>
>> JDK19 added sta
On Tue, 6 Jun 2023 19:39:31 GMT, Tim Prinzing wrote:
> The socket read/write JFR events currently use instrumentation of java.base
> code using templates in the jdk.jfr modules. This results in some java.base
> code residing in the jdk.jfr module which is undesirable.
>
> JDK19 added static su
On Thu, 22 Jun 2023 09:13:21 GMT, Artem Semenov wrote:
>> When using the clang compiler to build OpenJDk on Linux, we encounter
>> various "warnings as errors".
>> They can be fixed with small changes.
>
> Artem Semenov has updated the pull request incrementally with one additional
> commit sin
On Wed, 21 Jun 2023 07:35:16 GMT, Daniel Jeliński wrote:
>> Artem Semenov has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains five commits:
>>
>> - update
>> - update
>> - update
>> - update
>> - 8308286 Fix clang warnings in lin
> When using the clang compiler to build OpenJDk on Linux, we encounter various
> "warnings as errors".
> They can be fixed with small changes.
Artem Semenov has updated the pull request incrementally with one additional
commit since the last revision:
update
-
Changes:
- all:
On Tue, 6 Jun 2023 19:39:31 GMT, Tim Prinzing wrote:
> The socket read/write JFR events currently use instrumentation of java.base
> code using templates in the jdk.jfr modules. This results in some java.base
> code residing in the jdk.jfr module which is undesirable.
>
> JDK19 added static su
On Wed, 21 Jun 2023 14:10:20 GMT, Matthias Baesken wrote:
> In src/java.base/macosx/native/libosxsecurity/KeystoreImpl.m there are a few
> JNU_CHECK_EXCEPTION macro usages that could potentially cause leaks.
This pull request has now been integrated.
Changeset: 7da3f199
Author:Matthias Bae
On Wed, 21 Jun 2023 14:10:20 GMT, Matthias Baesken wrote:
> In src/java.base/macosx/native/libosxsecurity/KeystoreImpl.m there are a few
> JNU_CHECK_EXCEPTION macro usages that could potentially cause leaks.
Hi Weijun, thanks for the review !
-
PR Comment: https://git.openjdk.org/
27 matches
Mail list logo
