On Wed, 3 May 2023 11:26:32 GMT, Matthew Donovan wrote:
>> In this PR, I added methods to the TransportContext class to synchronize
>> access to the handshakeContext field. I also updated locations in the code
>> that rely on the handshakeContext field to not be null to use the
>> synchronized
On Wed, 3 May 2023 11:26:32 GMT, Matthew Donovan wrote:
>> In this PR, I added methods to the TransportContext class to synchronize
>> access to the handshakeContext field. I also updated locations in the code
>> that rely on the handshakeContext field to not be null to use the
>> synchronized
On 16/06/2023 03:48, Peter Firmstone wrote:
:
As it isn't yet clear how a Subject context will be preserved across
threads in future version of OpenJDK, (currently we use the
AccessControlContext for that), for example we capture the existing
context, to establish TLS connections in call back
On Thu, 15 Jun 2023 06:02:13 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which fixes the issue noted in
> https://bugs.openjdk.org/browse/JDK-8310106?
>
> The commit here fixes the typo in
> `sun.security.ssl.SSLHandshake.getHandshakeProducer()` method to correctly
> u
On Thu, 15 Jun 2023 06:02:13 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which fixes the issue noted in
> https://bugs.openjdk.org/browse/JDK-8310106?
>
> The commit here fixes the typo in
> `sun.security.ssl.SSLHandshake.getHandshakeProducer()` method to correctly
> u
> Please review this PR which updates the JDK's localized resources since the
> previous L10n translation drop (1/26).
>
> To help with reviewing the changes, @jonathan-gibbons created a tool which
> displays the localized changes next to the original file's changes in UTF-8
> native. Those fil
On Thu, 15 Jun 2023 06:02:13 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which fixes the issue noted in
> https://bugs.openjdk.org/browse/JDK-8310106?
>
> The commit here fixes the typo in
> `sun.security.ssl.SSLHandshake.getHandshakeProducer()` method to correctly
> u
On Thu, 15 Jun 2023 06:02:13 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which fixes the issue noted in
> https://bugs.openjdk.org/browse/JDK-8310106?
>
> The commit here fixes the typo in
> `sun.security.ssl.SSLHandshake.getHandshakeProducer()` method to correctly
> u
On Fri, 16 Jun 2023 01:21:57 GMT, Weijun Wang wrote:
> The `attributes` field inside the `PKCS12KeyStore.Entry` class might be
> modified and retrieved at the same time. Make it concurrent.
>
> The test uses some reflection to get this field and try updating it in
> multiple threads.
Nice cat
Release Note: Alternate Subject.getSubject and doAs APIs Created That
Do Not Depend on Security Manager APIs
https://bugs.openjdk.org/browse/JDK-8280491
Just wondering about the future implementation plans for these new API's?
The implementation depends on deprecated for removal API's in JEP
The `attributes` field inside the `PKCS12KeyStore.Entry` class might be
modified and retrieved at the same time. Make it concurrent.
The test uses some reflection to get this field and try updating it in multiple
threads.
-
Commit messages:
- chmod a-x
- the fix
Changes: https:/
On Thu, 15 Jun 2023 20:57:44 GMT, Ben Perez wrote:
>> Changed `getEncoded` for both EC and RSA to return a copy of the internal
>> key array to avoid mutability issues.
>
> Ben Perez has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fixed co
On Thu, 15 Jun 2023 21:06:32 GMT, Kevin Rushforth wrote:
> Is the patch expected to be the same as in jdk mainline? I see some
> differences between the two patches (which is why Skara didn't mark it as
> "clean")
Hi Kevin, yes it is. I still need to grab the changes from mainline and include
On Mon, 12 Jun 2023 21:21:05 GMT, Justin Lu wrote:
> Please review this PR which updates the JDK's localized resources since the
> previous L10n translation drop (1/26).
>
> To help with reviewing the changes, @jonathan-gibbons created a tool which
> displays the localized changes next to the
> Changed `getEncoded` for both EC and RSA to return a copy of the internal key
> array to avoid mutability issues.
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
fixed copyrite date
-
Changes:
- all: https://git.openjd
On Mon, 12 Jun 2023 21:21:05 GMT, Justin Lu wrote:
> Please review this PR which updates the JDK's localized resources since the
> previous L10n translation drop (1/26).
>
> To help with reviewing the changes, @jonathan-gibbons created a tool which
> displays the localized changes next to the
On Mon, 12 Jun 2023 21:21:05 GMT, Justin Lu wrote:
> Please review this PR which updates the JDK's localized resources since the
> previous L10n translation drop (1/26).
>
> To help with reviewing the changes, @jonathan-gibbons created a tool which
> displays the localized changes next to the
On Thu, 15 Jun 2023 19:13:37 GMT, Ben Perez wrote:
>> Changed `getEncoded` for both EC and RSA to return a copy of the internal
>> key array to avoid mutability issues.
>
> Ben Perez has updated the pull request incrementally with one additional
> commit since the last revision:
>
> added co
On Mon, 12 Jun 2023 22:00:01 GMT, Justin Lu wrote:
> Please review this PR which updates the JDK's localized resources since the
> previous L10n translation drop (1/26).
>
> To help with reviewing the changes, @jonathan-gibbons created a tool which
> displays the localized changes next to the
On Mon, 5 Jun 2023 18:22:13 GMT, Matthew Donovan wrote:
> This PR implements a test to verify that Java will not negotiate TLS
> connections when one side of the connection requests disabled cipher suites.
This pull request has now been integrated.
Changeset: 9f64a643
Author:Matthew Donova
> Changed `getEncoded` for both EC and RSA to return a copy of the internal key
> array to avoid mutability issues.
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
added copyrite to test
-
Changes:
- all: https://git.ope
On Thu, 15 Jun 2023 17:26:10 GMT, Matthew Donovan wrote:
>> This PR implements a test to verify that Java will not negotiate TLS
>> connections when one side of the connection requests disabled cipher suites.
>
> Matthew Donovan has updated the pull request incrementally with one
> additional c
On Thu, 15 Jun 2023 17:22:53 GMT, Ben Perez wrote:
>> Changed `getEncoded` for both EC and RSA to return a copy of the internal
>> key array to avoid mutability issues.
>
> Ben Perez has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Remove
> This PR implements a test to verify that Java will not negotiate TLS
> connections when one side of the connection requests disabled cipher suites.
Matthew Donovan has updated the pull request incrementally with one additional
commit since the last revision:
added clarifying comment
--
> Changed `getEncoded` for both EC and RSA to return a copy of the internal key
> array to avoid mutability issues.
Ben Perez has updated the pull request incrementally with two additional
commits since the last revision:
- Removed unnecessary imports
- Removed unnecessary module in test. Cat
On Thu, 15 Jun 2023 12:33:45 GMT, Matthew Donovan wrote:
>> Yes, this is what I was thinking. There is another test
>> `test/jdk/javax/net/ssl/ciphersuites/DisabledAlgorithms.java` that is very
>> similar to this test. Can you compare these two tests and consider removing
>> that test, or comb
On Wed, 14 Jun 2023 20:38:18 GMT, Ben Perez wrote:
>> Changed `getEncoded` for both EC and RSA to return a copy of the internal
>> key array to avoid mutability issues.
>
> Ben Perez has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Changed
On Wed, 14 Jun 2023 13:43:37 GMT, Sean Mullan wrote:
>> I added all of the disable ciphers that are listed in DisabledAlgorithms.
>> Let me know if this isn't what you were thinking. Thanks!
>
> Yes, this is what I was thinking. There is another test
> `test/jdk/javax/net/ssl/ciphersuites/Disab
> This PR implements a test to verify that Java will not negotiate TLS
> connections when one side of the connection requests disabled cipher suites.
Matthew Donovan has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated chan
Can I please get a review of this change which fixes the issue noted in
https://bugs.openjdk.org/browse/JDK-8310106?
The commit here fixes the typo in
`sun.security.ssl.SSLHandshake.getHandshakeProducer()` method to correctly use
`handshakeProducers`.
I checked if a new jtreg test could be add
On Wed, 14 Jun 2023 11:39:14 GMT, Sean Coffey wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Incorp
31 matches
Mail list logo
