On Thu, 25 May 2023 21:17:40 GMT, Ben Perez wrote:
> Changed `namedParams` in XECParameters and EdDSAParameters to be `private
> final`
Marked as reviewed by xuelei (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/14162#pullrequestreview-1466696530
On Thu, 25 May 2023 21:17:40 GMT, Ben Perez wrote:
> Changed `namedParams` in XECParameters and EdDSAParameters to be `private
> final`
Looks good to me. Just a minor nit in each file: The copyrights on line 2 in
each file could be updated to 2023.
-
Marked as reviewed by jnimeh
> Can I please get reviews for this PR?
>
> The most common and frequent use of NonEscaping Phis merging object
> allocations is for debugging information. The two graphs below show numbers
> for Renaissance and DaCapo benchmarks - similar results are obtained for all
> other applications that
On Thu, 25 May 2023 21:17:40 GMT, Ben Perez wrote:
> Changed `namedParams` in XECParameters and EdDSAParameters to be `private
> final`
Hi Ben,
Please send an e-mail to dalibor.to...@oracle.com so that I can mark your
account as verified.
-
PR Comment: https://git.openjdk.org/j
Changed `namedParams` in XECParameters and EdDSAParameters to be `private final`
-
Commit messages:
- Formatted to adhere to the blessed modifier order
- Fixed accidental newline
- Formatting changes
- Changed namedParams to be private final static
- Revert "Changed namedParams t
On Tue, 6 Jun 2023 17:13:36 GMT, Ben Perez wrote:
>> test/jdk/sun/security/provider/DSA/SecureRandomReset.java line 28:
>>
>>> 26: * @bug 8308474
>>> 27: * @summary Test that calling initSign resets RNG
>>> 28: * @run main SecureRandomReset
>>
>> Not necessary if this is the only action in t
On Thu, 1 Jun 2023 21:17:11 GMT, Ben Perez wrote:
> Fixed `engineInitSign` in `DSA.java` and added `SecureRandomReset.java` to
> DSA tests
src/java.base/share/classes/sun/security/provider/DSA.java line 1:
> 1: /*
Update the copyright year for this file.
src/java.base/share/classes/sun/secur
On Tue, 6 Jun 2023 14:12:22 GMT, Weijun Wang wrote:
>> Fixed `engineInitSign` in `DSA.java` and added `SecureRandomReset.java` to
>> DSA tests
>
> test/jdk/sun/security/provider/DSA/SecureRandomReset.java line 28:
>
>> 26: * @bug 8308474
>> 27: * @summary Test that calling initSign resets RNG
Fixed `engineInitSign` in `DSA.java` and added `SecureRandomReset.java` to DSA
tests
-
Commit messages:
- Updated copywrite
- Removed redundant call to getSigningRandom, fixed test formatting
- Added test for RNG rest
- Removed misplaced call to getSigningRandom
- Added RNG rese
A trivial fix to ProblemList
sun/security/pkcs11/Signature/TestRSAKeyLength.java on macosx-x64 and
windows-x64.
The test is already ProblemListed on linux-all.
-
Commit messages:
- 8309570: ProblemList sun/security/pkcs11/Signature/TestRSAKeyLength.java
Changes: https://git.openj
On Tue, 6 Jun 2023 22:01:10 GMT, Daniel D. Daugherty wrote:
> A trivial fix to ProblemList
> sun/security/pkcs11/Signature/TestRSAKeyLength.java on macosx-x64 and
> windows-x64.
>
> The test is already ProblemListed on linux-all.
This pull request has now been integrated.
Changeset: 0ceb4322
On Tue, 6 Jun 2023 22:05:22 GMT, Jonathan Gibbons wrote:
>> A trivial fix to ProblemList
>> sun/security/pkcs11/Signature/TestRSAKeyLength.java on macosx-x64 and
>> windows-x64.
>>
>> The test is already ProblemListed on linux-all.
>
> Marked as reviewed by jjg (Reviewer).
@jonathan-gibbons a
On Tue, 6 Jun 2023 22:01:10 GMT, Daniel D. Daugherty wrote:
> A trivial fix to ProblemList
> sun/security/pkcs11/Signature/TestRSAKeyLength.java on macosx-x64 and
> windows-x64.
>
> The test is already ProblemListed on linux-all.
Marked as reviewed by darcy (Reviewer).
-
PR Revi
On Tue, 6 Jun 2023 22:01:10 GMT, Daniel D. Daugherty wrote:
> A trivial fix to ProblemList
> sun/security/pkcs11/Signature/TestRSAKeyLength.java on macosx-x64 and
> windows-x64.
>
> The test is already ProblemListed on linux-all.
Marked as reviewed by jjg (Reviewer).
-
PR Review
On Fri, 3 Feb 2023 01:41:41 GMT, Martin Balao wrote:
> We would like to propose an implementation for the [JDK-8301553: Support
> Password-Based Cryptography in
> SunPKCS11](https://bugs.openjdk.org/browse/JDK-8301553) enhancement
> requirement.
>
> In addition to pursuing the requirement goa
On Tue, 6 Jun 2023 18:18:43 GMT, Valerie Peng wrote:
>> Martin Balao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8301553: Support Password-Based Cryptography in SunPKCS11 (iteration #5)
>>
>> Co-authored-by: Francisco Ferrari
>
On Tue, 6 Jun 2023 04:15:21 GMT, Martin Balao wrote:
>> We would like to propose an implementation for the [JDK-8301553: Support
>> Password-Based Cryptography in
>> SunPKCS11](https://bugs.openjdk.org/browse/JDK-8301553) enhancement
>> requirement.
>>
>> In addition to pursuing the requireme
On Tue, 6 Jun 2023 17:32:35 GMT, Artem Semenov wrote:
>> I didn't ask to revert the change. It's
>> `s/TARGET_OS_MAC/defined(__APPLE__)/`.
>
> This is rarely used in the code and is not the essence of the current changes.
> If you introduce such changes, then throughout the code.
> Moreover, thi
On Thu, 1 Jun 2023 15:04:09 GMT, Weijun Wang wrote:
>> done
>
> I didn't ask to revert the change. It's `s/TARGET_OS_MAC/defined(__APPLE__)/`.
This is rarely used in the code and is not the essence of the current changes.
If you introduce such changes, then throughout the code.
Moreover, this ca
> Can I please get reviews for this PR?
>
> The most common and frequent use of NonEscaping Phis merging object
> allocations is for debugging information. The two graphs below show numbers
> for Renaissance and DaCapo benchmarks - similar results are obtained for all
> other applications that
> Can I please get reviews for this PR?
>
> The most common and frequent use of NonEscaping Phis merging object
> allocations is for debugging information. The two graphs below show numbers
> for Renaissance and DaCapo benchmarks - similar results are obtained for all
> other applications that
On Tue, 6 Jun 2023 07:15:08 GMT, Alan Bateman wrote:
>> There are cases in the sctp coding where a function
>> sctpHandleSocketErrorWithMessage would be beneficial (similar to existing
>> handleSocketErrorWithMessage) to provide more detail what failed.
>>
>> Additionally sctpHandleSocketError
On Tue, 6 Jun 2023 08:51:33 GMT, Daniel Fuchs wrote:
> FWIW the changes look good to me.
Thanks for looking into it.
-
PR Comment: https://git.openjdk.org/jdk/pull/14280#issuecomment-1578414732
On Fri, 2 Jun 2023 08:03:01 GMT, Matthias Baesken wrote:
> There are cases in the sctp coding where a function
> sctpHandleSocketErrorWithMessage would be beneficial (similar to existing
> handleSocketErrorWithMessage) to provide more detail what failed.
>
> Additionally sctpHandleSocketErrorW
On Fri, 2 Jun 2023 08:03:01 GMT, Matthias Baesken wrote:
> There are cases in the sctp coding where a function
> sctpHandleSocketErrorWithMessage would be beneficial (similar to existing
> handleSocketErrorWithMessage) to provide more detail what failed.
>
> Additionally sctpHandleSocketErrorW
On Tue, 6 Jun 2023 07:16:13 GMT, Alan Bateman wrote:
> I see this was integrated without a reviewer in the area but I think the
> changes are okay.
Hi Alan, I think Christoph is very competent in the area.
But should I look into the census next time for some special reviewer category
(and whic
On Fri, 2 Jun 2023 08:03:01 GMT, Matthias Baesken wrote:
> There are cases in the sctp coding where a function
> sctpHandleSocketErrorWithMessage would be beneficial (similar to existing
> handleSocketErrorWithMessage) to provide more detail what failed.
>
> Additionally sctpHandleSocketErrorW
On Fri, 2 Jun 2023 08:03:01 GMT, Matthias Baesken wrote:
> There are cases in the sctp coding where a function
> sctpHandleSocketErrorWithMessage would be beneficial (similar to existing
> handleSocketErrorWithMessage) to provide more detail what failed.
>
> Additionally sctpHandleSocketErrorW
On Fri, 2 Jun 2023 08:03:01 GMT, Matthias Baesken wrote:
> There are cases in the sctp coding where a function
> sctpHandleSocketErrorWithMessage would be beneficial (similar to existing
> handleSocketErrorWithMessage) to provide more detail what failed.
>
> Additionally sctpHandleSocketErrorW
29 matches
Mail list logo
