On Wed, 3 May 2023 20:51:30 GMT, Kevin Driver wrote:
>> Fixes a scenario where a `ServerHandshakeContext` might be cast as a
>> `ClientHandshakeContext`.
>
> Kevin Driver has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains three commit
Just a trivial change for enforcing consistent NullPointerException behavior
for the SecureRandom.nextBytes(byte[]) method.
Other similar methods such as Random.nextByte(byte[]) and its other subclasses
all throw NPE for null byte[] argument. Most JDK default providers'
SecureRandom impls also
On Wed, 3 May 2023 20:52:34 GMT, Kevin Driver wrote:
>> src/java.base/share/classes/sun/security/ssl/HandshakeContext.java line 457:
>>
>>> 455: // For TLS 1.2 and prior versions, the HelloRequest
>>> message MAY
>>> 456: // be sent by the server at any time.
>>> 457:
On Wed, 3 May 2023 20:51:30 GMT, Kevin Driver wrote:
>> Fixes a scenario where a `ServerHandshakeContext` might be cast as a
>> `ClientHandshakeContext`.
>
> Kevin Driver has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains three commit
On Fri, 28 Apr 2023 19:15:59 GMT, Kevin Driver wrote:
>> Fixes: [JDK-8294985](https://bugs.openjdk.org/browse/JDK-8294985)
>
> Kevin Driver has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update
> src/java.base/share/classes/sun/security/s
On Tue, 2 May 2023 16:35:18 GMT, Jiangli Zhou wrote:
> This PR was requested by awar...@google.com. The updates were provided by
> awar...@google.com.
This pull request has now been integrated.
Changeset: 03030d47
Author:Jiangli Zhou
URL:
https://git.openjdk.org/jdk/commit/03030d47
On Wed, 3 May 2023 17:42:14 GMT, Rajan Halade wrote:
> Looks good to me. Please don't forget to update the release note and backport
> to JDK 20u.
Thanks @rhalade. Will do.
-
PR Comment: https://git.openjdk.org/jdk/pull/13754#issuecomment-1533751038
On Fri, 28 Apr 2023 21:59:41 GMT, Mark Powers wrote:
>> Kevin Driver has updated the pull request with a new target base due to a
>> merge or a rebase.
>
> src/java.base/share/classes/sun/security/ssl/HandshakeContext.java line 457:
>
>> 455: // For TLS 1.2 and prior versions, the H
> Fixes a scenario where a `ServerHandshakeContext` might be cast as a
> `ClientHandshakeContext`.
Kevin Driver has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains three commits:
- address code review comment
- updated copyright
- set
On Fri, 28 Apr 2023 21:58:04 GMT, Mark Powers wrote:
>> Kevin Driver has updated the pull request with a new target base due to a
>> merge or a rebase.
>
> src/java.base/share/classes/sun/security/ssl/HandshakeContext.java line 2:
>
>> 1: /*
>> 2: * Copyright (c) 2018, 2022, 2023, Oracle and/o
On Fri, 28 Apr 2023 20:55:33 GMT, Kevin Driver wrote:
> Fix type-o and update returns message.
This pull request has now been integrated.
Changeset: db8b3cd0
Author:Kevin Driver
Committer: Bradford Wetmore
URL:
https://git.openjdk.org/jdk/commit/db8b3cd0842c05396d74abe950a210365451
On Fri, 28 Apr 2023 20:55:33 GMT, Kevin Driver wrote:
> Fix type-o and update returns message.
@seanjmullan @valeriepeng : see 57e7f9951d21fe2be6466e1c10f3b3cdd53e64b4
-
PR Comment: https://git.openjdk.org/jdk/pull/13729#issuecomment-1533708955
> Fix type-o and update returns message.
Kevin Driver has refreshed the contents of this pull request, and previous
commits have been removed. Incremental views are not available. The pull
request now contains two commits:
- address code review comments
- JDK-8305963 fix type-o and update ret
> Fix type-o and update returns message.
Kevin Driver has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains four additional commits since
the last revision:
On Fri, 21 Apr 2023 19:23:37 GMT, Vladimir Kozlov wrote:
>>> Again got failures in the test on Aarch64 running with -XX:-UseTLAB:
>>>
>>> ```
>>> testCmpMergeWithNull(boolean,int,int):
>>> - Failed comparison: [found] 0 = 2 [given]
>>> testCmpMergeWithNull_Second(boolean,int,int)
>>> - Failed co
On Mon, 17 Apr 2023 13:25:53 GMT, Matthew Donovan wrote:
> I refactored tests in the test/jdk/javax/net/ssl directories to use the test
> template classes.
This pull request has now been integrated.
Changeset: 705ad7d8
Author:Matthew Donovan
Committer: Xue-Lei Andrew Fan
URL:
http
On Tue, 2 May 2023 21:27:18 GMT, Jiangli Zhou wrote:
>> This PR was requested by awar...@google.com. The updates were provided by
>> awar...@google.com.
>
> Jiangli Zhou has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update test/jdk/sun/s
On Tue, 2 May 2023 18:42:36 GMT, Rajan Halade wrote:
>> This PR was requested by awar...@google.com. The updates were provided by
>> awar...@google.com.
>
>> > >
>> >
>> >
>> > I have infra tests for interop implemented. @jianglizhou, please check
>> > https://github.com/openjdk/jdk/compare/
> This set of enhancements extends the allowed syntax for the
> `com.sun.security.ocsp.timeout`, `com.sun.security.crl.timeout` and
> `com.sun.security.crl.readtimeout` System properties. These properties
> retain their current behavior where a purely numeric value is interpreted in
> seconds,
On Tue, 2 May 2023 21:27:18 GMT, Jiangli Zhou wrote:
>> This PR was requested by awar...@google.com. The updates were provided by
>> awar...@google.com.
>
> Jiangli Zhou has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update test/jdk/sun/s
On Wed, 3 May 2023 11:26:32 GMT, Matthew Donovan wrote:
>> In this PR, I added methods to the TransportContext class to synchronize
>> access to the handshakeContext field. I also updated locations in the code
>> that rely on the handshakeContext field to not be null to use the
>> synchronized
> The KEM API and DHKEM impl. Note that this PR uses new methods in
> https://github.com/openjdk/jdk/pull/13250.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
Resolve Siba's comment
-
Changes:
- all: https://git.open
On Wed, 3 May 2023 06:04:51 GMT, Sibabrata Sahoo wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> more @since and about nulls
>
> test/jdk/com/sun/crypto/provider/DHKEM/Compliance.java line 112:
>
>> 110:
On Wed, 3 May 2023 05:22:04 GMT, Sibabrata Sahoo wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> more @since and about nulls
>
> test/jdk/com/sun/crypto/provider/DHKEM/Compliance.java line 97:
>
>> 95: // C
> In this PR, I added methods to the TransportContext class to synchronize
> access to the handshakeContext field. I also updated locations in the code
> that rely on the handshakeContext field to not be null to use the
> synchronized methods.
>
> Thanks
Matthew Donovan has updated the pull re
On Thu, 27 Apr 2023 15:40:53 GMT, Weijun Wang wrote:
>> The KEM API and DHKEM impl. Note that this PR uses new methods in
>> https://github.com/openjdk/jdk/pull/13250.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> more @s
26 matches
Mail list logo
