On Thu, 27 Apr 2023 22:53:04 GMT, Anthony Scarpino
wrote:
> I feel the use of `from` and `to` is error prone. I know I never remember if
> Arrays.copyOfRange() includes or excludes the `to` index. I think less
> mistakes would be made if it used `index` and `length` instead.
My feeling is tha
On Thu, 27 Apr 2023 23:06:40 GMT, Mark Powers wrote:
>> Convert CRLF to LF in these files so it's consistent with other source files.
>
> LGTM
> I wrote a program to count CRLF in the four changed files in order to verify
> your fix.
@mcpowers I looked at the lower-right corner of IntelliJ IDEA
On Thu, 27 Apr 2023 20:33:38 GMT, Cesar Soares Lucas
wrote:
>> src/hotspot/share/code/debugInfo.hpp line 199:
>>
>>> 197: // ObjectValue describing an object that was scalar replaced.
>>> 198:
>>> 199: class ObjectMergeValue: public ObjectValue {
>>
>> I find the decision to subclass`ObjectVa
On Thu, 27 Apr 2023 23:35:02 GMT, Vladimir Ivanov wrote:
>> Hi @iwanowww . I finished implementing a version of this like the
>> illustration below (I didn't add a Candidate class).
>>
>>
>> ScopeValue
>> ObjectValue
>> ObjectAllocationValue
>> AutoBoxObjectValue
>>
Implement support for Leighton-Micali Signatures (LMS) as described in RFC
8554. LMS is an approved software signing algorithm for CNSA 2.0, with
SHA-256/192 parameters recommended.
-
Commit messages:
- LMS and HSS classes
Changes: https://git.openjdk.org/jdk/pull/13691/files
Web
On Thu, 27 Apr 2023 19:01:07 GMT, Weijun Wang wrote:
> Convert CRLF to LF in these files so it's consistent with other source files.
LGTM
I wrote a program to count CRLF in the four changed files in order to verify
your fix.
-
PR Review: https://git.openjdk.org/jdk/pull/13700#pull
On Thu, 27 Apr 2023 15:40:53 GMT, Weijun Wang wrote:
>> The KEM API and DHKEM impl. Note that this PR uses new methods in
>> https://github.com/openjdk/jdk/pull/13250.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> more @s
On Thu, 27 Apr 2023 14:16:34 GMT, Ferenc Rakoczi wrote:
> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
> SHA-256/192 parameters recommended.
src/java.base/share/classes/sun/security/provider/
On Sat, 22 Apr 2023 01:42:41 GMT, Vladimir Ivanov wrote:
>> Cesar Soares Lucas has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 10 commits:
>>
>> - Catching up with master
>>
>>Merge remote-tracking branch 'origin/master'
Hi All,
We haven't gotten enough feedback on the proposed new APIs and decide to drop
this JEP from JDK 21. It's still open and we can reconsider it in a future
release.
We are still planning on an implementation on signature verification targeting
JDK 21. You can read the CSR at https://bugs.
Convert CRLF to LF in these files so it's consistent with other source files.
-
Commit messages:
- the fix
Changes: https://git.openjdk.org/jdk/pull/13700/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13700&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8307077
St
This PR is to add new root certificate from TWCA root. This CA has gone through
https://www.oracle.com/java/technologies/javase/carootcertsprogram.html process.
-
Commit messages:
- 8305975: Add TWCA Global Root CA
- Merge branch 'master' into twca-certify
- Merge branch 'master'
On Thu, 27 Apr 2023 13:22:38 GMT, Sean Mullan wrote:
>> I checked for our implementations, and until now all I found is IKE. Even
>> the PBEWithMD5AndDES algorithm mentioned in
>> https://bugs.openjdk.org/browse/JDK-4953551 also throws an IKE.
>>
>> I'd rather follow the existing style. If it’
On Mon, 24 Apr 2023 19:55:34 GMT, Weijun Wang wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/DHKEM.java line 366:
>>
>>> 364: private static byte[] concat(byte[]... inputs) {
>>> 365: ByteArrayOutputStream o = new ByteArrayOutputStream();
>>> 366: Arrays.stream
On Thu, 27 Apr 2023 00:12:58 GMT, Jiangli Zhou wrote:
> Resolve misc symbol issues observed when statically linking JDK/VM natives
> with the standard Java launcher executable. Use the same approaches adopted
> by earlier fixes for static linking related symbol problems (e.g.
> JDK-8306033):
>
On Thu, 27 Apr 2023 15:22:17 GMT, Weijun Wang wrote:
>> The KEM API and DHKEM impl. Note that this PR uses new methods in
>> https://github.com/openjdk/jdk/pull/13250.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> more @s
On Thu, 27 Apr 2023 14:38:26 GMT, Weijun Wang wrote:
>> src/java.base/share/classes/javax/crypto/KEM.java line 100:
>>
>>> 98: * @see Encapsulator#encapsulate(int, int, String)
>>> 99: */
>>> 100: public static final class Encapsulated {
>>
>> Missing `@since 21`.
>
> I thought th
> The KEM API and DHKEM impl. Note that this PR uses new methods in
> https://github.com/openjdk/jdk/pull/13250.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
more @since and about nulls
-
Changes:
- all: https://git
On Thu, 27 Apr 2023 00:12:58 GMT, Jiangli Zhou wrote:
> Resolve misc symbol issues observed when statically linking JDK/VM natives
> with the standard Java launcher executable. Use the same approaches adopted
> by earlier fixes for static linking related symbol problems (e.g.
> JDK-8306033):
>
On Thu, 27 Apr 2023 12:54:03 GMT, Sean Mullan wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> no more pk/sk, AIOOBE to IOOBE
>
> src/java.base/share/classes/javax/crypto/KEM.java line 90:
>
>> 88:
>> 89: /**
>
On Thu, 27 Apr 2023 00:12:58 GMT, Jiangli Zhou wrote:
> Resolve misc symbol issues observed when statically linking JDK/VM natives
> with the standard Java launcher executable. Use the same approaches adopted
> by earlier fixes for static linking related symbol problems (e.g.
> JDK-8306033):
>
On Wed, 26 Apr 2023 19:02:53 GMT, Weijun Wang wrote:
>> The KEM API and DHKEM impl. Note that this PR uses new methods in
>> https://github.com/openjdk/jdk/pull/13250.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> no more
On Wed, 26 Apr 2023 21:36:19 GMT, Weijun Wang wrote:
> I checked for our implementations, and until now all I found is IKE. Even the
> PBEWithMD5AndDES algorithm mentioned in
> https://bugs.openjdk.org/browse/JDK-4953551 also throws an IKE.
>
> I'd rather follow the existing style. If it’s not
> The KEM API and DHKEM impl. Note that this PR uses new methods in
> https://github.com/openjdk/jdk/pull/13250.
Weijun Wang has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The
On Thu, 27 Apr 2023 00:12:58 GMT, Jiangli Zhou wrote:
> Resolve misc symbol issues observed when statically linking JDK/VM natives
> with the standard Java launcher executable. Use the same approaches adopted
> by earlier fixes for static linking related symbol problems (e.g.
> JDK-8306033):
>
25 matches
Mail list logo
