On Wed, 26 Apr 2023 19:02:53 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> The KEM API and DHKEM impl. Note that this PR uses new methods in >> https://github.com/openjdk/jdk/pull/13250. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > no more pk/sk, AIOOBE to IOOBE src/java.base/share/classes/javax/crypto/KEM.java line 90: > 88: > 89: /** > 90: * This class specifies the returned value of the encapsulate method > of s/returned/return/ src/java.base/share/classes/javax/crypto/KEM.java line 100: > 98: * @see Encapsulator#encapsulate(int, int, String) > 99: */ > 100: public static final class Encapsulated { Missing `@since 21`. src/java.base/share/classes/javax/crypto/KEM.java line 148: > 146: * Returns the optional parameters in a byte array. > 147: * > 148: * @return the optional parameters in a byte array. A new copy > of the Should probably say "the optional parameters in a byte array or `null` if not specified`. src/java.base/share/classes/javax/crypto/KEM.java line 239: > 237: * Returns the size of the shared secret. > 238: * <p> > 239: * This method can be called to find out the length of the share > secret s/share/shared/ src/java.base/share/classes/javax/crypto/KEM.java line 362: > 360: * Returns the size of the shared secret. > 361: * <p> > 362: * This method can be called to find out the length of the share > secret s/share/shared/ ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13256#discussion_r1179113396 PR Review Comment: https://git.openjdk.org/jdk/pull/13256#discussion_r1179115920 PR Review Comment: https://git.openjdk.org/jdk/pull/13256#discussion_r1179119002 PR Review Comment: https://git.openjdk.org/jdk/pull/13256#discussion_r1179122638 PR Review Comment: https://git.openjdk.org/jdk/pull/13256#discussion_r1179127665
