On Thu, 26 Jan 2023 18:33:38 GMT, Rajan Halade wrote:
>> * updated test for new TLS protocols and ciphersuites
>> * code cleanup
>
> test/jdk/javax/net/ssl/SSLEngine/TestAllSuites.java line 333:
>
>> 331:
>> 332: enum SupportedCipherSuites {
>> 333: TLSv11("TLSv1.1", new String []{
On Thu, 26 Jan 2023 12:30:25 GMT, Weijun Wang wrote:
>> Hai-May Chao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update with Max's comment
>
> I said "one solution is to add RC2_40 and RC2_128" but now I'm not sure if
> it's the rig
On Wed, 23 Nov 2022 23:39:03 GMT, Valerie Peng wrote:
> This RFE enhances existing PBE algorithms with the "SHA512/224" and
> "SHA512/256" support.
> Current transformation parsing in javax.crypto.Cipher class is re-written to
> handle the additional "/" in the "SHA512/224" and "SHA512/256" al
On Thu, 5 Jan 2023 21:55:42 GMT, Matthew Donovan wrote:
> * Updated the test for changes to the TLS implementation
> * Test supports TLS 1.2 and 1.3
> * Removed from ProblemList.txt
> * Refactored code a bit
This pull request has now been integrated.
Changeset: d6007a35
Author:Matthew Donov
On Thu, 26 Jan 2023 19:06:40 GMT, Matthew Donovan wrote:
> fixed copyright header
Marked as reviewed by rhalade (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/12232
On Thu, 26 Jan 2023 19:06:40 GMT, Matthew Donovan wrote:
> fixed copyright header
This pull request has now been integrated.
Changeset: 7ddafd75
Author:Matthew Donovan
Committer: Rajan Halade
URL:
https://git.openjdk.org/jdk/commit/7ddafd75b02c3083264239404b1c33d219e2cd2b
Stats:
On Thu, 26 Jan 2023 19:06:40 GMT, Matthew Donovan wrote:
> fixed copyright header
Thumbs up. This is a trivial fix.
The file is also missing an EOL on the last line.
-
Marked as reviewed by dcubed (Reviewer).
PR: https://git.openjdk.org/jdk/pull/12232
fixed copyright header
-
Commit messages:
- added newline at end of file
- 8301189: validate-source fails after JDK-8298873
Changes: https://git.openjdk.org/jdk/pull/12232/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12232&range=00
Issue: https://bugs.openjdk.org/brows
On Mon, 9 Jan 2023 12:19:27 GMT, Matthew Donovan wrote:
> Refactored the code a little bit and updated the test for changes to the TLS
> state machine.
test/jdk/javax/net/ssl/SSLEngine/EngineCloseOnAlert.java line 67:
> 65:
> 66: public static void main(String[] args) throws Exception {
>
On Thu, 12 Jan 2023 16:03:34 GMT, Xue-Lei Andrew Fan wrote:
>> Matthew Donovan has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - renamed IllegalRecordVersion to HandshakeWithInvalidRecordVersion
>> - Updated IllegalRecordVersion
>> -
On Tue, 17 Jan 2023 17:12:05 GMT, Matthew Donovan wrote:
>> - Updated ProtocolVersion.isNegotiable() to check a bounded range of version
>> numbers.
>> - Removed IllegalRecordVersion.java from ProblemList.txt
>>
>> Tested with jdk_security and jdk_security3 test groups.
>
> Matthew Donovan has
On Thu, 5 Jan 2023 21:55:42 GMT, Matthew Donovan wrote:
> * Updated the test for changes to the TLS implementation
> * Test supports TLS 1.2 and 1.3
> * Removed from ProblemList.txt
> * Refactored code a bit
Marked as reviewed by rhalade (Reviewer).
-
PR: https://git.openjdk.org/jd
On Thu, 5 Jan 2023 20:17:20 GMT, Matthew Donovan wrote:
>> Updated the test for TLS 1.2 and removed from ProblemList.txt
>
> Matthew Donovan has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - updated copyright to correct year
> - updated co
On Tue, 10 Jan 2023 18:59:30 GMT, Matthew Donovan wrote:
> - Updated ProtocolVersion.isNegotiable() to check a bounded range of version
> numbers.
> - Removed IllegalRecordVersion.java from ProblemList.txt
>
> Tested with jdk_security and jdk_security3 test groups.
This pull request has now b
On Fri, 23 Dec 2022 17:08:03 GMT, Matthew Donovan wrote:
> * updated test for new TLS protocols and ciphersuites
> * code cleanup
test/jdk/javax/net/ssl/SSLEngine/TestAllSuites.java line 2:
> 1: /*
> 2: * Copyright (c) 2003, 2022, Oracle and/or its affiliates. All rights
> reserved.
update t
On Tue, 17 Jan 2023 17:12:05 GMT, Matthew Donovan wrote:
>> - Updated ProtocolVersion.isNegotiable() to check a bounded range of version
>> numbers.
>> - Removed IllegalRecordVersion.java from ProblemList.txt
>>
>> Tested with jdk_security and jdk_security3 test groups.
>
> Matthew Donovan has
On Fri, 20 Jan 2023 22:03:29 GMT, Hai-May Chao wrote:
>> Please review the fix to address the problem in keytool -genseckey and
>> -importpass.
>
> Hai-May Chao has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update with Max's comment
Yea
On Wed, 25 Jan 2023 17:38:13 GMT, Eirik Bjorsnos wrote:
> This PR resurrects VerifySignedJar which currently tests nothing.
>
> VerifySignedJar currently verifies a binary JAR which was signed with SHA-1
> back in April 2000. Because SHA-1 signed JARs has been disabled for a while,
> the JAR i
This PR resurrects VerifySignedJar which currently tests nothing.
VerifySignedJar currently verifies a binary JAR which was signed with SHA-1
back in April 2000. Because SHA-1 signed JARs has been disabled for a while,
the JAR is treated as unsigned so the test doesn't really test anything as of
https://bugs.openjdk.org/browse/JDK-8301167 filed. Thanks.
> On Jan 25, 2023, at 12:49 PM, Eirik Bjørsnøs wrote:
>
> Hi,
>
> Can I get help filing a JBS issue for the following PR which
> resurrects the VerifySignedJar test now that SHA-1 is disabled:
>
> https://github.com/openjdk/jdk/pull/1
> On Jan 26, 2023, at 12:48 AM, Xuelei Fan wrote:
>
>
>> On Jan 25, 2023, at 8:43 PM, Wei-Jun Wang wrote:
>
>
>> If someone really cares about the result of getProvider(), they should be
>> careful no other thread calls encapsulation or decapsulation.
>
> If no-one care about the result o
On Fri, 20 Jan 2023 22:03:29 GMT, Hai-May Chao wrote:
>> Please review the fix to address the problem in keytool -genseckey and
>> -importpass.
>
> Hai-May Chao has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update with Max's comment
I s
22 matches
Mail list logo