Re: RFR: 8288047: Accelerate Poly1305 on x86_64 using AVX512 instructions

2022-10-21 Thread vpaprotsk
On Fri, 21 Oct 2022 18:20:10 GMT, Vladimir Kozlov wrote: >> Handcrafted x86_64 asm for Poly1305. Main optimization is to process 16 >> message blocks at a time. For more details, left a lot of comments in >> `macroAssembler_x86_poly.cpp`. >> >> - Added new KAT test for Poly1305 and a fuzz test

Re: RFR: 8288047: Accelerate Poly1305 on x86_64 using AVX512 instructions [v3]

2022-10-21 Thread vpaprotsk
> Handcrafted x86_64 asm for Poly1305. Main optimization is to process 16 > message blocks at a time. For more details, left a lot of comments in > `macroAssembler_x86_poly.cpp`. > > - Added new KAT test for Poly1305 and a fuzz test to compare intrinsic and > java. > - Would like to add an `I

Re: RFR: 8288047: Accelerate Poly1305 on x86_64 using AVX512 instructions

2022-10-21 Thread vpaprotsk
On Wed, 5 Oct 2022 21:28:26 GMT, vpaprotsk wrote: > Handcrafted x86_64 asm for Poly1305. Main optimization is to process 16 > message blocks at a time. For more details, left a lot of comments in > `macroAssembler_x86_poly.cpp`. > > - Added new KAT test for Poly1305 and a fuzz test to compare

Re: RFR: 8288047: Accelerate Poly1305 on x86_64 using AVX512 instructions [v2]

2022-10-21 Thread vpaprotsk
> Handcrafted x86_64 asm for Poly1305. Main optimization is to process 16 > message blocks at a time. For more details, left a lot of comments in > `macroAssembler_x86_poly.cpp`. > > - Added new KAT test for Poly1305 and a fuzz test to compare intrinsic and > java. > - Would like to add an `I

RFR: JDK-8293093 NPE in P11KeyStore.getID

2022-10-21 Thread Mark Powers
https://bugs.openjdk.org/browse/JDK-8293093 - Commit messages: - Merge - second iteration - first iteration Changes: https://git.openjdk.org/jdk/pull/10823/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10823&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293093

Re: RFR: JDK-8293093 NPE in P11KeyStore.getID

2022-10-21 Thread Mark Powers
On Fri, 21 Oct 2022 19:54:57 GMT, Mark Powers wrote: > https://bugs.openjdk.org/browse/JDK-8293093 I was finally able to reproduce this failure and was able to verify the fix. Took forever. - PR: https://git.openjdk.org/jdk/pull/10823

Re: RFR: 8288047: Accelerate Poly1305 on x86_64 using AVX512 instructions

2022-10-21 Thread Vladimir Kozlov
On Wed, 5 Oct 2022 21:28:26 GMT, vpaprotsk wrote: > Handcrafted x86_64 asm for Poly1305. Main optimization is to process 16 > message blocks at a time. For more details, left a lot of comments in > `macroAssembler_x86_poly.cpp`. > > - Added new KAT test for Poly1305 and a fuzz test to compare

Re: RFR: 8288047: Accelerate Poly1305 on x86_64 using AVX512 instructions

2022-10-21 Thread vpaprotsk
On Fri, 21 Oct 2022 09:57:14 GMT, Tobias Hartmann wrote: >> Handcrafted x86_64 asm for Poly1305. Main optimization is to process 16 >> message blocks at a time. For more details, left a lot of comments in >> `macroAssembler_x86_poly.cpp`. >> >> - Added new KAT test for Poly1305 and a fuzz test

Re: RFR: 8295729: Remove trailing whitespace from non-value lines in properties files [v2]

2022-10-21 Thread Andy Goryachev
On Fri, 21 Oct 2022 16:04:14 GMT, Naoto Sato wrote: > replace those dangling white spaces with explicit Unicode escapes this is a *very good* idea. - PR: https://git.openjdk.org/jdk/pull/10792

Re: RFR: 8295729: Remove trailing whitespace from non-value lines in properties files [v2]

2022-10-21 Thread Naoto Sato
On Fri, 21 Oct 2022 08:17:46 GMT, Magnus Ihse Bursie wrote: >> Properties files is essentially source code. It should have the same >> whitespace checks as all other source code, so we don't get spurious >> trailing whitespace changes. >> >> With the new Skara jcheck, it is possible to increas

Re: RFR: 8295729: Remove trailing whitespace from non-value lines in properties files [v2]

2022-10-21 Thread Erik Joelsson
On Fri, 21 Oct 2022 08:17:46 GMT, Magnus Ihse Bursie wrote: >> Properties files is essentially source code. It should have the same >> whitespace checks as all other source code, so we don't get spurious >> trailing whitespace changes. >> >> With the new Skara jcheck, it is possible to increas

Re: RFR: 8288047: Accelerate Poly1305 on x86_64 using AVX512 instructions

2022-10-21 Thread Tobias Hartmann
On Wed, 5 Oct 2022 21:28:26 GMT, vpaprotsk wrote: > Handcrafted x86_64 asm for Poly1305. Main optimization is to process 16 > message blocks at a time. For more details, left a lot of comments in > `macroAssembler_x86_poly.cpp`. > > - Added new KAT test for Poly1305 and a fuzz test to compare

Re: RFR: 8295729: Remove trailing whitespace from non-value lines in properties files [v2]

2022-10-21 Thread Magnus Ihse Bursie
On Fri, 21 Oct 2022 08:17:46 GMT, Magnus Ihse Bursie wrote: >> Properties files is essentially source code. It should have the same >> whitespace checks as all other source code, so we don't get spurious >> trailing whitespace changes. >> >> With the new Skara jcheck, it is possible to increas

Re: RFR: 8295729: Add jcheck whitespace checking for properties files [v2]

2022-10-21 Thread Magnus Ihse Bursie
> Properties files is essentially source code. It should have the same > whitespace checks as all other source code, so we don't get spurious trailing > whitespace changes. > > With the new Skara jcheck, it is possible to increase the coverage of the > whitespace checks (in the old mercurial ve