On Tue, 11 Oct 2022 15:17:13 GMT, Weijun Wang wrote:
>> Bill Huang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Implemented review comments.
>
> I have a question, why must this test be manual? Can't we compare the
> localized texts?
On Tue, 11 Oct 2022 18:53:54 GMT, Daniel Jeliński wrote:
>> This patch fixes the issue where a thread doing SSLSocket.close() could
>> destroy the read cipher while it was used by another thread doing
>> SSLSocket.read().
>>
>> The reported issue was triggered by SSLSocket.close() calling
>>
On Mon, 10 Oct 2022 14:28:07 GMT, Aleksei Efimov wrote:
>> ### Summary of the change
>> This change introduces new system and security properties for specifying
>> factory filters for the JNDI/LDAP and the JNDI/RMI JDK provider
>> implementations.
>>
>> These new properties allow more granula
On Tue, 11 Oct 2022 18:53:54 GMT, Daniel Jeliński wrote:
>> This patch fixes the issue where a thread doing SSLSocket.close() could
>> destroy the read cipher while it was used by another thread doing
>> SSLSocket.read().
>>
>> The reported issue was triggered by SSLSocket.close() calling
>>
On Fri, 7 Oct 2022 07:42:25 GMT, Daniel Jeliński wrote:
>> C_DeriveKey with mechanisms `CKM_*_KEY_AND_MAC_DERIVE` always returns mac
>> keys, even if macBits is zero. These keys must be free'd when no longer
>> needed.
>>
>> Verified that:
>> - SSL server configured with PKCS11-NSS provider le
On Tue, 11 Oct 2022 18:53:54 GMT, Daniel Jeliński wrote:
>> This patch fixes the issue where a thread doing SSLSocket.close() could
>> destroy the read cipher while it was used by another thread doing
>> SSLSocket.read().
>>
>> The reported issue was triggered by SSLSocket.close() calling
>>
> This patch fixes the issue where a thread doing SSLSocket.close() could
> destroy the read cipher while it was used by another thread doing
> SSLSocket.read().
>
> The reported issue was triggered by SSLSocket.close() calling
> inputRecord.close() -> readCipher.dispose() -> cipher.doFinal() o
On Fri, 7 Oct 2022 21:11:39 GMT, Daniel Jeliński wrote:
> This patch rewrites some BigInteger and curve point operations used in EC
> calculations:
> - coefficient * 2^power is equivalent to coefficient << power
> - number mod 2^n is equivalent to number & (2^n-1)
> - pair of IntegerModuloP oper
On Tue, 11 Oct 2022 15:17:13 GMT, Weijun Wang wrote:
> I have a question, why must this test be manual? Can't we compare the
> localized texts?
Thought about that, but it could be a nuisance if we compared word-to-word
translations, considering the situation if an engineer made some changes in
On Tue, 11 Oct 2022 17:03:47 GMT, Naoto Sato wrote:
> I have a question, why must this test be manual? Can't we compare the
> localized texts?
@wangweij Good question. We can definitely compare the localized texts at least
some keywords. The fact that automation is one of the goals of this tas
On Tue, 11 Oct 2022 14:38:35 GMT, Daniel Jeliński wrote:
> This patch fixes the issue where a thread doing SSLSocket.close() could
> destroy the read cipher while it was used by another thread doing
> SSLSocket.read().
>
> The reported issue was triggered by SSLSocket.close() calling
> inputR
On Fri, 7 Oct 2022 21:11:39 GMT, Daniel Jeliński wrote:
> This patch rewrites some BigInteger and curve point operations used in EC
> calculations:
> - coefficient * 2^power is equivalent to coefficient << power
> - number mod 2^n is equivalent to number & (2^n-1)
> - pair of IntegerModuloP oper
On Wed, 5 Oct 2022 05:43:32 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have the code clean up reviewed?
>
> There is a lot of computation in AESCrypt class load, which could be avoid by
> using the computation result directly. The computation takes 6.971875
> milliseconds in a MacOS M1 l
On Tue, 11 Oct 2022 00:05:05 GMT, Valerie Peng wrote:
> Mach5 result looks ok. There is one unexpected test failure but it seems
> unrelated
> (https://mach5.us.oracle.com:10060/api/v1/results/vpeng-jdkOh-20221010-1957-37280778-open_test_lib-test-linux-x64-122-1665432715-16/log)
> . So, it sho
This patch fixes the issue where a thread doing SSLSocket.close() could destroy
the read cipher while it was used by another thread doing SSLSocket.read().
The reported issue was triggered by SSLSocket.close() calling
inputRecord.close() -> readCipher.dispose() -> cipher.doFinal() on an AES/GCM
On Mon, 10 Oct 2022 23:23:00 GMT, Bill Huang wrote:
>> The jarsigner and keytool are localized into English, German, Japanese and
>> Simplified Chinese. This task is to modify the existing i18n tests to
>> validate i18n compliance in these tools.
>>
>> In addition, this task also contains cha
On Tue, 11 Oct 2022 12:39:14 GMT, Sean Mullan wrote:
>> @seanjmullan - I looked at that approach. The
>> `SharedSecrets.getJavaSecurityAccess().getInitialProperties();` call may
>> trigger early initialization of the `java.security.Security` class - I'm not
>> sure if we want that. Protection
On Tue, 11 Oct 2022 11:28:10 GMT, Sean Coffey wrote:
>> What about creating a new `JavaSecurityPropertiesAccess` class and moving
>> the accessor method there? It seems it would be cleaner to remove the
>> dependency on PD in the long run.
>
> @seanjmullan - I looked at that approach. The
> `
On Mon, 10 Oct 2022 20:54:58 GMT, Sean Mullan wrote:
>> modified code to have Security class hold the initial properties and
>> provided an accessor method
>
> What about creating a new `JavaSecurityPropertiesAccess` class and moving the
> accessor method there? It seems it would be cleaner to
On Sat, 23 Jul 2022 05:29:07 GMT, jquanC wrote:
>> There are some doc errors in sun.security.util.DerOutputStream, like the
>> followings,
>>
>>
>> /**
>> * Private helper routine for writing DER encoded string values.
>> * @param s the string to write
>> * @param stringTag one of the DER s
On Mon, 10 Oct 2022 19:23:51 GMT, Sean Coffey wrote:
>> New JFR event to record state of initial security properties.
>>
>> Debug output is also now added for these properties via
>> -Djava.security.debug=properties
>
> Sean Coffey has updated the pull request incrementally with one additional
This patch rewrites some BigInteger and curve point operations used in EC
calculations:
- coefficient * 2^power is equivalent to coefficient << power
- number mod 2^n is equivalent to number & (2^n-1)
- pair of IntegerModuloP operations:
t2 = t1+t1
t1 = t1+t2
is equivalent to t1=t1*3, which is now
22 matches
Mail list logo
