Re: RFR: 8294248: Use less limbs for P256 in EC implementation

2022-09-23 Thread Xue-Lei Andrew Fan
On Thu, 22 Sep 2022 20:40:08 GMT, Xue-Lei Andrew Fan wrote: > Hi, > > Please review this performance improvement for Secp256R1 implementation in > OpenJDK. With this update, there is an about 20% performance improvement for > Secp256R1 key generation and signature. > > Basically, 256 bits EC

Re: RFR: 8293592: Remove JVM_StopThread, stillborn, and related cleanup [v2]

2022-09-23 Thread David Holmes
On Fri, 23 Sep 2022 18:21:30 GMT, Chris Plummer wrote: >> David Holmes has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 16 commits: >> >> - Merge branch 'master' into 8293592-JVM_StopThread >> - Removal all special handling of Th

Re: RFR: 8293592: Remove JVM_StopThread, stillborn, and related cleanup

2022-09-23 Thread David Holmes
On Fri, 23 Sep 2022 06:17:34 GMT, David Holmes wrote: > Now that Thread.stop has been degraded to throw > `UnsupportedOperationException` (JDK-8299610) the only direct source of async > exceptions is from JVMTI `StopThread`. We can remove the `JVM_StopThread` > code, remove the `stillborn` fie

Re: RFR: 8293592: Remove JVM_StopThread, stillborn, and related cleanup [v2]

2022-09-23 Thread David Holmes
> Now that Thread.stop has been degraded to throw > `UnsupportedOperationException` (JDK-8299610) the only direct source of async > exceptions is from JVMTI `StopThread`. We can remove the `JVM_StopThread` > code, remove the `stillborn` field from `java.lang.Thread` and its associated > accesse

Re: RFR: 8293592: Remove JVM_StopThread, stillborn, and related cleanup

2022-09-23 Thread Chris Plummer
On Fri, 23 Sep 2022 06:17:34 GMT, David Holmes wrote: > Now that Thread.stop has been degraded to throw > `UnsupportedOperationException` (JDK-8299610) the only direct source of async > exceptions is from JVMTI `StopThread`. We can remove the `JVM_StopThread` > code, remove the `stillborn` fie

Re: RFR: 8215788: Clarify JarInputStream Manifest access [v12]

2022-09-23 Thread Sean Mullan
On Tue, 20 Sep 2022 18:08:23 GMT, Lance Andersen wrote: >> Please review this PR which updates the JarInputStream class description to >> clarify when the Manifest is accessible via JarInputStream::getManifest and >> JarInputStream::get[Jar]Entry. >> >> It is worth noting that with this updat

Re: RFR: 8215788: Clarify JarInputStream Manifest access [v12]

2022-09-23 Thread Lance Andersen
On Fri, 23 Sep 2022 17:38:47 GMT, Sean Mullan wrote: > As a side comment, I notice that `JarInputStream` capitalizes "JAR", whereas > `JarFile` does not ("jar"). We should really be consistent in our javadocs. I > think "JAR" is more correct, mainly because that is what the Jar File > specific

Re: RFR: 8215788: Clarify JarInputStream Manifest access [v12]

2022-09-23 Thread Sean Mullan
On Tue, 20 Sep 2022 18:08:23 GMT, Lance Andersen wrote: >> Please review this PR which updates the JarInputStream class description to >> clarify when the Manifest is accessible via JarInputStream::getManifest and >> JarInputStream::get[Jar]Entry. >> >> It is worth noting that with this updat

Re: RFR: 8293592: Remove JVM_StopThread, stillborn, and related cleanup

2022-09-23 Thread Alan Bateman
On Fri, 23 Sep 2022 06:17:34 GMT, David Holmes wrote: > Now that Thread.stop has been degraded to throw > `UnsupportedOperationException` (JDK-8299610) the only direct source of async > exceptions is from JVMTI `StopThread`. We can remove the `JVM_StopThread` > code, remove the `stillborn` fie

Re: RFR: 8294248: Use less limbs for P256 in EC implementation

2022-09-23 Thread Daniel JeliƄski
On Fri, 23 Sep 2022 07:39:07 GMT, Xue-Lei Andrew Fan wrote: > Limb values will always fit within a long, so inputs to multiplication must > be less than 32 bits. *All IntegerPolynomial implementations allow at most > one addition before multiplication*. Additions after that will result in an >

RFR: 8293592: Remove JVM_StopThread, stillborn, and related cleanup

2022-09-23 Thread David Holmes
Now that Thread.stop has been degraded to throw `UnsupportedOperationException` (JDK-8299610) the only direct source of async exceptions is from JVMTI `StopThread`. We can remove the `JVM_StopThread` code, remove the `stillborn` field from `java.lang.Thread` and its associated accesses from the

Re: RFR: 8294248: Use less limbs for P256 in EC implementation

2022-09-23 Thread Xue-Lei Andrew Fan
On Thu, 22 Sep 2022 20:40:08 GMT, Xue-Lei Andrew Fan wrote: > Hi, > > Please review this performance improvement for Secp256R1 implementation in > OpenJDK. With this update, there is an about 20% performance improvement for > Secp256R1 key generation and signature. > > Basically, 256 bits EC