On Sat, 23 Jul 2022 05:31:29 GMT, Xue-Lei Andrew Fan wrote:
> Looks good to me. Thanks!
Cheers and appreciation! And I have learned more from your guidance.
-
PR: https://git.openjdk.org/jdk/pull/9585
On Sat, 23 Jul 2022 05:29:07 GMT, jquanC wrote:
>> There are some doc errors in sun.security.util.DerOutputStream, like the
>> followings,
>>
>>
>> /**
>> * Private helper routine for writing DER encoded string values.
>> * @param s the string to write
>> * @param stringTag one of the DER s
> There are some doc errors in sun.security.util.DerOutputStream, like the
> followings,
>
>
> /**
> * Private helper routine for writing DER encoded string values.
> * @param s the string to write
> * @param stringTag one of the DER string tags that indicate which
> * encoding should be use
open l10n msg drop
All tests passed.
-
Commit messages:
- open l10n drop
Changes: https://git.openjdk.org/jdk19/pull/154/files
Webrev: https://webrevs.openjdk.org/?repo=jdk19&pr=154&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8290889
Stats: 3930 lines in 44 files change
On Fri, 22 Jul 2022 17:39:20 GMT, Weijun Wang wrote:
> Two comments:
>
> 1. You reverted the `s/i/buf/` change in `putInteger`.
> 2. The other constructor also uses `an DER output steam`. Since you already
> fixed one, please take care of this one as well.
Got it, I will take care of that.
--
On Fri, 22 Jul 2022 17:37:40 GMT, Weijun Wang wrote:
> A spec for an argument should be a noun. You can add attributes to describe
> it in more detail, which can be an adjective, or even a clause. This is
> what's shown in the 2nd line (I cannot call it a sentence because it's just a
> noun wi
On Fri, 22 Jul 2022 17:59:51 GMT, Mark Powers wrote:
> https://bugs.openjdk.org/browse/JDK-8290887
Marked as reviewed by xuelei (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/9616
On Fri, 22 Jul 2022 17:59:51 GMT, Mark Powers wrote:
> https://bugs.openjdk.org/browse/JDK-8290887
Thanks.
-
PR: https://git.openjdk.org/jdk/pull/9616
On Fri, 22 Jul 2022 17:59:51 GMT, Mark Powers wrote:
> https://bugs.openjdk.org/browse/JDK-8290887
LGTM.
-
Marked as reviewed by weijun (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9616
On Mon, 18 Jul 2022 17:53:56 GMT, Mark Powers wrote:
> https://bugs.openjdk.org/browse/JDK-8155039
Opened JDK-8290887 to fix a different issue while working on JDK-8155039.
Closing JDK-8155039 as Will-Not-Fix.
-
PR: https://git.openjdk.org/jdk/pull/9542
https://bugs.openjdk.org/browse/JDK-8290887
-
Commit messages:
- first iteration
Changes: https://git.openjdk.org/jdk/pull/9616/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9616&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8290887
Stats: 26 lines in 1 file chan
On Mon, 18 Jul 2022 17:53:56 GMT, Mark Powers wrote:
> https://bugs.openjdk.org/browse/JDK-8155039
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/9542
On Fri, 22 Jul 2022 15:56:58 GMT, jquanC wrote:
>> src/java.base/share/classes/sun/security/util/DerOutputStream.java line 464:
>>
>>> 462: * @param stringTag one of the DER string tags that indicate which
>>> 463: * encoding should be used to write the string out.
>>> 464: * @par
On Fri, 22 Jul 2022 16:29:55 GMT, jquanC wrote:
>> There are some doc errors in sun.security.util.DerOutputStream, like the
>> followings,
>>
>>
>> /**
>> * Private helper routine for writing DER encoded string values.
>> * @param s the string to write
>> * @param stringTag one of the DER s
> There are some doc errors in sun.security.util.DerOutputStream, like the
> followings,
>
>
> /**
> * Private helper routine for writing DER encoded string values.
> * @param s the string to write
> * @param stringTag one of the DER string tags that indicate which
> * encoding should be use
On Fri, 22 Jul 2022 15:11:43 GMT, Xue-Lei Andrew Fan wrote:
>> jquanC has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> 8290775: Some doc errors in DerOutputStream.java Update:correct the tense
>> problem of expression
>
> src/java.base/
On Mon, 18 Jul 2022 17:53:56 GMT, Mark Powers wrote:
> https://bugs.openjdk.org/browse/JDK-8155039
JDK-8290887 has been filed for the separate cleanup.
-
PR: https://git.openjdk.org/jdk/pull/9542
On Fri, 22 Jul 2022 14:56:34 GMT, jquanC wrote:
>> There are some doc errors in sun.security.util.DerOutputStream, like the
>> followings,
>>
>>
>> /**
>> * Private helper routine for writing DER encoded string values.
>> * @param s the string to write
>> * @param stringTag one of the DER s
> There are some doc errors in sun.security.util.DerOutputStream, like the
> followings,
>
>
> /**
> * Private helper routine for writing DER encoded string values.
> * @param s the string to write
> * @param stringTag one of the DER string tags that indicate which
> * encoding should be use
On Fri, 22 Jul 2022 12:44:54 GMT, Weijun Wang wrote:
> `s/is should used/should be used/`.
Thanks for your advice!
Yes, the passive voice should be used.
I may offer an update like:
@param charset the charset should be used corresponding to the above tag.
-
PR: https://git.openjdk
On Fri, 22 Jul 2022 08:27:38 GMT, jquanC wrote:
>> There are some doc errors in sun.security.util.DerOutputStream, like the
>> followings,
>>
>>
>> /**
>> * Private helper routine for writing DER encoded string values.
>> * @param s the string to write
>> * @param stringTag one of the DER s
On Fri, 1 Jul 2022 08:06:10 GMT, Сергей Цыпанов wrote:
> In case we read all bytes from an `InputStream` we don't need wrapping with
> `BufferedInputStream` as the bytes are not written into internal buffer. With
> removal of redundant buffer we save 8 kB of allocated memory.
This pull request
On Fri, 1 Jul 2022 08:06:10 GMT, Сергей Цыпанов wrote:
> In case we read all bytes from an `InputStream` we don't need wrapping with
> `BufferedInputStream` as the bytes are not written into internal buffer. With
> removal of redundant buffer we save 8 kB of allocated memory.
The tests complet
On Fri, 22 Jul 2022 10:22:39 GMT, Matthias Baesken wrote:
>> The issue https://bugs.openjdk.org/browse/JDK-8282538 gave an example of the
>> following PKCS11 exception (see attached jtr files of that bug) :
>>
>> Caused by: sun.security.pkcs11.wrapper.PKCS11Exception: 0xCE534351
>>
>> Unf
> The issue https://bugs.openjdk.org/browse/JDK-8282538 gave an example of the
> following PKCS11 exception (see attached jtr files of that bug) :
>
> Caused by: sun.security.pkcs11.wrapper.PKCS11Exception: 0xCE534351
>
> Unfortunately the error code 0xCE534351 is currently not in the RV/er
On Thu, 21 Jul 2022 15:37:40 GMT, Сергей Цыпанов wrote:
> We can use `InputStream.readAllBytes()` in `ModuleHashes` and `X509CertPath`.
Could one advise how to execute smth like `jmod hash --module-path
~/openjdk-18.0.2/Contents/Home/jmods --hash-modules .*`? This command doesn't
work for me.
> There are some doc errors in sun.security.util.DerOutputStream, like the
> followings,
>
>
> /**
> * Private helper routine for writing DER encoded string values.
> * @param s the string to write
> * @param stringTag one of the DER string tags that indicate which
> * encoding should be use
On Thu, 21 Jul 2022 21:14:44 GMT, Mark Reinhold wrote:
> Please revise the summary to say “... instead of explicit loops”.
Done.
> Please measure this (using, e.g., [JMH](https://github.com/openjdk/jmh))
> before making such a change.
I'm aware of JMH, I was asking mostly about public API I s
28 matches
Mail list logo
