[screen-devel] [bug #58256] Error when swich between screens, parallel typing

2020-04-28 Thread Václav Doležal
Follow-up Comment #3, bug #58256 (project screen): This is not a bug, this is an expected behaviour. You just made both regions show the same window – look at the bottom lines, it shows "0 bash" under both regions. ___ Reply to this item a

[screen-devel] [PATCH for screen-v4] Expand d_xtermosc array in struct display

2020-02-21 Thread Václav Doležal
of bounds access when setting w_xtermosc after OSC 49) Signed-off-by: Václav Doležal --- src/display.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/display.h b/src/display.h index 459cc5d..4fc2061 100644 --- a/src/display.h +++ b/src/display.h @@ -112,7 +112,7 @@ stru

[screen-devel] [PATCH for master] Expand d_xtermosc array in struct Display

2020-02-21 Thread Václav Doležal
of bounds access when setting w_xtermosc after OSC 49) Signed-off-by: Václav Doležal --- src/display.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/display.h b/src/display.h index 0caaca1..531b9c8 100644 --- a/src/display.h +++ b/src/display.h @@ -124,7 +124,7 @@ stru

Re: [screen-devel] GNU Screen v.4.8.0

2020-02-13 Thread Václav Doležal
it/commit/?h=screen-v4&id=c5db181b6e017cfccb8d7842ce140e59294d9f62 note the deletion of ``` if (--typ2 < 0) typ2 = 0; ``` At least I can't reproduce this issue on v.4.6.2. Regards, Václav Doležal

[screen-devel] [PATCH v2 for screen-v4] Backport support for bracketed-paste and DECSCUSR

2020-01-22 Thread Václav Doležal
Backported commit c389013e89e7b04ce43872f2e72d43f77461a3c0 Applied fix from d2d33f664132e9473c62f37a4758a047fa83eb7a Reference: https://lists.gnu.org/archive/html/screen-devel/2013-03/msg0.html Authored-by: Hayaki Saito Backported-by: Václav Doležal Signed-off-by: Václav Doležal --- I

[screen-devel] [PATCH for screen-v4] Backport support for bracketed-paste and DECSCUSR

2020-01-22 Thread Václav Doležal
Reference: c389013e89e7b04ce43872f2e72d43f77461a3c0 Reference: https://lists.gnu.org/archive/html/screen-devel/2013-03/msg0.html Authored-by: Hayaki Saito Backported-by: Václav Doležal Signed-off-by: Václav Doležal --- src/ansi.c| 12 src/display.c | 54

Re: [screen-devel] [PATCH for screen-v4] Fix screen leaving zombie processes

2019-11-06 Thread Václav Doležal
, Václav Doležal --- #include #include int main() { signal(SIGHUP, SIG_IGN); close(0); close(1); close(2); sleep(30); return 0; } --- Dne 02. 11. 19 v 22:59 Amadeusz Sławiński napsal(a): > When window dies we should wait for child process to

[screen-devel] [PATCH 6/6] Fix confusing indentation on several places

2018-11-07 Thread Václav Doležal
Signed-off-by: Vaclav Dolezal --- src/fileio.c | 2 +- src/help.c | 6 +++--- src/screen.c | 68 ++-- 3 files changed, 38 insertions(+), 38 deletions(-) diff --git a/src/fileio.c b/src/fileio.c index 14bb9b1..4fad224 100644 --- a/src/fi

[screen-devel] [PATCH 5/6] Fix possible unterminated string

2018-11-07 Thread Václav Doležal
Signed-off-by: Vaclav Dolezal --- src/pty.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/pty.c b/src/pty.c index 1c0660e..eba3bb0 100644 --- a/src/pty.c +++ b/src/pty.c @@ -279,7 +279,13 @@ char **ttyn; return -1; } signal(SIGCHLD, sigcld); - strn

[screen-devel] [PATCH 2/6] Fix file descriptor leak

2018-11-07 Thread Václav Doležal
Signed-off-by: Vaclav Dolezal --- src/socket.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/socket.c b/src/socket.c index 88c3dd8..ebf55f9 100644 --- a/src/socket.c +++ b/src/socket.c @@ -720,7 +720,7 @@ struct NewWindow *nwin; if (getcwd(m.m.create.dir, sizeof(m.

[screen-devel] [PATCH 3/6] Revert "those 0 assignment made rest of code totally not working"

2018-11-07 Thread Václav Doležal
This reverts commit ff98d7ff5847e07a55b0c40c2ccc3bc430226ca0. This can potentially cause double-free. `nmlines' and `nhlines' should be freed in preceding lines. `nmlines' and `nhlines' are not used in the rest of the function except in `nomem' label and their valuse are copied into `p', so their

[screen-devel] [PATCH 4/6] Fix for nomem handling in resize.c:ChangeWindowSize()

2018-11-07 Thread Václav Doležal
Move `nomem' label of ChangeWindowSize() to the end of function and add test for value of `nhlines' Signed-off-by: Vaclav Dolezal --- src/resize.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/src/resize.c b/src/resize.c index 7ed1

[screen-devel] [PATCH 0/6] Fixes for several defects and warnings found by static analysis

2018-11-07 Thread Václav Doležal
Hello, I'm sending several patches addressing issues found by static analysis. Regards, Václav Doležal -- Defects found: Error: BUFFER_SIZE (CWE-120): screen-4.6.2/screen.c:1274: buffer_size: Calling strncpy with a source string whose length (6 chars) is greater than or equal to the

[screen-devel] [PATCH 1/6] Use memcpy(3) in string substitution

2018-11-07 Thread Václav Doležal
Signed-off-by: Vaclav Dolezal --- src/screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/screen.c b/src/screen.c index c3417e3..0d37195 100644 --- a/src/screen.c +++ b/src/screen.c @@ -1271,7 +1271,7 @@ int main(int ac, char** av) ap = av0 + strlen(av0) - 1; wh