Re: [sage-devel] Should I report codepaths leading to comparing incomparable objects?

2023-07-03 Thread David Coudert
Thanks for reporting this issue. I have opened an issue (https://github.com/sagemath/sage/issues/35889) and will propose a fix asap. On Sunday, July 2, 2023 at 6:37:45 PM UTC+2 Georgi Guninski wrote: > You definitely can construct graph with incomparable vertices > and they worked as expected in

[sage-devel] grep-ing for sort() in graphs

2023-07-03 Thread Georgi Guninski
In a QA attempt I tried to find calling sort() in graphs without |key|, which may raise exception. On sage 9.6: $cd /usr/lib64/python3.11/site-packages/sage/graphs/ $grep -rnI 'sort(' . | grep -v 'key=' | grep -v 'topological' #15 results ./base/static_sparse_backend.pyx:512:vertic